Matthias Krüger
71120ef1e5
Fix typos found by codespell.
2018-08-19 17:41:28 +02:00
Eduard-Mihai Burtescu
14aed81d9a
Use the new Entry::or_default method where possible.
2018-08-18 20:19:45 +03:00
Guillaume Gomez
cf5ee8f59b
Fix links' color
2018-08-15 15:07:07 +02:00
Guillaume Gomez
34956ac0f6
Rollup merge of #53267 - GuillaumeGomez:fix-styles, r=QuietMisdreavus
...
Fix styles
Fixes #53262 .
r? @QuietMisdreavus
2018-08-12 23:27:02 +02:00
Guillaume Gomez
5a801c89d0
Fix styles
2018-08-11 13:34:15 +02:00
Guillaume Gomez
e37391b389
Remove unwanted console log
2018-08-10 18:48:36 +02:00
kennytm
dad5b6c554
Rollup merge of #53094 - GuillaumeGomez:automatic-expand, r=nrc
...
Automatically expand section if url id point to one of its component
Fixes #52517 .
r? @nrc
2018-08-09 16:58:41 +08:00
kennytm
c6f55bca7f
Rollup merge of #52773 - ljedrz:unncecessary_patterns, r=nikomatsakis
...
Avoid unnecessary pattern matching against Option and Result
2018-08-09 16:58:39 +08:00
ljedrz
44d32d4413
Avoid unnecessary pattern matching against Option and Result
2018-08-07 10:24:27 +02:00
Guillaume Gomez
c70eb4b6ea
Automatically expand section if url id point to one of its component
2018-08-05 19:44:10 +02:00
Mike Boutin
3f92ff34b5
Change rustdoc style so fully qualified names do not overlap src links
...
A type's fully qualified name will now wrap once it gets to the
`[-][src]` link aligned against the right edge of the content area.
Previously the two would overlap and the name would only wrap when
hitting the edge of the content area. The `[-][src]` link will main at
the top of the header.
2018-08-05 10:43:04 -04:00
kennytm
b643351c08
Rollup merge of #53050 - carols10cents:rustdoc-moar-room, r=GuillaumeGomez
...
Make left column of rustdoc search results narrower
To make more room for the description of the item
The description often has useful text that helps disambiguate between search results, but very little of it is shown.
As a side effect, this breaks the alignment between the search results and the "In Return Types" tab, which tends to line up above the description-- up until I started investigating this, I thought "In Names"/"In Parameters"/"In Return Types" were column headers and I just never saw search results that had info for the "In Parameters" middle column! Now, with the two columns of search results each taking up about a half, they look more like tabs than column headers.
Types that are long still wrap and look good-- I made some artificially long types in the following screenshots.
Before screenshot:
<img width="1258" alt="screen shot 2018-08-03 at 8 32 35 pm" src="https://user-images.githubusercontent.com/193874/43670805-56e3b3b4-975e-11e8-9296-600837d03de2.png ">
After screenshot:
<img width="1239" alt="screen shot 2018-08-03 at 8 31 17 pm" src="https://user-images.githubusercontent.com/193874/43670810-6591f9ac-975e-11e8-9e12-4ea9ab1e5806.png ">
2018-08-04 17:20:10 +08:00
kennytm
aefa307c1f
Rollup merge of #53047 - integer32llc:rustdoc-clicky-clicky, r=QuietMisdreavus
...
Make entire row of doc search results clickable
By adding empty `after` content that clears and is `display: block`.
Technique found here: https://stackoverflow.com/a/7817313/51683
Now any part of a documentation search result that is highlighted when
you hover over it should also be clickable.
NOTE: THE BELOW IMAGES ARE GIFS BUT I DIDN'T MAKE THEM LOOP, OPEN IN A NEW TAB TO SEE THEM SORRY SORRY
Here's what happens before this change: my mouse cursor is in the middle of the table cell, and the row is highlighted which makes it look like clicking should have an effect, but clicking doesn't do anything:
After this change, clicking in the middle of the cell works!
It even works nicely when the type is really long and wraps! (I created the type artificially because I couldn't find a long enough one in the wild)
2018-08-04 14:36:02 +08:00
kennytm
e8060a4229
Rollup merge of #53041 - GuillaumeGomez:fix-code-css-rule, r=QuietMisdreavus
...
Fix invalid code css rule
Fixes #53017 .
r? @QuietMisdreavus
2018-08-04 14:36:00 +08:00
Carol (Nichols || Goulding)
d5dd37b00f
Make left column of rustdoc search results narrower
...
To make more room for the description of the item
2018-08-03 20:39:58 -04:00
Carol (Nichols || Goulding)
11ffeed1ed
Make entire row of doc search results clickable
...
By adding empty `after` content that clears and is `display: block`.
Technique found here: https://stackoverflow.com/a/7817313/51683
Now any part of a documentation search result that is highlighted when
you hover over it should also be clickable.
2018-08-03 18:29:49 -04:00
Guillaume Gomez
e2cda7dd82
Fix invalid code css rule
2018-08-03 23:30:16 +02:00
Mark Rousskov
4cd004775c
Add dyn to Write
2018-07-31 17:55:12 -06:00
Mark Rousskov
8e65a46268
Cleanup highlighting code
...
Removes some unused code and de-publicizes structs
2018-07-31 17:55:12 -06:00
Mark Rousskov
7bea518d3a
Remove global derive_id and reset_ids functions
...
Previously these functions relied on TLS but we can instead thread the
relevant state through explicitly.
2018-07-31 17:55:12 -06:00
Mark Rousskov
2216db9de7
Format code for easier editing
2018-07-31 11:39:04 -06:00
Mark Rousskov
01d95558e6
Further extract error code switch
...
Removes dependency on UnstableFeatures from markdown rendering
2018-07-31 11:39:02 -06:00
Mark Rousskov
03e34f8f81
Remove dependency on error handling from find_testable_code
2018-07-31 11:37:21 -06:00
Mark Rousskov
de5cebdba5
Provide test configuration through struct
...
This is far more sound than passing many different arguments of the same
type.
2018-07-31 11:37:21 -06:00
Mark Rousskov
ad40e4517f
Provide warnings for invalid code blocks in markdown files
...
Previously we would only warn on Rust code but we can also do so when
testing markdown (the diag::Handler is available).
2018-07-31 11:37:21 -06:00
Mark Rousskov
0af5a6be05
Pull out nightly checking to edges
...
Parsing the code block's LangString (```foo) previously checked itself
to see if we were on nightly; that isn't the right place to do so. Move
that check slightly outwards to better abstract LangString.
(This is also an optimization as we avoid the costly environment
variable load of RUSTC_BOOTSTRAP).
2018-07-31 11:37:21 -06:00
Mark Rousskov
620c4fdf53
Delete unused code in rustdoc
2018-07-30 16:33:56 -06:00
bors
7bbcd005b3
Auto merge of #52805 - ljedrz:format_str_literal, r=petrochenkov
...
Don't format!() string literals
Prefer `to_string()` to `format!()` take 2, this time targetting string literals. In some cases (`&format!("...")` -> `"..."`) also removes allocations. Occurences of `format!("")` are changed to `String::new()`.
2018-07-30 06:29:39 +00:00
bors
023fd7e74a
Auto merge of #52767 - ljedrz:avoid_format, r=petrochenkov
...
Prefer to_string() to format!()
Simple benchmarks suggest in some cases it can be faster by even 37%:
```
test converting_f64_long ... bench: 339 ns/iter (+/- 199)
test converting_f64_short ... bench: 136 ns/iter (+/- 34)
test converting_i32_long ... bench: 87 ns/iter (+/- 16)
test converting_i32_short ... bench: 87 ns/iter (+/- 49)
test converting_str ... bench: 54 ns/iter (+/- 15)
test formatting_f64_long ... bench: 349 ns/iter (+/- 176)
test formatting_f64_short ... bench: 145 ns/iter (+/- 14)
test formatting_i32_long ... bench: 98 ns/iter (+/- 14)
test formatting_i32_short ... bench: 93 ns/iter (+/- 15)
test formatting_str ... bench: 86 ns/iter (+/- 23)
```
2018-07-29 09:33:37 +00:00
bors
a5c2d0fffa
Auto merge of #52764 - sinkuu:cleanup, r=nikomatsakis
...
Misc cleanups
2018-07-29 06:32:24 +00:00
bors
dab71516f1
Auto merge of #52585 - GuillaumeGomez:generic-impls, r=QuietMisdreavus
...
[rustdoc] Generic impls
Fixes #33772 .
r? @QuietMisdreavus
2018-07-28 20:44:17 +00:00
ljedrz
421b2ba347
Don't format!() string literals
2018-07-28 17:58:52 +02:00
Guillaume Gomez
7a3c7b2097
Don't display full blanket implementation and put it into its own section
2018-07-28 15:18:38 +02:00
kennytm
59f8422a17
Rollup merge of #52781 - ljedrz:avoid_vec_arguments, r=nikomatsakis
...
Use a slice where a vector is not necessary
2018-07-28 16:25:07 +08:00
ljedrz
1cca420435
Use slices where a vector is not necessary
2018-07-27 16:50:28 +02:00
Shotaro Yamada
3525368a56
Use str::repeat
2018-07-27 23:26:36 +09:00
ljedrz
57a5a9b054
Prefer to_string() to format!()
2018-07-27 11:11:18 +02:00
Tatsuyuki Ishi
66c4dc9769
Add missing dyn
2018-07-25 10:24:31 +09:00
Guillaume Gomez
d64c2ac01a
Improve code
2018-07-22 21:03:21 +02:00
Guillaume Gomez
3e96ac1178
Cleanup
2018-07-22 21:02:44 +02:00
Guillaume Gomez
2bc7c03af6
Add filter over non generic impls
2018-07-22 21:02:24 +02:00
Guillaume Gomez
e8cca55283
Working generic impl
2018-07-22 21:02:23 +02:00
Guillaume Gomez
73cb82384a
some improvements
2018-07-22 21:01:12 +02:00
Guillaume Gomez
ccdf4ae814
part 2
2018-07-22 20:58:51 +02:00
Guillaume Gomez
39849d5128
First step to generic trait impls
2018-07-22 20:58:51 +02:00
bors
c7cba3d33f
Auto merge of #52024 - oli-obk:existential_parse, r=nikomatsakis
...
Implement existential types
(not for associated types yet)
r? @nikomatsakis
cc @Centril @varkor @alexreg
2018-07-19 21:14:01 +00:00
bors
11864c4e6c
Auto merge of #51854 - davidtwco:rfc-2008-rustdoc, r=QuietMisdreavus
...
RFC 2008 non-exhaustive enums/structs: Rustdoc
Part of #44109 . Not sure how those who maintain rustdoc primarily would prefer this addition look or where it should be placed, happy to make any changes required.
r? @QuietMisdreavus (not sure if this is the right person, just guessing)
2018-07-19 19:03:03 +00:00
Oliver Schneider
9017f79282
Generate a page for existential types
2018-07-19 18:11:28 +02:00
David Wood
b671bdc381
Updated FRU terminology.
2018-07-19 17:03:17 +01:00
QuietMisdreavus
5d5414480c
remove FIXME about macro redirects
...
Based on the discussion in #35705 , the rustdoc team has determined that macro redirects are here to stay.
Closes #35705
2018-07-18 15:41:13 -05:00
