Vadim Petrochenkov
7e66e9d6b0
More precise spans for HIR paths
2021-03-15 22:13:45 +03:00
bors
a62a76047e
Auto merge of #77524 - Patryk27:fixes/66228, r=estebank
...
Rework diagnostics for wrong number of generic args (fixes #66228 and #71924 )
This PR reworks the `wrong number of {} arguments` message, so that it provides more details and contextual hints.
2021-01-13 20:35:58 +00:00
Mark Rousskov
8a3edb1d66
Update tests for extern block linting
2021-01-13 07:49:16 -05:00
Patryk Wychowaniec
d2f8e398f1
Rework diagnostics for wrong number of generic args
2021-01-10 13:07:40 +01:00
C
206b2ca61e
test: updated expected Vec src path
2020-12-29 14:03:30 +00:00
Tim Diekmann
9274b37d99
Rename AllocRef to Allocator and (de)alloc to (de)allocate
2020-12-04 14:47:15 +01:00
Tim Diekmann
8725e4c337
Add support for custom allocators in Vec
2020-11-18 19:34:19 +01:00
Fabian Zaiser
3a7a997323
Implement destructuring assignment for tuples
...
Co-authored-by: varkor <github@varkor.com>
2020-11-07 13:17:19 +00:00
Tyler Mandry
5ea55518bc
Rollup merge of #75984 - kornelski:typeormodule, r=matthewjasper
...
Improve unresolved use error message
"use of undeclared type or module `foo`" doesn't mention that it could be a crate.
This error can happen when users forget to add a dependency to `Cargo.toml`, so I think it's important to mention that it could be a missing crate.
I've used a heuristic based on Rust's naming conventions. It complains about an unknown type if the ident starts with an upper-case letter, and crate or module otherwise. It seems to work very well. The expanded error help covers both an unknown type and a missing crate case.
2020-09-09 15:05:45 -07:00
Dan Aloni
07e7823c01
pretty: trim paths of unique symbols
...
If a symbol name can only be imported from one place for a type, and
as long as it was not glob-imported anywhere in the current crate, we
can trim its printed path and print only the name.
This has wide implications on error messages with types, for example,
shortening `std::vec::Vec` to just `Vec`, as long as there is no other
`Vec` importable anywhere.
This adds a new '-Z trim-diagnostic-paths=false' option to control this
feature.
On the good path, with no diagnosis printed, we should try to avoid
issuing this query, so we need to prevent trimmed_def_paths query on
several cases.
This change also relies on a previous commit that differentiates
between `Debug` and `Display` on various rustc types, where the latter
is trimmed and presented to the user and the former is not.
2020-09-02 22:26:37 +03:00
Kornel
7ec1de062a
Clarify message about unresolved use
2020-09-01 18:38:14 +01:00
Esteban Küber
0afb9c28bb
Tweak output of E0225
...
When encountering multiple non-auto trait bounds suggest creating a new
trait and explain what auto-traits are.
2020-08-14 12:08:49 -07:00
mark
2c31b45ae8
mv std libs to library/
2020-07-27 19:51:13 -05:00
Esteban Küber
c38b127d84
Remove redundant explanatory note for type parameters
2020-07-14 12:19:44 -07:00
Esteban Küber
b7db6bb5af
Remove Sized on_unimplemented note
2020-07-14 10:50:24 -07:00
RoccoDev
b85c64c3ea
rustc: Add a warning count upon completion
2020-04-11 16:15:24 +02:00
Esteban Küber
bd7ea5441e
Use PredicateObligations instead of Predicates
...
Keep more information about trait binding failures.
2020-04-08 14:40:45 -07:00
Esteban Küber
2c71894657
Tweak suggest_constraining_type_param
...
Some of the bound restriction structured suggestions were incorrect
while others had subpar output.
2020-03-29 13:13:17 -07:00
Patryk Wychowaniec
a8d34c1062
Improve reporting errors and suggestions for trait bounds
2020-02-09 10:33:47 +01:00
varkor
24a2929ed1
Normalise notes with the/is
2020-01-24 16:24:50 +00:00
varkor
0c2cf07d6e
Add backticks to various diagnostics
2020-01-05 00:17:46 +00:00
varkor
9a602243c4
Add new folder for destructuring assignment tests
2019-12-23 11:20:13 +00:00
varkor
35979a92bf
Add span information to ExprKind::Assign
2019-12-23 11:20:13 +00:00
varkor
5ab4735559
Recognise nested tuples/arrays/structs
2019-12-23 11:17:55 +00:00
varkor
5fa02ecc29
Add note about destructuring assignments
2019-12-23 11:17:55 +00:00
varkor
b7bfdbe681
Improve invalid assignment error
2019-12-23 11:16:51 +00:00
Mazdak Farrokhzad
b4420c8f5c
rework run-fail and support check,build-fail
2019-12-21 22:16:00 +01:00
Esteban Küber
94c6425464
Remove E0308 note when primary label has all info
2019-11-18 11:03:03 -08:00
Esteban Küber
83ffda5216
Specific labels when referring to "expected" and "found" types
2019-11-18 11:02:22 -08:00
Guillaume Gomez
cfd4e9722e
Fix ui tests with better error code usage
2019-11-14 13:05:56 +01:00
Esteban Küber
0baf61bfdb
Increase spacing for suggestions in diagnostics
...
Make the spacing between the code snippet and verbose structured
suggestions consistent with note and help messages.
2019-10-24 12:26:01 -07:00
Esteban Küber
190589f8a7
Use structured suggestion for restricting bounds
...
When a trait bound is not met and restricting a type parameter would
make the restriction hold, use a structured suggestion pointing at an
appropriate place (type param in param list or `where` clause).
Account for opaque parameters where instead of suggesting extending
the `where` clause, we suggest appending the new restriction:
`fn foo(impl Trait + UnmetTrait)`.
2019-10-15 13:55:43 -07:00
Samy Kacimi
19a848d2ea
normalize use of backticks in compiler messages for librustc_metadata
...
https://github.com/rust-lang/rust/issues/60532
2019-07-19 22:24:56 +02:00
Samy Kacimi
e5e1397adb
normalize use of backticks in compiler messages for librustc/lint
...
https://github.com/rust-lang/rust/issues/60532
2019-07-17 22:49:48 +02:00
Vadim Petrochenkov
932ea64175
compiletest: Remove skip-codegen
2019-06-16 12:23:22 +03:00
memoryruins
eb4580a570
Update ui test suite to use dyn
2019-05-29 00:57:31 -04:00
Alexander Regueiro
783b713b5d
Addressed more points raised in review.
2019-05-20 16:12:49 +01:00
Alexander Regueiro
fd7c253acc
Update tests.
2019-05-20 16:12:49 +01:00
varkor
7f0f0e31ec
Remove double trailing newlines
2019-04-22 16:57:01 +01:00
Andy Russell
b6f148c8bd
hide --explain hint if error has no extended info
2019-04-18 13:29:28 -04:00
Eduard-Mihai Burtescu
5f7055988b
Resolve inconsistency in error messages between "parameter" and "variable".
2019-04-17 13:25:07 +03:00
Esteban Küber
e1be8b0318
Swap primary/secondary spans for E0458
2019-03-23 13:05:30 -07:00
Eduard-Mihai Burtescu
3e1cef7007
rustc: pass Option<&Substs> and Namespace around in ty::item_path.
2019-03-15 13:25:10 +02:00
Vadim Petrochenkov
fa72a81bea
Update tests
2019-03-11 23:10:26 +03:00
Esteban Küber
87dd2e1df9
Use hidden suggestions for unused imports lint
2019-02-11 11:16:22 -08:00
bors
57d7cfc3cf
Auto merge of #56645 - pietroalbini:fix-unused-imports, r=estebank
...
Initial implementation of rustfixable unused_imports lint
This PR adds the initial implementation of rustfixable `unused_imports` lint. The implementation works, but rustfix is not able to apply all the suggestions until https://github.com/rust-lang/rust/issues/53934 is fixed. It also needs https://github.com/rust-lang/rust/pull/58296 to hide the suggested note since it's really useless.
cc https://github.com/rust-lang/rust/issues/47888
<details><summary><code>cargo fix</code> in action on the <code>unused_imports</code> lint</summary>
</details>
2019-02-11 10:34:09 +00:00
Pietro Albini
5ef71508fe
unused_imports: update tests
2019-02-08 08:44:56 +01:00
varkor
4e0e188999
Make name resolution handle consts in GenericParamsFromOuterFunction properly
2019-02-07 15:03:20 +01:00
bors
0c91f3d97f
Auto merge of #57234 - Centril:const-stabilizations-2, r=oli-obk
...
Const-stabilize `const_int_ops` + `const_ip`
r? @oli-obk
## Note for relnotes: This PR includes https://github.com/rust-lang/rust/pull/57105 .
I've added T-lang since this affects intrinsics and the operational semantics of Rust's `const fn` fragment.
## Stable APIs proposed for constification
+ `const_int_ops`:
+ `count_ones`
+ `count_zeros`
+ `leading_zeros`
+ `trailing_zeros`
+ `swap_bytes`
+ `from_be`
+ `from_le`
+ `to_be`
+ `to_le`
+ `const_ip`
+ `Ipv4Addr::new`
## Unstable APIs constified
+ `const_int_conversion`:
+ `reverse_bits`
2019-01-12 02:00:18 +00:00
kennytm
aa5fc743b5
Rollup merge of #57249 - frewsxcv:frewsxcv-second-edition, r=KodrAus
...
Fix broken links to second edition TRPL.
Fixes https://github.com/rust-lang/rust/issues/57104 .
Remove `second-edition/` from TRPL hyperlinks.
2019-01-05 23:56:48 +08:00
