Peter Jaszkowiak
21eae8ceb6
fix indexing_slicing with const
...
- should not fire if indexing with a constant block
- should not fire if indexing within a constant context
(const statement or const block)
2022-03-25 23:05:38 -06:00
Alex Macleod
610db04222
Provide suggestion context in map_unit_fn
2022-03-25 20:47:54 +00:00
bors
b7b0dad656
Auto merge of #95273 - flip1995:clippyup, r=manishearth
...
Update Clippy
r? `@Manishearth`
2022-03-24 22:52:34 +00:00
flip1995
1fa3d66e62
Merge commit ' d0cf3481a8' into clippyup
2022-03-24 14:50:04 +01:00
flip1995
1147b2c481
Merge remote-tracking branch 'upstream/master' into rustup
2022-03-24 14:22:35 +01:00
Yoav Lavi
b60a7fb7b6
unnecessary_join lint
2022-03-24 13:18:18 +01:00
Oli Scherer
6fc3850847
update clippy stderr file
2022-03-24 11:27:07 +00:00
Samuel E. Moelius III
65a26692fd
Add crate_in_macro_def lint
2022-03-24 05:08:10 -04:00
bors
f07ee8a998
Auto merge of #8232 - Jarcho:match_same_arm_860, r=xFrednet
...
`match_same_arms` fix
fixes #860
fixes #1140
changelog: Don't lint `match_same_arms` when an interposing arm's pattern would overlap
2022-03-21 20:42:51 +00:00
bors
4a07662d94
Auto merge of #8561 - FoseFx:use_unwrap_or, r=xFrednet
...
add `or_then_unwrap`
Closes #8557
changelog: New lint [`or_then_unwrap`]
2022-03-21 20:08:29 +00:00
J-ZhengLi
5b6295d663
allowing [map_flatten] to split long suggestions
...
add new function `span_lint_and_sugg_` for edges in `clippy_utils::diagnostics`
2022-03-21 14:11:22 +08:00
Max Baumann
0f83753934
feat: change error message
2022-03-20 23:43:17 +01:00
Max Baumann
20c352a4f6
test: add method chain test
2022-03-19 18:17:43 +01:00
Max Baumann
895de1f13e
feat: make fixable
2022-03-18 23:18:36 +01:00
Max Baumann
f00e844a1f
feat: use span_lint_and_sugg
2022-03-18 22:44:56 +01:00
bors
a31dcb77be
Auto merge of #8562 - Jarcho:enum_tuple_variant_as_int, r=Manishearth
...
Add lint `cast_enum_constructor`
fixes : #1116
changelog: Add lint `cast_enum_constructor`
2022-03-18 15:54:45 +00:00
Max Baumann
fd2c860171
feat: add comment
2022-03-18 14:45:48 +01:00
bors
9fd3c2d788
Auto merge of #8543 - dswij:8393, r=giraffate
...
`unnecessary_lazy_eval` show suggestions on multiline lint
Closes #8393
changelog: [`unnecessary_lazy_eval`] now shows suggestions for long-line lints
2022-03-18 00:42:18 +00:00
Max Baumann
05e05eaed7
refactor: rename lint to or_then_unwrap
2022-03-18 01:04:33 +01:00
Jason Newcomb
39329d1d40
Add lint cast_enum_constructor
2022-03-17 19:57:35 -04:00
Max Baumann
44c62c9aa2
feat: add tests and fix existing ones
2022-03-18 00:51:26 +01:00
Max Baumann
3f00f074de
fix: fix tests
2022-03-17 19:13:44 +01:00
Max Baumann
f49a2c3457
feat: add use_unwrap_or
2022-03-17 18:57:28 +01:00
bors
8d5c0eadde
Auto merge of #8552 - Jarcho:ptr_arg_8495, r=xFrednet
...
Don't lint `ptr_arg` on `&mut Cow<_>`
fixes : #8495
changelog: Don't lint `ptr_arg` on `&mut Cow<_>`
2022-03-17 17:05:26 +00:00
J-ZhengLi
4b128624ed
fix #8551 , add test cases, and some code improvement
2022-03-17 23:06:31 +08:00
Jason Newcomb
773d20341a
Fix mixed enum variant kinds + code cleanup
2022-03-17 01:09:25 -04:00
Jason Newcomb
08a7157a37
Improve message for match_single_arms
2022-03-16 13:58:09 -04:00
Jason Newcomb
b37317b028
Check if there are any overlapping patterns between equal arm bodies in match_same_arm
2022-03-16 13:18:29 -04:00
Jason Newcomb
8e5208cbff
Don't lint transmute_undefined_repr when changing the type of generic params
2022-03-16 12:56:23 -04:00
Jason Newcomb
851e715e5a
Don't lint ptr_arg on &mut Cow<_>
2022-03-16 12:00:27 -04:00
codehorseman
4beda1be70
resolve the conflict in compiler/rustc_session/src/parse.rs
...
Signed-off-by: codehorseman <cricis@yeah.net>
2022-03-16 20:12:30 +08:00
J-ZhengLi
2909b33a24
quick fix of issue#8542 for lint [needless_match]
...
remove `ref`/`ref mut` check
2022-03-16 16:26:56 +08:00
Jason Newcomb
47c9ed697b
Fix checking transmutes with adjusted types
2022-03-15 23:11:11 -04:00
Jason Newcomb
911e10562a
Don't lint transmute_undefined_repr on unions.
2022-03-15 22:38:15 -04:00
Jason Newcomb
442d4ce1c3
Don't lint fat pointer to (usize, usize) conversion in transmute_undefined_repr
2022-03-15 22:31:07 -04:00
Jason Newcomb
e71ac41d44
Fix transmute_undefined_repr for single element tuples
2022-03-15 21:51:07 -04:00
Jason Newcomb
30b333645d
Don't lint undocumented_unsafe_blocks on bad proc-macro spans.
2022-03-15 16:52:28 -04:00
Jason Newcomb
65f96e2b53
Rework undocumented_unsafe_blocks
2022-03-15 14:18:05 -04:00
dswij
6a3dbe4798
unnecessary_lazy_eval show suggestions on multiline lint
2022-03-15 23:59:26 +08:00
bors
71ecbc42f9
Auto merge of #8509 - smoelius:fix-8507, r=giraffate
...
Fix `unncessary_to_owned` false positive
Fix #8507
changelog: none
2022-03-15 01:08:47 +00:00
xFrednet
2ee5372389
Allow single_component_path_imports for all macros
2022-03-14 22:45:00 +01:00
flip1995
d1b087fdee
Merge commit ' dc5423ad44' into clippyup
2022-03-14 12:02:53 +01:00
flip1995
d5ab347d5c
Merge remote-tracking branch 'upstream/master' into rustup
2022-03-14 11:29:18 +01:00
bors
e2e492c10e
Auto merge of #8422 - buttercrab:only_used_in_recursion, r=llogiq
...
new lint: `only_used_in_recursion`
changed:
- added `only_used_in_recursion`.
- fixed code that variables are only used in recursion.
- this would not lint when `unused_variable`
This fixes : #8390
-----
changelog: add lint [`only_used_in_recursion`]
2022-03-13 16:11:25 +00:00
bors
75b616e92f
Auto merge of #8471 - J-ZhengLi:master-issue7040, r=llogiq
...
new lint that detects useless match expression
fixes #7040
changelog: Add new lint [`needless_match`] under complexity lint group
2022-03-13 14:49:56 +00:00
Tianyi Song
a944ccb677
Check if lhs < rhs in modulos and emit
2022-03-11 16:02:49 +08:00
J-ZhengLi
086b045822
add checking for x -> x and ref x -> x and related test cases.
2022-03-10 14:46:58 +08:00
Jaeyong Sung
69161c6327
fix to lint Self::function
2022-03-10 15:46:40 +09:00
J-ZhengLi
ec9116412a
rename lint to needless_match
...
and change its lint group to "complexity"
2022-03-10 09:44:25 +08:00
J-ZhengLi
750204e3e3
fix a bug that caused internal test fail
2022-03-08 18:15:11 +08:00
