Caio
4262aebeaa
[arithmetic-side-effects] Consider negative numbers and add more tests
2023-01-06 12:25:51 -03:00
Samuel Moelius
26df55112f
Fix adjacent code
2022-12-20 05:12:13 -05:00
bors
5a3a722c05
Auto merge of #10004 - Jarcho:issue_9904, r=llogiq
...
Don't suggest keeping borrows in `identity_op`
fixes #9904
changelog: `identity_op`: Don't suggest keeping borrows
2022-12-09 11:53:14 +00:00
Caio
1f92f97e5a
[arithmetic-side-effects]: Consider user-provided pairs
2022-12-08 17:41:49 -03:00
Jason Newcomb
03ba0ea400
Don't suggest keeping borrows in identity_op
2022-11-30 16:25:57 -05:00
Philipp Krones
fd5b85c957
Merge remote-tracking branch 'upstream/master' into rustup
2022-11-21 20:01:17 +01:00
Caio
e0b1463e0a
Remove unused
2022-11-19 08:25:20 -03:00
Caio
98b343c5e6
[arithmetic-side-effects] Detect overflowing associated constants of integers
2022-11-19 08:22:27 -03:00
Cameron Steffen
16566e97fd
Use LanguageItems::require less
2022-10-29 16:04:10 -05:00
Nicholas Nethercote
efca32e23a
Rename some OwnerId fields.
...
spastorino noticed some silly expressions like `item_id.def_id.def_id`.
This commit renames several `def_id: OwnerId` fields as `owner_id`, so
those expressions become `item_id.owner_id.def_id`.
`item_id.owner_id.local_def_id` would be even clearer, but the use of
`def_id` for values of type `LocalDefId` is *very* widespread, so I left
that alone.
2022-10-29 20:28:38 +11:00
Samuel Moelius
10b7fabbf3
Fix adjacent code
2022-10-28 13:18:07 -04:00
flip1995
cd0bb7de01
Merge commit ' 4f142aa105' into clippyup
2022-10-23 15:18:45 +02:00
lcnr
059e52b96b
rustc_hir_typeck: fix clippy
2022-10-20 17:53:14 +02:00
Philipp Krones
fb8ecb9832
Merge remote-tracking branch 'upstream/master' into rustup
2022-10-20 16:39:27 +02:00
Samuel Moelius
2e5e3560e9
Fix adjacent code
2022-10-15 07:03:29 -04:00
Cameron Steffen
6819e85501
Change InferCtxtBuilder from enter to build
2022-10-07 07:10:40 -05:00
Philipp Krones
d75b25faab
Merge commit ' ac0e10aa68' into clippyup
2022-10-06 09:44:38 +02:00
Caio
a44914fcd3
Dogfood
2022-10-03 20:10:00 -03:00
Caio
2a6a98f95b
[arithmetic-side-effects] Do not ignore literal references
2022-10-03 19:49:03 -03:00
bors
e8c1b5478c
Auto merge of #9559 - c410-f3r:arith, r=Alexendoo
...
Fix #9544
Fix #9544
r? `@Alexendoo`
changelog: [`arithmetic_side_effects`]: Fix false negative for `CustomType / usize`, `CustomType * float` and similar
2022-10-03 21:54:08 +00:00
Caio
99363fef65
Address comments
2022-10-03 18:36:12 -03:00
Jason Newcomb
38236a7135
Use for_each_expr in place of some visitors
2022-10-02 17:15:19 -04:00
Andre Bogus
eef5d477b5
use is_integer_literal more
2022-10-01 17:55:22 +02:00
Caio
4876882b29
Fix #9544
2022-09-30 15:30:40 -03:00
Philipp Krones
bbcde66685
Merge remote-tracking branch 'upstream/master' into rustup
2022-09-28 14:27:32 +02:00
bors
257fb4b458
Auto merge of #9543 - philipcraig:fix-saturing-typo, r=giraffate
...
fix typo "Saturing" -> "Saturating"
---
*Please write a short comment explaining your change (or "none" for internal only changes)*
changelog: fix typo "Saturing" -> "Saturating"
2022-09-27 14:38:12 +00:00
bors
d31db02e47
Auto merge of #9507 - c410-f3r:arith, r=Alexendoo
...
[arithmetic-side-effects] Consider references
Takes into consideration integer references like `&i32::MAX` because currently things like `let _ = &1 + 0` trigger the lint.
changelog: FP: [`arithmetic_side_effects`]: Now ignores references
[9507](https://github.com/rust-lang/rust-clippy/pull/9507 )
2022-09-27 14:09:25 +00:00
lcnr
e5ce6d18df
rustc_typeck to rustc_hir_analysis
2022-09-27 10:37:23 +02:00
Philip Craig
14abb8395c
fix typo "Saturing" -> "Saturating"
2022-09-27 09:32:55 +01:00
Takayuki Maeda
ea75178219
separate definitions and HIR owners
...
fix a ui test
use `into`
fix clippy ui test
fix a run-make-fulldeps test
implement `IntoQueryParam<DefId>` for `OwnerId`
use `OwnerId` for more queries
change the type of `ParentOwnerIterator::Item` to `(OwnerId, OwnerNode)`
2022-09-24 23:21:19 +09:00
Yuri Astrakhan
e67b2bf732
Apply uninlined_format-args to clippy_lints
...
This change is needed for the uninlined_format-args lint to be merged.
See https://github.com/rust-lang/rust-clippy/pull/9233
2022-09-23 13:42:59 -04:00
Caio
4c5f23082a
[arithmetic-side-effects] Consider references
2022-09-21 15:02:37 -03:00
David Koloski
4d015293d1
Merge commit ' 7248d06384' into sync-from-clippy
2022-09-21 13:13:27 -04:00
Caio
b7bef4c8a4
Change method's name
2022-09-16 17:01:29 -03:00
Caio
8bfe3db531
Typo
2022-09-15 13:40:49 -03:00
Caio
dba5adae6e
[arithmetic-side-effects] Finish non-overflowing ops
2022-09-15 13:28:18 -03:00
Caio
611c905482
[arithmetic-side-effects] More non-overflowing ops
2022-09-13 15:50:24 -03:00
Philipp Krones
98bf99e2f8
Merge commit ' b52fb5234c' into clippyup
2022-09-09 13:36:26 +02:00
Philipp Krones
4ee55c5528
Merge remote-tracking branch 'upstream/auto' into rustup
2022-09-08 21:27:09 +02:00
Caio
51d8b6c664
Rename the arithmetic lint
2022-09-08 12:04:55 -03:00
Caio
0d078c9fd6
[Arithmetic] Consider literals
2022-09-07 10:00:45 -03:00
bors
2ccf843471
Auto merge of #101261 - TaKO8Ki:separate-receiver-from-arguments-in-hir, r=cjgillot
...
Separate the receiver from arguments in HIR
Related to #100232
cc `@cjgillot`
2022-09-05 16:21:40 +00:00
Takayuki Maeda
4bcaddeeb2
separate the receiver from arguments in HIR under /clippy
2022-09-05 22:25:57 +09:00
Nicholas Nethercote
25f6f18834
Make hir::PathSegment::res non-optional.
2022-09-05 14:20:25 +10:00
Philipp Krones
67c405cc1d
Merge commit ' 3c7e7dbc15' into clippyup
2022-07-28 19:08:22 +02:00
Serial
51cd5a8667
Add --type flag to dev new_lint
2022-07-25 22:35:28 -04:00
bors
8882578a67
Auto merge of #9130 - c410-f3r:arith, r=llogiq
...
Add `Arithmetic` lint
Fixes https://github.com/rust-lang/rust-clippy/issues/8903
r? `@llogiq`
changelog: Add `Arithmetic` lint
2022-07-25 21:26:15 +00:00
Jason Newcomb
a2f9b93116
Don't lint assign_op_pattern when the suggestion would cause borrowck errors
2022-07-20 10:23:07 -04:00
Caio
31e5465f8a
Add Arithmetic lint
2022-07-18 14:29:45 -03:00
Camille GILLOT
d5e33d3ded
Shorten def_span for more items.
2022-07-01 17:39:19 +02:00
