user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
90285 commits 10 branches 154 tags 1.3 GiB
Commit graph

201 commits

Author SHA1 Message Date
Dan Robertson
285d4a7eb6
suggestion-diagnostics: as_ref improve snippet 
Improve the code snippet suggested in suggestion-diagnostics when
suggesting the use of as_ref.
 2019-02-13 17:52:22 +00:00
varkor
455d659e91 Update tests 
Co-Authored-By: Gabriel Smith <yodaldevoid@users.noreply.github.com>
 2019-02-07 15:02:17 +01:00
Andy Russell
5e67021172
add typo suggestion to unknown attribute error 2019-01-27 21:56:50 -05:00
David Wood
7a0abbff8b
Combining move lifetime and type suggestions. 
This commit combines the move lifetime and move type suggestions so that
when rustfix applies them they don't conflict with each other.
 2019-01-25 11:54:21 +01:00
David Wood
463e623ca9
Suggestion moving types before associated types. 
This commit extends existing suggestions to move lifetimes before types
in generic arguments to also suggest moving types behind associated type
bindings.
 2019-01-25 11:15:16 +01:00
Mazdak Farrokhzad
da182a0fe7
Rollup merge of #57795 - estebank:did-you-mean, r=zackmdavis 
Use structured suggestion in stead of notes
 2019-01-24 00:19:55 +01:00
Mazdak Farrokhzad
2dd63a2e10
Rollup merge of #57779 - estebank:recover-struct-fields, r=davidtwco 
Recover from parse errors in literal struct fields and incorrect float literals

Fix #52496.
 2019-01-24 00:19:53 +01:00
Esteban Küber
45a95b512c Use structured suggestion in stead of notes 2019-01-20 21:41:25 -08:00
Esteban Küber
15bad8bbfd Extend incorrect float literal recovery to account for suffixes 2019-01-20 14:25:53 -08:00
Esteban Küber
b36bf76dec Suggest correct cast for struct fields with shorthand syntax 2019-01-19 20:18:56 -08:00
Dan Robertson
e3ba6ed3f5
Fix suggestions given mulitple bad lifetimes 
When given multiple lifetimes prior to type parameters in generic
parameters, do not ICE and print the correct suggestion.
 2019-01-18 01:10:14 +00:00
Esteban Küber
3874c7755f Recover from item trailing semicolon 2019-01-13 17:29:32 -08:00
Corey Farwell
d2c91a1a6d Fix broken links to second edition TRPL. 
Fixes https://github.com/rust-lang/rust/issues/57104.
 2019-01-01 12:53:07 -05:00
bors
9eac386342 Auto merge of #57047 - euclio:field-structured-suggestions, r=estebank 
use structured suggestions for nonexistent fields

r? @estebank
 2018-12-31 20:56:19 +00:00
Andy Russell
dfc326d0e2
use structured suggestions for nonexistent fields 2018-12-31 12:52:30 -05:00
Esteban Küber
8da6727e96 Suggest .as_ref() when appropriate for Option and Result 2018-12-28 11:16:23 -08:00
Mark Rousskov
2a663555dd Remove licenses 2018-12-25 21:08:33 -07:00
Mazdak Farrokhzad
c52a13dcdf
Rollup merge of #56761 - estebank:path-display, r=zackmdavis 
Suggest using `.display()` when trying to print a `Path`

Fix #38997.
 2018-12-16 14:08:25 +01:00
Esteban Küber
33a34b06ac Wording changes 2018-12-13 09:55:16 -08:00
Esteban Küber
c7f1b977ed Suggest using .display() when trying to print a Path 2018-12-12 16:54:27 -08:00
Esteban Küber
b9235ea57c Account for impl Trait when suggesting lifetime 2018-12-12 14:10:36 -08:00
Oliver Scherer
690439bb45 Update ui tests 2018-12-04 10:06:05 +01:00
Oliver Scherer
61efc3b71b Update tests 2018-12-04 10:06:05 +01:00
Guillaume Gomez
796892e0ef
Rollup merge of #56220 - estebank:suggest-lifetime-move, r=nikomatsakis 
Suggest appropriate place for lifetime when declared after type arguments
 2018-11-29 13:10:39 +01:00
Esteban Küber
45dfe43887 Emit one diagnostic for multiple misplaced lifetimes 2018-11-26 08:32:47 -08:00
Esteban Küber
234d043d18 Move lifetimes before the *first* type argument 2018-11-25 12:51:04 -08:00
Esteban Küber
79ee8f329d Suggest appropriate place for lifetime when declared after type arguments 2018-11-25 12:41:38 -08:00
Esteban Küber
6b338e034a Suggest correct enum variant on typo 2018-11-24 16:25:13 -08:00
Esteban Küber
a5d35631fe Reword and fix test 2018-11-22 14:14:27 -08:00
Esteban Küber
48fa974211 Suggest correct syntax when writing type arg instead of assoc type 
When confusing an associated type with a type argument, suggest the
appropriate syntax.

Given `Iterator<isize>`, suggest `Iterator<Item = isize>`.
 2018-11-22 14:14:27 -08:00
Zack M. Davis
f3e9b1a703 in which the E0618 "expected function" diagnostic gets a makeover 
Now the main span focuses on the erroneous not-a-function callee,
while showing the entire call expression is relegated to a secondary
span. In the case where the erroneous callee is itself a call, we
point out the definition, and, if the call expression spans multiple
lines, tentatively suggest a semicolon (because we suspect that the
"outer" call is actually supposed to be a tuple).

The new `bug!` assertion is, in fact, safe (`confirm_builtin_call` is
only called by `check_call`, which is only called with a first arg of
kind `ExprKind::Call` in `check_expr_kind`).

Resolves #51055.
 2018-11-10 22:12:33 -08:00
bors
45088b11f5 Auto merge of #54979 - estebank:path-unsized, r=nikomatsakis 
Custom E0277 diagnostic for `Path`

r? @nikomatsakis we have a way to target `Path` exclusively, we need to identify the correct text to show to consider #23286 fixed.
 2018-10-18 21:42:21 +00:00
Esteban Küber
ed10a3faae Custom E0277 diagnostic for Path 2018-10-10 17:30:10 -07:00
Esteban Küber
5b0223e8c6 Reword rustc_on_unimplemented errors for Iterator 
- Detect one element array of `Range` type, which is potentially a typo:
   `for _ in [0..10] {}` where iterating between `0` and `10` was intended.
   (#23141)
 - Suggest `.bytes()` and `.chars()` for `String`.
 - Suggest borrowing or `.iter()` on arrays (#36391)
 - Suggest using range literal when iterating on integers (#34353)
 - Do not suggest `.iter()` by default (#50773, #46806)
 2018-10-09 18:53:53 -07:00
ashtneoi
0023dd9ba1 Split tests more and bless them again 2018-08-15 22:36:19 -07:00
ashtneoi
f335fb08c2 Move tests into their own directory 2018-08-15 22:35:56 -07:00
ashtneoi
f4229b81b5 Re-bless test 2018-08-15 15:25:53 -07:00
ashtneoi
a5b008c450 Test move-into-Fn/FnMut errors too 2018-08-15 15:14:21 -07:00
ashtneoi
81c27c6af7 Add another FIXME about suggestions 2018-08-15 15:14:21 -07:00
ashtneoi
9a0020a879 Bless UI tests 2018-08-15 15:14:21 -07:00
ashtneoi
0a82abc47b Test patterns in tuples 2018-08-15 15:14:21 -07:00
ashtneoi
6cf4e14ac0 Coalesce var-is-not-Copy notes per move 2018-08-15 15:14:21 -07:00
ashtneoi
20ae08bda6 Dedup suggestions 2018-08-15 15:14:21 -07:00
ashtneoi
40b5118c8a Remove unnecessary underscore 2018-08-15 15:14:21 -07:00
ashtneoi
8135372ed1 Change TODOs to FIXMEs 2018-08-15 15:14:21 -07:00
ashtneoi
10aaba8dbe Make move errors more consistent with typeck errors 2018-08-15 15:14:21 -07:00
ashtneoi
701c74e067 Make move error suggestions clearer 2018-08-15 15:14:21 -07:00
ashtneoi
b05e9a7f77 Add backquotes around variable name 2018-08-15 15:14:21 -07:00
ashtneoi
8080bdf275 Fix move errors for index expressions 
The suggestion logic gave up too early, which kept it from suggesting
borrowing index expressions.
 2018-08-15 15:14:21 -07:00
ashtneoi
54ddb36ce7 Test move errors for index expressions 2018-08-15 15:14:21 -07:00