Matthias Krüger
7fbd30b1ae
don't clone types that are copy
...
found via clippy
2020-01-16 23:48:49 +01:00
Dylan DPC
1389caf860
Rollup merge of #68096 - varkor:diagnostic-cleanup, r=Centril
...
Clean up some diagnostics by making them more consistent
In general:
- Diagnostic should start with a lowercase letter.
- Diagnostics should not end with a full stop.
- Ellipses contain three dots.
- Backticks should encode Rust code.
I also reworded a couple of messages to make them read more clearly.
It might be sensible to create a style guide for diagnostics, so these informal conventions are written down somewhere, after which we could audit the existing diagnostics.
r? @Centril
2020-01-16 11:58:02 +05:30
Dylan DPC
9de54fadae
Rollup merge of #68237 - estebank:bad-bad-ice, r=petrochenkov
...
Account for `Path`s in `is_suggestable_infer_ty`
Fix #68162 .
2020-01-15 22:49:30 +05:30
Dylan DPC
ae1e75bf4e
Rollup merge of #68212 - csmoe:temp, r=estebank
...
Suggest to shorten temporary lifetime during method call inside generator
Closes https://github.com/rust-lang/rust/issues/67376

r? @estebank
cc @tmandry @nikomatsakis
2020-01-15 22:49:26 +05:30
csmoe
4eb47ded54
wrap expr id into GeneratorInteriorTypeCause
2020-01-15 15:13:51 +08:00
Esteban Küber
268a1ff3fb
Account for Paths on is_suggestable_infer_ty
...
Fix #68162 .
2020-01-14 16:18:21 -08:00
csmoe
5ad8b9e394
update async-await send/sync test
2020-01-15 00:45:08 +08:00
Ben Lewis
02fffc1556
Code review changes and fix rustdoc test.
2020-01-14 07:47:45 +13:00
Ben Lewis
a6c4025fac
perf: eagerly convert literals to consts, this avoids creating loads on unevaluated consts
...
which requires a lot of unnecessary work to evaluate them further down the line.
2020-01-14 07:47:45 +13:00
varkor
e84248921b
Add backticks in appropriate places
2020-01-12 15:37:50 +00:00
varkor
8461fa5119
Diagnostics should not end with a full stop
2020-01-12 15:37:50 +00:00
varkor
0810210bcb
Diagnostics should start lowercase
2020-01-12 15:36:40 +00:00
bors
1389494ac1
Auto merge of #67000 - spastorino:remove-promoted-from-place, r=oli-obk
...
Promote references to constants instead of statics
r? @oli-obk
2020-01-11 14:46:17 +00:00
Mazdak Farrokhzad
cacda2d7a0
Rollup merge of #68084 - estebank:ice-68000, r=varkor
...
Do not ICE on unicode next point
Use `shrink_to_hi` instead of `next_point` and fix `next_point`.
Fix #68000 , fix #68091 , fix #68092 .
2020-01-11 04:02:28 +01:00
Mazdak Farrokhzad
1af8c10bd4
simplify feature_err imports
2020-01-11 03:19:50 +01:00
Yuki Okushi
7ae0618e0a
Rollup merge of #68050 - Centril:canon-error, r=Mark-Simulacrum
...
Canonicalize rustc_error imports
r? @Mark-Simulacrum
2020-01-11 04:50:53 +09:00
Yuki Okushi
a491100aa3
Rollup merge of #68014 - estebank:unify-e0599, r=cramertj
...
Unify output of "variant not found" errors
Fix #49566 .
2020-01-11 04:50:48 +09:00
Esteban Küber
b93ef68245
Change next_point when shrink_to_hi is more appropriate
2020-01-10 11:23:59 -08:00
Santiago Pastorino
1688719214
Promote Refs to constants instead of static
2020-01-10 09:08:24 +01:00
Mazdak Farrokhzad
8bd3d240e3
nix syntax::errors & prefer rustc_errors over errors
2020-01-10 07:41:30 +01:00
Mazdak Farrokhzad
d5598aa7a0
Introduce #![feature(half_open_range_patterns)].
...
This feature adds `X..`, `..X`, and `..=X` patterns.
2020-01-10 07:29:04 +01:00
Mazdak Farrokhzad
2307f0c4ea
Rollup merge of #68071 - estebank:ice-67995, r=Centril
...
Extend support of `_` in type parameters
- Account for `impl Trait<_>`.
- Provide a reasonable `Span` for empty `Generics` in `impl`s.
- Account for `fn foo<_>(_: _) {}` to suggest `fn foo<T>(_: T) {}`.
- Fix #67995 . Follow up to #67597 .
2020-01-10 02:47:34 +01:00
Mazdak Farrokhzad
3bfa28c3a8
Rollup merge of #67922 - Centril:lowering-cleanup, r=petrochenkov
...
rustc_ast_lowering: misc cleanup & rustc dep reductions
- The first two commits do some code simplification.
- The next three do some file splitting (getting `lib.rs` below the 3kloc tidy lint).
- The remaining commits reduce the number of `rustc::` imports. This works towards making lowering independent of the `rustc` crate.
r? @oli-obk cc @Zoxc
2020-01-10 02:47:33 +01:00
Mazdak Farrokhzad
aabb03763d
Rollup merge of #66463 - estebank:point-at-closure-and-opaque-types, r=Centril
...
Point at opaque and closure type definitions in type errors
Fixes #57266 , fixes #67117 .
2020-01-10 02:47:29 +01:00
Esteban Küber
c751961d29
Extend support of _ in type parameters
...
- Account for `impl Trait<_>`.
- Provide a reasonable `Span` for empty `Generics` in `impl`s.
- Account for `fn foo<_>(_: _) {}` to suggest `fn foo<T>(_: T) {}`.
- Fix #67995 .
2020-01-09 14:20:53 -08:00
Yuki Okushi
a366aa6249
Rollup merge of #68040 - sinkuu:unused, r=petrochenkov
...
Cleanup
2020-01-10 04:18:42 +09:00
Mazdak Farrokhzad
69b1e5cc3d
{rustc::util -> rustc_data_structures}::captures
2020-01-09 08:57:24 +01:00
John Kåre Alsaker
5427601e9e
Change -Z time event naming scheme and make them generic activities
2020-01-09 07:06:40 +01:00
Shotaro Yamada
dbcce10bb1
Remove unused struct ClosureUpvar
2020-01-09 11:47:32 +09:00
Mazdak Farrokhzad
d2922e51a7
Rollup merge of #68023 - FSciammarella:master, r=Centril,varkor
...
Fix issue #68008
Correcting Typo on error message. From "substract" to "subtract".
Fixes #68008 .
2020-01-09 00:22:18 +01:00
Felipe Sciammarella
7de174b86e
Fix Typo on cannot "substract"
...
Fix Typo on hir::BinOpKind::Sub
"substract" to "subtract"
Fix Typo on "Error cannot substract"
Fix Typo on cannot "substract"
2020-01-08 19:25:38 -03:00
Mazdak Farrokhzad
0997388b87
normalize rustc::hir::intravisit imports
2020-01-08 22:09:42 +01:00
Mazdak Farrokhzad
8351667091
intravisit: abstract over HIR Map
2020-01-08 22:01:07 +01:00
Esteban Küber
9c0000caca
Point at opaque and closure type definitions in type errors
2020-01-08 09:29:47 -08:00
Esteban Küber
2c5766f2d4
Unify output of "variant not found" errors
2020-01-08 08:05:31 -08:00
Mazdak Farrokhzad
2c3e5d3de0
- remove syntax::{span_warn!, span_err!, span_fatal!. struct_err!}
...
- remove syntax::{help!, span_help!, span_note!}
- remove unused syntax::{struct_span_fatal, struct_span_err_or_warn!, span_err_or_warn!}
- lintify check_for_bindings_named_same_as_variants + conflicting_repr_hints
- inline syntax::{struct_span_warn!, diagnostic_used!}
- stringify_error_code! -> error_code! & use it more.
- find_plugin_registrar: de-fatalize an error
- de-fatalize metadata errors
- move type_error_struct! to rustc_typeck
- struct_span_err! -> rustc_errors
2020-01-08 04:25:33 +01:00
Camille GILLOT
700ac84eae
Rename traits::drop -> traits::misc.
2020-01-07 19:36:50 +01:00
Camille GILLOT
f629baf96c
Move magic traits queries to rustc::traits::drop.
2020-01-07 18:14:32 +01:00
Camille GILLOT
e905d5da93
Move structural_match to rustc::traits.
2020-01-07 18:07:08 +01:00
Camille GILLOT
73667af444
Move ty::wf to traits.
2020-01-07 18:03:53 +01:00
Camille GILLOT
787cd5493a
Make traits::util::* free functions.
2020-01-07 17:48:41 +01:00
Camille GILLOT
7770bce178
Make rustc::traits::object_safety::{astconv_object_safety_violations,is_vtable_safe_method,object_safety_violations} free functions.
2020-01-07 17:44:53 +01:00
Camille GILLOT
0b1521e6d3
Make rustc::traits::error_reporting::{recursive_type_with_infinite_size_error, report_object_safety_error} free functions.
2020-01-07 17:43:55 +01:00
bors
ebbb2bf37a
Auto merge of #67886 - Centril:rustc_hir_canon_imports, r=nagisa
...
Nix `rustc_hir` reexports in rustc::hir
r? @Zoxc cc @Mark-Simulacrum
2020-01-06 12:55:40 +00:00
Dylan DPC
c79034ed47
Rollup merge of #67906 - varkor:silence-toogeneric, r=nagisa
...
Silence `TooGeneric` error
This error may be produced during intermediate failed attempts at evaluation of a generic const, which may nevertheless succeed later.
Fixes https://github.com/rust-lang/rust/issues/66962 .
r? @eddyb
2020-01-06 12:00:20 +05:30
varkor
adb46fd0a4
Silence TooGeneric error
...
This error may be produced during intermediate failed attempts at evaluation of a generic const, which may nevertheless succeed later.
2020-01-05 23:00:47 +00:00
Dylan DPC
10a12c539a
Rollup merge of #67881 - varkor:scattering-of-backticks, r=Centril
...
Add backticks to various diagnostics
2020-01-05 22:44:33 +05:30
Mazdak Farrokhzad
ebfd8673a7
Remove rustc_hir reexports in rustc::hir.
2020-01-05 12:49:22 +01:00
Mazdak Farrokhzad
62ac10ffde
simplify reexports in rustc::hir
2020-01-05 12:47:11 +01:00
John Kåre Alsaker
5a485ce4a3
Use self profile infrastructure for -Z time and -Z time-passes
2020-01-05 02:57:14 +01:00