qjerome
93d08b7c77
fix: requested changed
2025-01-08 14:47:46 +01:00
qjerome
c59ecb3af4
fix: autogenerate files
2025-01-08 14:47:21 +01:00
qjerome
2be4ce099d
refactor: struct holding cargo cfgs settings
2025-01-08 11:20:08 +01:00
Lukas Wirth
16721e33dc
Merge pull request #18855 from Giga-Bowser/migrate-if-let
...
internal: Migrate `if let` replacement assists to `SyntaxEditor`
2025-01-08 08:59:42 +00:00
Laurențiu Nicola
cc07c98314
Fix test-fixture autopublishing
2025-01-08 10:19:46 +02:00
Chayim Refael Friedman
bce64358b7
Fix a bug with missing binding in MBE
...
We should immediately mark them as finished, on the first entry.
The funny (or sad) part was that this bug was pre-existing, but previously to #18327 , it was causing us to generate bindings non-stop, 65535 of them, until we get to the hardcoded repetition limit, and then throw it all away. And it was so Blazingly Fast that nobody noticed.
With #18327 however, this is still what happens, except that now instead of *merging* the fragments into the result, we write them on-demand. Meaning that when we hit the limit, we've already written all previous entries. This is a minor change, I thought for myself when I was writing this, and it's actually for the better, so who cares. Minor change? Not so fast. This caused us to emit 65535 repetitions, all of which the MBE infra needs to handle when calling other macros with the expansion, and convert to rowan tree etc., which resulted a *massive* hang.
The test (and also `analysis-stats`) used to crash with stack overflow on this macro, because we were dropping some crazily deep rowan tree. Now they work properly. Because I am lazy, and also because I could not find the exact conditions that causes a macro match but with a missing binding, I just copied all macros from tracing. Easy.
2025-01-07 23:04:53 +02:00
Laurențiu Nicola
e103ab1608
Merge from rust-lang/rust
2025-01-07 17:57:53 +02:00
Laurențiu Nicola
aa1ef0a432
Preparing for merge from rust-lang/rust
2025-01-07 17:57:18 +02:00
Lukas Wirth
8e4409cce3
Merge pull request #18870 from Veykril/push-vnpsptpolyol
...
Drop unnecessary tracing::warn
2025-01-07 13:55:28 +00:00
Lukas Wirth
21faec1fec
Merge pull request #18867 from Veykril/push-ntmxlropxkrr
...
internal: target-triple -> target-tuple + version fetching cleanup
2025-01-07 13:46:58 +00:00
Lukas Wirth
b039d3fc5c
Drop unnecessary tracing::warn
...
We already emit an error
2025-01-07 14:40:00 +01:00
Lukas Wirth
380439c5f3
Add some smoke tests to toolchain_info
2025-01-07 14:33:24 +01:00
Lukas Wirth
d28a0b8fcd
Align toolchain version fetching with other toolchain info querying
...
Fix --target flag argument order in rustc_cfg fetching
2025-01-07 14:30:46 +01:00
Lukas Wirth
05770f2599
target-triple -> target-tuple
2025-01-07 14:25:43 +01:00
Lukas Wirth
c360bf5517
Merge pull request #18788 from Veykril/push-zxystwnotuvq
...
Remove `rust-analyzer.cargo.sysrootQueryMetadata` config again
2025-01-07 13:14:29 +00:00
Lukas Wirth
764ce49445
Remove rust-analyzer.cargo.sysrootQueryMetadata config again
2025-01-07 14:00:22 +01:00
Lukas Wirth
f9a3c4122c
Merge pull request #18864 from alexkirsz/alexkirsz/fix-diagnostics-clearing
...
fix: Fix diagnostics not clearing between flychecks
2025-01-07 12:16:18 +00:00
Chayim Refael Friedman
3f2f3e5180
Merge pull request #18832 from vishruth-thimmaiah/fix_string_comp
...
fix: do not offer completions within macro strings
2025-01-07 12:11:59 +00:00
Bogdan Mircea
9fb7c15339
project-model: fix JSON project PackageRoot buildfile inclusion
2025-01-07 13:47:17 +02:00
Vishruth-Thimmaiah
09a4ac5e8b
fix: do not offer completions within macro strings
2025-01-07 17:02:28 +05:30
Alex Kirszenberg
4d3e6feb2f
lint
2025-01-07 12:07:37 +01:00
Alex Kirszenberg
9294965217
fix: Fix diagnostics not clearing between flychecks
2025-01-07 11:11:04 +01:00
Laurențiu Nicola
4b387254be
Set test-utils dependency version, since it's now being published
2025-01-07 09:51:57 +02:00
Laurențiu Nicola
8db8e3cc37
Merge pull request #18853 from ChayimFriedman2/no-completion
...
Fix case where completion inside macro that expands to `#[test]` was unavailable
2025-01-07 06:44:50 +00:00
David Barsky
e02b3ec9cc
fix: clear diagnostics on cancel unconditionally, fixing #18854
2025-01-06 18:41:21 -05:00
Giga Bowser
aa36ac8867
internal: Migrate if let <=> match assists to SyntaxEditor
2025-01-06 15:58:39 -06:00
Giga Bowser
b2fa162071
internal: Migrate replace_let_with_if_let assist to SyntaxEditor
2025-01-06 15:58:39 -06:00
Giga Bowser
fa8acfac7e
internal: Add some pattern constructors to SyntaxFactory
2025-01-06 15:58:39 -06:00
Giga Bowser
396b56fd52
internal: Add some expr constructors to SyntaxFactory
2025-01-06 15:58:39 -06:00
Giga Bowser
cd803805b7
internal: Add some path constructors to SyntaxFactory
2025-01-06 15:58:39 -06:00
Giga Bowser
cce5f25f60
internal: make::expr_match should return ast::MatchExpr
2025-01-06 15:58:39 -06:00
Giga Bowser
0606db4373
internal: Generally improve make::match_arm
...
`make::match_arm` should take a single `ast::Pat`, and callers can handle creating an `ast::OrPat` if need be. It should also take a proper `ast::MatchGuard`, instead of making one itself.
2025-01-06 15:58:39 -06:00
Giga Bowser
652865037e
internal: move make::expr_unit to make::ext::expr_unit
...
`expr_unit` is just a shortcut for a common expression, so it belongs in `make::ext`
2025-01-06 15:58:39 -06:00
Giga Bowser
ef7bb04dec
internal: make::expr_tuple should return ast::TupleExpr
2025-01-06 15:32:08 -06:00
Giga Bowser
aacc2ebfc8
internal: make::expr_if should return ast::IfExpr
2025-01-06 15:32:08 -06:00
Giga Bowser
8435e3f945
internal: make::expr_prefix should return ast::PrefixExpr
2025-01-06 15:32:08 -06:00
Giga Bowser
bdb72bd405
internal: Generalize make::expr_from_text to types which implement Into<ast::Expr>
...
This will help with specializing the various `make::expr_*` functions later
2025-01-06 15:32:08 -06:00
Chayim Refael Friedman
e18e1eb991
Fix case where completion inside macro that expands to #[test] was unavailable
...
We ignore `#[test]` in the def map, so that's why it failed.
2025-01-06 22:02:24 +02:00
Laurențiu Nicola
5afee0d54d
Merge pull request #18852 from ChayimFriedman2/proc-macro-panic
...
fix: Fix a bug that was caused by fixup reversing
2025-01-06 18:38:24 +00:00
Chayim Refael Friedman
21b9e32af7
Fix a bug that was caused by fixup reversing
2025-01-06 20:06:20 +02:00
Lukas Wirth
22ab7e37be
Merge pull request #18846 from Veykril/push-kmspklwynynu
...
minor: New clippy lints
2025-01-06 17:12:14 +00:00
Lukas Wirth
0b832bf8a3
minor: New clippy lints
2025-01-06 17:57:17 +01:00
Lukas Wirth
29c21d87d0
fix: Fix non-cargo flychecks immediately clearing received diagnostics
2025-01-06 13:44:30 +01:00
Lukas Wirth
43b44cf128
Merge pull request #18836 from Veykril/push-kksuoxxptvty
...
fix: Be more permissive with completion resolve data
2025-01-06 10:37:01 +00:00
Lukas Wirth
0389235a15
fix: Be more permissive with completion resolve data
2025-01-06 11:22:42 +01:00
Lukas Wirth
68c2241053
Merge pull request #18845 from Veykril/push-yyuolqomnkys
...
fix: Fix flycheck getting confused which package to check
2025-01-06 10:21:26 +00:00
Lukas Wirth
e47bb0df91
fix: Fix flycheck getting confused which package to check
2025-01-06 11:05:51 +01:00
Lukas Wirth
aeae353a2c
Merge pull request #18843 from Veykril/push-usuzxtzsnrpt
...
fix: Handle newstyle `rustc_intrinsic` safety correctly
2025-01-06 09:00:32 +00:00
Lukas Wirth
5ee1b0af00
fix: Handle newstyle rustc_intrinsic safety correctly
2025-01-06 09:47:31 +01:00
Lukas Wirth
6aad73603f
fix: Fix relative .cargo env vars not working
2025-01-06 08:50:41 +01:00
