user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
2283 commits 10 branches 154 tags 1.3 GiB
Commit graph

76 commits

Author SHA1 Message Date
jyn
8c838fb2fb Various improvements to check_line_lengths.sh (#1667) 2023-04-09 12:08:46 +09:00
jyn
56c1d301b4 Don't require $GITHUB_TOKEN to build locally (#1652) 2023-03-27 00:28:07 +09:00
Tshepang Mbambo
e826d1bd73 have checkboxes only point to date-check lines in files (#1603) 
They currently also point to filenames, which is redundant.

current

- [ ] thir.md
  - [ ] line 7: 2022-04
  - [ ] line 60: 2022-08
- [ ] traits/chalk.md
  - [ ] line 4: 2022-05

proposed

- thir.md
  - [ ] line 7: 2022-04
  - [ ] line 60: 2022-08
- traits/chalk.md
  - [ ] line 4: 2022-05
 2023-02-16 20:38:25 -08:00
Tshepang Mbambo
dfb4949c40 address review comment 
https://github.com/rust-lang/rustc-dev-guide/pull/1428#discussion_r948143840
 2022-08-25 19:56:58 -07:00
Tshepang Mbambo
ba6d4a9a1c make date-check more easy to use 
One could not run it like the following, for the would be a panic:

    cargo run --manifest-path ci/date-check/Cargo.toml .

Also, remove the need to specify argument, in which case, current_dir
is assumed.
 2022-08-25 19:56:58 -07:00
Tshepang Mbambo
a762ee343e update date-check format on github issue (#1416) 
Co-authored-by: Noah Lev <camelidcamel@gmail.com>
 2022-08-09 14:49:43 -07:00
Tshepang Mbambo
3c7ae5a981 date-check: be more strict 2022-08-02 17:22:34 -04:00
Tshepang Mbambo
481233d42e make date-check more lightweight (#1394) 
* make date-check lightweight

This avoids having to write the date twice when updating date-check.

Before "As of <-- 2022-07 --> July 2022"
After "As of July 2022"

* please clippy

* update date-check docs

* accept review suggestion

Co-authored-by: Noah Lev <camelidcamel@gmail.com>

* address review comment

https://github.com/rust-lang/rustc-dev-guide/pull/1394#pullrequestreview-1042163557

* accept review suggestion

Co-authored-by: Noah Lev <camelidcamel@gmail.com>

* address review comment

https://github.com/rust-lang/rustc-dev-guide/pull/1394#pullrequestreview-1042167261

* address review comment

https://github.com/rust-lang/rustc-dev-guide/pull/1394#issuecomment-1189105017

* this breaks markdown

* address review comment

https://github.com/rust-lang/rustc-dev-guide/pull/1394#discussion_r934018268

This led to a more robust regex, though making the tool more picky.
It also found a wrong date format that was missed.

* address review comment

https://github.com/rust-lang/rustc-dev-guide/pull/1394#discussion_r934018419

* address review comment

https://github.com/rust-lang/rustc-dev-guide/pull/1394#discussion_r934018816

* accept review suggestion

This was reverted by mistake

Co-authored-by: Noah Lev <camelidcamel@gmail.com>

* address review comment

https://github.com/rust-lang/rustc-dev-guide/pull/1394#discussion_r934019395

* use a more simple fn

* address review comment

https://github.com/rust-lang/rustc-dev-guide/pull/1394#discussion_r934018981

Much more clean

* nit

* accept review suggestion

Co-authored-by: Noah Lev <camelidcamel@gmail.com>

* avoid a failed regex

Also, test new shape

* adjust to new regex (which uses named groups)

New regex was introduced by 456008cc35de0597d26fec0030ee5db8a0c2fb65

Co-authored-by: Noah Lev <camelidcamel@gmail.com>
 2022-08-02 13:50:32 -07:00
dependabot[bot]
8cc4c20c1d Bump regex from 1.4.3 to 1.5.5 in /ci/date-check (#1364) 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
 2022-06-07 08:40:42 +09:00
Noah Lev
56748c3e4b Update author field 2021-10-21 15:13:09 -05:00
Noah Lev
30ed0914db Switch date-check to Rust 2021 
No migrations were necessary.
 2021-10-21 15:13:09 -05:00
Noah Lev
352185d778 date-check: Recognize capitalized 'Date' as well 
Now, if people use 'Date' instead of 'date', it won't be ignored.
 2021-08-26 18:53:17 -05:00
Joshua Nelson
2822483dd5 Link to Zulip search for finding the most recent check-in (#1118) 2021-04-29 17:40:25 -03:00
JohnTitor
fc3832f3ff Remove the possible unnecessary flag 2021-04-27 13:15:39 -04:00
Yuki Okushi
651110a824 Replace some Travis-related things completely 2021-04-27 13:15:39 -04:00
Yuki Okushi
613c370d29 Check BASE_SHA only if it's a PR (#1083) 2021-03-11 15:50:34 +01:00
Yuki Okushi
e33049fc64 Switch from Travis to GHA (#1073) 2021-03-10 11:51:56 -05:00
Santiago Pastorino
1333283691 Make check-in.sh output in way that suggest to add only the most relevant info 2021-02-04 10:10:08 -05:00
Camelid
bc320e7800 Implement date-checker 
This tool looks for HTML comments like `<!-- date: 2021-01 -->` in each
Markdown source file and compiles a list of dates that are older than
six months. It then opens an issue with that list, with checkboxes for
each file and date. Note that it will only open an issue if there was at
least one date older than six months; it does nothing if the list is
empty.

This tool is automatically run monthly in a GitHub Actions workflow.
I have tested the tool on a private repo and confirmed that it works.
 2021-02-03 19:29:07 -05:00
Joshua Nelson
9fb6690ae9 Document how to stabilize a library feature (#1036) 
* Move 'force-unstable-if-unmarked' to the bootstrapping chapter

* Document how to stabilize a library feature

Note that features can't be stabilized until they go through FCP and
that FCP happens on the tracking issue, not the PR.

* Fix wrong glob

By default `**` behaves the same as two `*` side by side, i.e. it only
globs file paths, not directories. `shopt -s globstar` needs to be set
for it to mean a directory. I didn't notice this before now because
`globstar` is set by default in interactive mode, but not otherwise.
 2021-02-01 19:31:00 +01:00
Joshua Nelson
76ac4633fe Improve contributor experience for the dev-guide itself (#973) 
- Fix typos in the README
- Don't echo all instructions in the linkcheck.sh shellscript; this is
  noisy and unhelpful when developing locally. Verbose output is still
  enabled in CI.
- Link to the index page for compiler docs, not `rustc_middle`. Note
  that the compiler docs are not a guide - that's us!
- Remove outdated instructions about avoiding 429s. These should no
  longer be occurring locally now that we're using caching.
- Consolidate info about `mdbook` and `mdbook-linkcheck` near each other
 2020-11-30 11:08:32 -03:00
mark
8055279209 don't use cache while running PR builds 2020-11-23 18:42:24 -05:00
Joshua Nelson
3ed54a3ff6 fix formatting 2020-10-22 09:08:04 -04:00
Joshua Nelson
7eb38c2b8c Improve markdown formatting 2020-10-22 09:08:04 -04:00
Joshua Nelson
9354c4f98b Add a check-in.sh script to automate writing markdown links 
Example usage:

```
$ ./check-in.sh
usage: ./check-in.sh <since> <number-of-prs-merged>
$ ./check-in.sh 2020-09-03
usage: ./check-in.sh <since> <number-of-prs-merged>
help: you can find the number of PRs merged at https://github.com/rust-lang/rustc-dev-guide/pulls?q=is%3Apr+is%3Aclosed+updated%3A%3E2020-09-03
$ ./check-in.sh 2020-09-03 72
Authors:
- **@1c3t3a**
- **@arora-aman**
... snip ...
Changes:
- Replace links to `buildbot2.r-l.o` with `bors.r-l.o` [#929](https://github.com/rust-lang/rustc-dev-guide/pull/929)
- Add reference PRs for `r?` and `r+` comments [#928](https://github.com/rust-lang/rustc-dev-guide/pull/928)
... snip ...
Changes in progress:
```
 2020-10-22 09:08:04 -04:00
Who? Me?!
8fe84e6f5e Better error message 
Co-authored-by: Camelid <camelidcamel@gmail.com>
 2020-10-08 17:11:36 -04:00
Who? Me?!
ecc0b6daef Lol logic is hard 
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
 2020-10-08 17:11:36 -04:00
mark
e81601f62f add assert 2020-10-08 17:11:36 -04:00
Who? Me?!
325268f53e More debuggable bash settings 
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
 2020-10-08 17:11:36 -04:00
Who? Me?!
9675f13c71 Add comment referring to travis docs 
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
 2020-10-08 17:11:36 -04:00
mark
c683cf928f linkcheck only for changed files except in cron jobs 2020-10-08 17:11:36 -04:00
Joshua Nelson
059dc43601 Recommend setting up check_line_lengths as a pre-commit script 
I've run into lots of annoying failures from this.

- Make it runnable without arguments
- Add it in the README
 2020-10-01 01:27:11 -04:00
Mark Mansi
770fd80866 use cargo install 2020-01-30 21:47:13 -06:00
Mark Mansi
05185d2d7b remove all the hacks, add some improvements 2019-11-05 11:58:33 -06:00
Amanjeev Sethi
96b9ee0758 Refactor (build CI script): minimizes the script, thanks to mark-i-m 2019-10-04 16:32:47 -05:00
Amanjeev Sethi
3e2d38d341 Fix (build CI script): fails early if linkcheck fails 2019-10-04 16:32:47 -05:00
Amanjeev Sethi
e9abf0071e Fix (build CI script): 
* Removes timeout hack because it is not needed because we have upgraded mdbook_linkcheck
* Renamed build script because it is no longer ignoring timeouts
 2019-10-04 16:32:47 -05:00
Amanjeev Sethi
f40d71327b Revert "Removes timeout script so CI does not have false positives" 
This reverts commit c3ed0a1ef9013f2821eed24efcd9954600ce2b41.
 2019-10-04 16:32:47 -05:00
Amanjeev Sethi
343030ec02 Removes timeout script so CI does not have false positives 2019-10-04 16:32:47 -05:00
Mark Mansi
6e8f64d251 hack + drive-by-fix 2019-09-05 19:04:33 -05:00
Michael Bryan
ee48f72ba8 Updated the mdbook-linkcheck version 2019-09-05 17:03:24 -05:00
Who? Me?!
90fa369861 fix broken link (#421) 2019-08-13 11:56:02 -03:00
Who? Me?!
1254cf3f04 Remove leading new line 2019-08-06 17:18:07 -05:00
Who? Me?!
de6cb97e4b hack around timeouts (#416) 2019-08-05 17:57:25 -03:00
Who? Me?!
b6f07d808b Update install.sh 2019-07-19 11:37:20 -05:00
Who? Me?!
92e36bf443 Update mdbook 2019-07-19 11:37:20 -05:00
Who? Me?!
2eb100a28b Update to mdbook-linkcheck 0.3.0 2019-06-24 09:52:03 -05:00
Who? Me?!
577be7148c Update mdbook 2019-06-24 09:52:03 -05:00
Mark Mansi
3fc2b4a379 update mdbook 2019-03-01 17:16:50 -06:00
Who? Me?!
32a766cafe make the line-length script respect 100 char limit XD (#240) 
🤣 🤣 🤣
 2018-11-26 11:13:21 -06:00