Commit graph

13 commits

Author SHA1 Message Date
Mazdak Farrokhzad
c4b8735872
Rollup merge of #56044 - matthewjasper:function-param-drop-order, r=cramertj
Drop partially bound function parameters in the expected order

Given the function

```rust
fn foo((_x, _): (LogDrop, LogDrop), (_, _y): (LogDrop, LogDrop)) {}
```

Prior to 1.12.0 we dropped both `_x` and `_y` before the rest of their
respective parameters, since then we dropped `_x` and `_y` after. The
original order appears to be the correct order, as the value created
later is dropped first, so we revert to that order and add a test for
it.

While this is technically a breaking change, I can't work out how
anyone could be relying on this without making their code very
brittle. If this is considered to be too likely to break real world code
then I can revert the change and change the test to check for the
current order.
2019-01-15 12:42:04 +01:00
bors
1d029c67e2 Auto merge of #57387 - euclio:nonstandard-style-suggestions, r=oli-obk
Use structured suggestions for nonstandard style lints

This PR modifies the lints in the nonstandard_style group to use structured suggestions. Note that there's a bit of tricky span calculation going on for the `crate_name` attribute. It also simplifies the code a bit: I don't think the "fallback" suggestions for these lints can actually be triggered.

Fixes #48103.
Fixes #52414.
2019-01-14 06:35:51 +00:00
varkor
afcb938116 Stabilise irrefutable if-let and while-let patterns
This stabilises RFC 2086 (https://github.com/rust-lang/rust/issues/44495).

Co-Authored-By: Sebastian Malton <sebastian@malton.name>
2019-01-12 03:10:59 +00:00
Andy Russell
e379970056
improve non_upper_case_globals diagnostics
Use a structured suggestion and tighten the span to just the identifier.
2019-01-08 13:24:38 -05:00
Mark Rousskov
2a663555dd Remove licenses 2018-12-25 21:08:33 -07:00
varkor
4d8a6eac39 Fix some misbehaving tests 2018-12-11 11:18:55 +00:00
Matthew Jasper
914515f809 Drop function parameters in expected order
Given the function

fn foo((_x, _): (LogDrop, LogDrop), (_, _y): (LogDrop, LogDrop)) {}

Prior to 1.12 we dropped both `_x` and `_y` before the rest of their
respective parameters, since then we dropped `_x` and `_y` after. The
original order appears to be the correct order, as the value created
later is dropped first, so we revert to that order and add a test for
it.
2018-11-30 19:43:41 +00:00
varkor
46ef9f820c Fix broken tests 2018-11-29 20:58:38 +00:00
Kevin Leimkuhler
0e411c2597 Add clarifying pattern lint comment and revert test 2018-10-09 21:10:27 -07:00
Kevin Leimkuhler
46b07d670a Simply unused_parens check and add tests 2018-10-09 21:10:27 -07:00
Felix S. Klock II
8d86800500 Add #[allow(unused_mut)] for various cases that arise only in compare-mode=nll. 2018-09-26 13:10:54 +02:00
Felix S. Klock II
c9d9cc6e44 Add #![allow(..)] as necessary to get re-migrated run-pass tests compiling with clean stderr again.
Most were added mechanically.
2018-09-26 13:10:54 +02:00
Felix S. Klock II
2080474c75 Migrate src/test/ui/run-pass/* back to src/test/run-pass/.
Fix #54047
2018-09-26 13:10:54 +02:00