Commit graph

6 commits

Author SHA1 Message Date
Josh Stone
e96a0a8681 Revert "Do not call getpid wrapper after fork in tests"
This reverts commit 12fbabd27f.

It was only needed because of using raw `clone3` instead of `fork`, but
we only do that now when a pidfd is requested.
2021-11-05 14:49:26 -07:00
Dominik Stolz
12fbabd27f Do not call getpid wrapper after fork in tests
The test calls libc::getpid() in the pre_exec hook and asserts that the returned value is different from the PID of the parent.
However, libc::getpid() returns the wrong value.
Before version 2.25, glibc caches the PID of the current process with the goal of avoiding additional syscalls.
The cached value is only updated when the wrapper functions for fork or clone are called.
In PR #81825 we switch to directly using the clone3 syscall.
Thus, the cache is not updated and getpid returns the PID of the parent.
source: https://man7.org/linux/man-pages/man2/getpid.2.html#NOTES
2021-08-01 09:45:00 +02:00
LeSeulArtichaut
d1f0e9f65c Test THIR unsafeck for unsafe ops in closures 2021-05-27 21:04:44 +02:00
The8472
d854789ce1 Do not attempt to unlock envlock in child process after a fork.
This is a breaking change for cases where the environment is
accessed in a Command::pre_exec closure. Except for
single-threaded programs these uses were not correct
anyway since they aren't async-signal safe.
2021-03-09 22:14:07 +01:00
Lzu Tao
6bfe27a3e0 Drop support for cloudabi targets 2020-11-22 17:11:41 -05:00
Jeremy Fitzhardinge
ce56e75283 Move command-related tests into command/ 2019-12-16 14:44:16 -08:00
Renamed from src/test/ui/command-pre-exec.rs (Browse further)