Lukas Wirth
c03775e477
Fix is_quiescent reporting
2023-03-10 10:26:02 +01:00
Lukas Wirth
0d19ccb3df
Make project loading errors less intrusive
2023-03-10 09:49:37 +01:00
Lukas Wirth
116775bc83
Don't attempt to calculate diagnostics in library crates
2023-03-10 09:08:20 +01:00
Lukas Wirth
b4bd27be90
Don't send error notifications for workspace failures if server status is supported
2023-03-08 13:18:44 +01:00
hkalbasi
ac04bfd7a7
Add View Mir command and fix some bugs
2023-03-06 21:09:09 +03:30
Aleksey Kladov
0da27376cf
Support UTF-32 position encoding
...
Looks like this is a native encoding for Emacs at least!
2023-02-14 01:09:50 +00:00
Pascal Kuthe
c7010eda1b
Support DidChangeWorkspaceFolders capability
2023-02-07 22:40:40 +01:00
Lukas Wirth
7385467f2e
Don't respond with a ContentModified while loading the workspace
2023-01-19 21:52:27 +01:00
Lukas Wirth
c9d33cddc9
Don't run flycheck on startup unless checkOnSave is enabled
2023-01-18 21:38:30 +01:00
Daniel Eades
d218b237fd
collapse some nested blocks
2023-01-10 20:40:08 +00:00
Daniel Eades
ed128872eb
remove needless borrows
2023-01-02 14:52:32 +00:00
Daniel Eades
77051679d7
use inline format args
2023-01-02 14:52:32 +00:00
Yuri Astrakhan
e16c76e3c3
Inline all format arguments where possible
...
This makes code more readale and concise,
moving all format arguments like `format!("{}", foo)`
into the more compact `format!("{foo}")` form.
The change was automatically created with, so there are far less change
of an accidental typo.
```
cargo clippy --fix -- -A clippy::all -W clippy::uninlined_format_args
```
2022-12-24 14:36:10 -05:00
Yuri Astrakhan
1d59c7b667
Remove non-needed clones
...
I am not certain if this will improve performance,
but it seems having a .clone() without any need should be removed.
This was done with clippy, and manually reviewed:
```
cargo clippy --fix -- -A clippy::all -D clippy::redundant_clone
```
2022-12-23 02:20:03 -05:00
Lukas Wirth
cf8d89e46b
Add a command to clear flycheck diagnostics
2022-12-17 23:43:26 +01:00
Lukas Wirth
d8ddde27f9
Make cancelFlycheck request a notification
2022-12-17 23:29:31 +01:00
Lukas Wirth
cdfe98fe94
Make manual flycheck runs work when checkOnSave is disabled
2022-12-17 23:26:54 +01:00
Lukas Wirth
a04feb915a
Add command for manually running flychecks
2022-12-16 22:47:19 +01:00
Lukas Wirth
a143ff0248
fix: Fix r-a eagerly showing no discovered workspace errors
2022-11-11 14:36:27 +01:00
Lukas Wirth
e468a1af35
internal: Optimize apply_document_changes a bit
2022-11-05 10:59:46 +01:00
Lukas Wirth
6a00e14c7a
fix: Don't respond with an error when requesting a shutdown while starting
2022-10-24 14:56:58 +02:00
Lukas Wirth
859f5594ac
Handle multiple projects sharing dependency correctly in once strategy
2022-10-23 18:01:35 +02:00
Lukas Wirth
de195ff97c
fix: Fix DidSaveDocument requests blocking the server on startup
2022-10-20 19:55:04 +02:00
bors
4d4c05d32b
Auto merge of #13428 - Veykril:fmt-stuck, r=Veykril
...
fix: Fix formatting requests hanging when r-a is still starting
The reason for that was that we were calculating the crate defmaps of the file we are saving by accident causing us to get stuck waiting on their expensive computation, while we only need the relevant crate id.
Closes https://github.com/rust-lang/rust-analyzer/issues/4054
Closes https://github.com/rust-lang/rust-analyzer/issues/11654
2022-10-17 16:21:32 +00:00
Lukas Wirth
a762baca02
fix: Fix formatting requests hanging when r-a is still starting
...
The reason for that was that we were calculating the crate defmaps
of the file we are saving by accident causing us to get stuck waiting
on their expensive computation, while we only need the relevant crate
id.
2022-10-17 18:21:18 +02:00
Lukas Wirth
e41023ce46
Make flycheck workdone progress reports cancellable
2022-10-17 16:32:47 +02:00
Lukas Wirth
8c433c7296
Fix requests not being retried anymore
2022-10-01 00:07:33 +02:00
Lukas Wirth
1a6c1595fe
Don't retry requests that have already been cancelled
2022-09-27 17:39:15 +02:00
Lukas Wirth
9ad0a8c467
Move empty diagnostics workaround back into the server
2022-08-28 11:54:46 +02:00
Lukas Wirth
2abb78d06d
Pop an error notification when flycheck can't be restarted
2022-08-22 17:42:33 +02:00
Lukas Wirth
45b7b6a60a
Implement lsp extension for cancelling running flychecks
2022-08-19 08:54:53 +02:00
Lukas Wirth
ec8256dd80
Move VSCode diagnostics workaroudn into client code
2022-08-13 20:30:30 +02:00
Lukas Wirth
038c36a1f5
Simplify GlobalState::handle_event
2022-08-13 20:03:06 +02:00
bors
0fe3bcfd35
Auto merge of #12808 - Veykril:check-workspace, r=Veykril
...
feat: Only flycheck workspace that belongs to saved file
Supercedes https://github.com/rust-lang/rust-analyzer/pull/11038
There is still the problem that all the diagnostics are cleared, only clearing diagnostics of the relevant workspace isn't easily doable though I think, will have to dig into that
2022-08-04 12:57:04 +00:00
Lukas Wirth
df7f755e3b
Don't flycheck while the workspace is being loaded
2022-08-04 14:56:44 +02:00
Lukas Wirth
df9d3db82f
Trigger flycheck on all transitive dependencies as well
2022-08-04 13:22:15 +02:00
Amos Wenger
8318035726
Fix last few warnings manually
2022-07-20 15:05:02 +02:00
Lukas Wirth
d73b0d5fc6
Don't filter flychecks by package member status
2022-07-20 11:52:44 +02:00
Lukas Wirth
25391e6d44
Only clear diagnostics of workspaces who have been flychecked
2022-07-20 11:49:36 +02:00
Laurențiu Nicola
474f5eafc7
Work around Code bug with empty diagnostics
2022-07-19 07:45:31 +03:00
Lukas Wirth
a63b5d3c84
feat: Only flycheck workspace that belongs to saved file
2022-07-18 20:30:58 +02:00
Jonas Schievink
6c6ae965ba
Update remaining GitHub URLs
2022-07-08 15:44:49 +02:00
Lukas Wirth
ad109f7f0a
fix: Don't respond to cancelled requests when retrying them
2022-06-12 02:56:19 +02:00
Lukas Wirth
d38b7b88c6
minor: Don't log cancelled diagnostics
2022-06-05 01:38:46 +02:00
Lukas Wirth
343562c54d
minor: Fix rustfmt failing on main_loop.rs
2022-06-01 21:20:54 +02:00
Lukas Wirth
d88ae66ed9
Sync handlers cannot be cancelled
2022-06-01 12:18:15 +02:00
Lukas Wirth
e2da967578
fix: Fix completions disappearing when typing two keys in quick succession
2022-06-01 00:20:47 +02:00
Felicián Németh
636d4880c4
internal: Allow OnTypeFormatting to send SnippetTextEdit
...
But continue to send TextEdit only.
2022-05-22 10:39:18 +02:00
Lukas Wirth
91833f1974
feat: Implement inlay hint tooltips
2022-05-17 12:49:51 +02:00
harpsword
7bd4c11e13
fix diagnostics location map incorrectly from rustc span to lsp position for non-BMP char
2022-05-14 19:19:55 +08:00
