Commit graph

12 commits

Author SHA1 Message Date
Philipp Krones
27f2f0a04e
Merge commit 'ac0e10aa68' into clippyup 2022-10-06 09:44:38 +02:00
Maybe Waffle
9d388dc390 bless clippy 2022-10-01 10:03:06 +00:00
Philipp Krones
7fab8a4016
Merge commit 'fdb84cbfd2' into clippyup 2022-07-18 09:39:37 +02:00
Dylan DPC
74aa55b3fc
Rollup merge of #97798 - WaffleLapkin:allow_for_suggestions_that_are_quite_far_away_from_each_other, r=estebank
Hide irrelevant lines in suggestions to allow for suggestions that are far from each other to be shown

This is an attempt to fix suggestions one part of which is 6 lines or more far from the first. I've noticed "the problem" (of not showing some parts of the suggestion) here: https://github.com/rust-lang/rust/pull/97759#discussion_r889689230.

I'm not sure about the implementation (this big closure is just bad and makes already complicated code even more so), but I want to at least discuss the result.

Here is an example of how this changes the output:

Before:
```text
help: consider enclosing expression in a block
  |
3 ~     'l: { match () { () => break 'l,
4 |
5 |
6 |
7 |
8 |
...
```

After:
```text
help: consider enclosing expression in a block
  |
3 ~     'l: { match () { () => break 'l,
4 |
...
31|
32~ } };
  |
```

r? `@estebank`
`@rustbot` label +A-diagnostics +A-suggestion-diagnostics
2022-06-17 12:21:48 +02:00
flip1995
7f605496e7
Merge commit 'd7b5cbf065' into clippyup 2022-06-16 17:39:06 +02:00
Maybe Waffle
e502b9a0ff bless clippy ui tests 2022-06-16 18:00:32 +04:00
xFrednet
13cc27b445
Merge 'rust-clippy/master' into clippyup 2022-05-21 13:24:00 +02:00
flip1995
333a06af42
Merge commit 'b7f3f7f608' into clippyup 2021-10-07 11:21:30 +02:00
Esteban Kuber
657caa5bf2 update clippy 2021-08-11 14:21:33 +00:00
flip1995
e7bc41176e
Merge commit '54a20a02ec' into clippyup 2021-07-15 10:44:10 +02:00
flip1995
9482caf29f
Merge commit '98e2b9f25b' into clippyup 2021-04-22 11:31:13 +02:00
flip1995
6b37cd3d4f
Merge commit 'b40ea209e7' into clippyup 2021-04-08 17:50:13 +02:00