bors
dd67187965
Auto merge of #67133 - oli-obk:it_must_be_a_sign, r=eddyb
...
Deduplicate pretty printing of constants
r? @eddyb for the pretty printing logic
cc @RalfJung
2020-03-16 16:31:23 +00:00
Yuki Okushi
3609bac340
Add test for issue-67739
2020-03-13 16:06:08 +09:00
Yuki Okushi
a2c41e9cdc
Add test for issue-62504
2020-03-13 16:06:08 +09:00
Oliver Scherer
6e73a14234
Remove fn special casing in const printing
2020-03-12 13:35:44 +01:00
Oliver Scherer
cc9ca640c2
Don't print literal type suffixes if print_ty is false
2020-03-11 09:10:49 +01:00
Oliver Scherer
fff2e0f806
Print function pointer type for function pointer const generics
2020-03-11 09:10:49 +01:00
Oliver Scherer
b837e71732
Reduce special casing in the const pretty printer
2020-03-11 09:10:49 +01:00
Oliver Scherer
e22ddfd80d
Don't print leading zeros on hex dumps constants
2020-03-11 09:10:49 +01:00
Oliver Scherer
02dbb35b2b
Deduplicate and clean up pretty printing logic
2020-03-11 09:10:48 +01:00
YI
906bb8d0e8
fix #62456
2020-03-10 09:30:24 +08:00
CAD97
b3777c952f
Remove chalk integration
2020-03-02 18:11:53 -05:00
Matthew Jasper
ebc86b441d
Fix use of has_infer_types
...
* Add a new method `has_infer_types_or_consts` that's used instead most
of the time, since there's generally no reason to only consider types.
* Remove use of `has_closure_types`, because closures are no longer
implicitly linked to the `InferCtxt`.
2020-03-01 21:42:34 +00:00
varkor
bead79ebc6
Add note regarding argument ordering
2020-02-22 11:34:29 +00:00
varkor
e372ad4800
Expand the documentation for E0747
2020-02-22 11:34:29 +00:00
varkor
039045c49b
Move generic arg / param validation to create_substs_for_generic_args
2020-02-22 00:28:18 +00:00
LeSeulArtichaut
2e07892c7d
Do not emit note suggesting to implement trait to foreign type
...
Update tests
Extend to other operations
Refractor check in a separate function
Fix more tests
2020-02-17 15:21:36 +01:00
Mazdak Farrokhzad
3341c94006
ast_validation: tweak diagnostic output
2020-02-13 10:40:17 +01:00
Mazdak Farrokhzad
e839b2ec84
Constness -> enum Const { Yes(Span), No }
...
Same idea for `Unsafety` & use new span for better diagnostics.
2020-02-13 10:39:23 +01:00
Dylan DPC
2a201336ed
Rollup merge of #67642 - Mark-Simulacrum:relax-bounds, r=Amanieu
...
Relax bounds on HashMap/HashSet
These APIs changed from the old bound listed to the new bound (possibly empty):
K: Hash + Eq -> K
* new
* with_capacity
K: Eq + Hash, S: BuildHasher -> K, S
* with_hasher
* with_capacity_and_hasher
* hasher
K: Eq + Hash + Debug -> K: Debug
S: BuildHasher -> S
HashMap as Debug
K: Eq + Hash -> K
S: BuildHasher + Default -> S: Default
HashMap as Default
Resolves #44777 .
2020-02-13 02:52:46 +01:00
bors
dc4242d905
Auto merge of #68929 - matprec:consistent-issue-references, r=Dylan-DPC
...
Make issue references consistent
Fixes https://github.com/rust-lang/rust/issues/62976
cc https://github.com/rust-lang/rust/pull/63008
r? @varkor because you reviewed the original pr
2020-02-11 02:00:27 +00:00
Matthias Prechtl
7b555178ae
--bless --compare-mode=nll
2020-02-09 20:43:49 +01:00
Josh White
69075f065c
Merge branch 'master' of https://github.com/jwhite927/rust into E0637
2020-02-07 23:56:44 -05:00
Josh White
8b77f8688e
performed --bless of 15 ui tests affected
2020-02-07 12:44:31 -05:00
Eduard-Mihai Burtescu
4c7eb59e81
rustc_macros: don't limit the -Zmacro-backtrace suggestion to extern macros.
2020-02-06 21:46:38 +02:00
bors
5371ddf8c6
Auto merge of #68080 - varkor:declared-here, r=petrochenkov
...
Address inconsistency in using "is" with "declared here"
"is" was generally used for NLL diagnostics, but not other diagnostics. Using "is" makes the diagnostics sound more natural and readable, so it seems sensible to commit to them throughout.
r? @Centril
2020-01-31 15:13:51 +00:00
varkor
24a2929ed1
Normalise notes with the/is
2020-01-24 16:24:50 +00:00
varkor
50dd8eaeb9
Print constants in type_name for const generics
2020-01-24 16:23:32 +00:00
varkor
dd0507c054
Make TooGeneric error in WF checking a proper error
...
`TooGeneric` is encountered during WF checking when we cannot determine that a constant involving a generic parameter will always be evaluated successfully (rather than resulting in an error). In these cases, the burden of proof should be with the caller, so that we can avoid post-monomorphisation tim errors (which was the previous previous behaviour). This commit ensures that this situation produces a proper compiler error, rather than silently ignoring it or ICEing.
2020-01-21 01:03:15 +00:00
Tyler Mandry
9d9c8c69e3
Rollup merge of #68312 - varkor:issue-67753-regression, r=Centril
...
Add regression test for integer literals in generic arguments in where clauses
Closes https://github.com/rust-lang/rust/issues/67753 .
2020-01-17 17:28:20 -08:00
varkor
a91f77ca26
Add regression test for integer literals in generic arguments in where clauses
2020-01-17 16:09:22 +00:00
Esteban Küber
5b36c187dc
review comments
2020-01-16 09:49:13 -08:00
Esteban Küber
e1dd8a9095
When trait bounds are missing for return values, point at them
2020-01-16 09:37:24 -08:00
Ben Lewis
82b90bd993
Update test benchmark file
2020-01-12 20:41:03 +13:00
Ben Lewis
9e46ddc7a2
Added comment about behaviour.
2020-01-12 17:32:50 +13:00
Ben Lewis
b4fddf0f08
Forbid elided lifetimes within const generic parameter types.
2020-01-12 15:59:18 +13:00
Esteban Küber
2c5766f2d4
Unify output of "variant not found" errors
2020-01-08 08:05:31 -08:00
varkor
adb46fd0a4
Silence TooGeneric error
...
This error may be produced during intermediate failed attempts at evaluation of a generic const, which may nevertheless succeed later.
2020-01-05 23:00:47 +00:00
Mark Rousskov
48859db151
Relax bounds on HashSet to match hashbrown
...
No functional changes are made, and all APIs are moved to strictly less
restrictive bounds.
These APIs changed from the old bound listed to the new bound:
T: Hash + Eq -> T
* new
* with_capacity
T: Eq + Hash, S: BuildHasher -> T
* with_hasher
* with_capacity_and_hasher
* hasher
T: Eq + Hash + Debug -> T: Debug
S: BuildHasher -> S
<HashSet as Debug>
T: Eq + Hash -> T
S: BuildHasher + Default -> S: Default
<HashSet as Default>
2019-12-26 19:24:45 -05:00
Mazdak Farrokhzad
07effe18b0
Rollup merge of #67543 - JohnTitor:regression-tests, r=Centril
...
Add regression tests for fixed ICEs
Closes #61747 (fixed from 1.41.0-nightly (4007d4ef2 2019-12-01))
Closes #66205 (fixed from 1.41.0-nightly (4007d4ef2 2019-12-01))
Closes #66270 (fixed by #66246 )
Closes #67424 (fixed by #67160 )
Also picking a minor nit up from #67071 with 101dd7bad9
r? @Centril
2019-12-24 04:39:55 +01:00
Yuki Okushi
d918319bed
Apply suggestion from Centril
...
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
2019-12-24 01:05:09 +09:00
Mark Rousskov
c205f6a06a
Remove mem::uninitalized from tests
...
This purges uses of uninitialized where possible from test cases. Some
are merely moved over to the equally bad pattern of
MaybeUninit::uninit().assume_init() but with an annotation that this is
"the best we can do".
2019-12-22 21:58:12 -05:00
Yuki Okushi
96253c2d15
Add test for issue-66205
2019-12-23 07:42:26 +09:00
Yuki Okushi
7c485ccfad
Add test for issue-61747
2019-12-23 07:42:26 +09:00
Mazdak Farrokhzad
5a8083c665
Rollup merge of #67354 - VirrageS:blame-wrong-line, r=estebank
...
Fix pointing at arg when cause is outside of call
Follow up after: #66933
Closes : #66923
r? @estebank
2019-12-20 17:22:21 +01:00
Ohad Ravid
8a4632dec6
Indicate origin of where type parameter for uninferred types
2019-12-14 11:10:21 +01:00
Esteban Küber
da023c0c6f
Add more context for type parameters
2019-12-11 17:18:43 -08:00
Janusz Marcinkiewicz
e305bf8bc8
Rename tests and add short test description
2019-12-07 08:55:09 +01:00
bors
ab21557501
Auto merge of #66682 - estebank:fn-type-err, r=davidtwco
...
Highlight parts of fn in type errors
When a type error arises between two fn items, fn pointers or tuples,
highlight only the differing parts of each.
Examples:
<img width="699" alt="" src="https://user-images.githubusercontent.com/1606434/69487597-ab561600-0e11-11ea-9b4e-d4fd9e91d5dc.png ">
<img width="528" alt="" src="https://user-images.githubusercontent.com/1606434/69487207-9033d800-0e0a-11ea-93e3-8c4d002411a5.png ">
<img width="468" alt="" src="https://user-images.githubusercontent.com/1606434/69487208-9033d800-0e0a-11ea-92e3-2b2cee120335.png ">
<img width="775" alt="" src="https://user-images.githubusercontent.com/1606434/69487209-9033d800-0e0a-11ea-9e68-7f6ed5c8cb08.png ">
2019-11-25 12:54:42 +00:00
Esteban Küber
d92355c1db
Highlight parts of fn in type errors
...
When a type error arises between two fn items, fn pointers or tuples,
highlight only the differing parts of each.
2019-11-23 16:50:28 -08:00
Esteban Küber
34f03c01f6
Point at type in let assignment on type errors
2019-11-21 19:24:31 -08:00