Steve Klabnik
723ebc2471
Rollup merge of #28203 - benschulz:book-deref-coercion, r=brson
...
I have two issues with the section "Deref and method calls" of the book's chapter "Deref coercions".
- (Minor) It says "In other words, these are the same two things in Rust:", followed by a code block in which no two things seem similar, much less the same. Presumably this sentence made more sense in a previous revision.
- The next paragraph conflates two concepts which, imho, should kept separate. They are
- deref coercion, i.e. inserting as many `*` as necessary and
- implicitly referencing the receiver, i.e. inserting a single `&` to satisfy the method's `self` parameter type.
I appreciate that with the proposed changes the example becomes very contrived, even for a foo-bar-baz one. However, the current exmplanation is just wrong.
2015-09-03 20:10:07 -04:00
Steve Klabnik
b96618e18b
Rollup merge of #28202 - matklad:grammar-loop-labels, r=steveklabnik
...
This adds missing `?` marks to productions for loops and break/continue.
It also adds missing option label to while let loop.
Note that '[' foo ']' means grouping in BNF, and '?' is used for possible missing items.
r? @steveklabnik
2015-09-03 20:10:07 -04:00
christopherdumas
17fde3a34d
Removed incorrect reference from #28196
2015-09-03 14:39:34 -07:00
Aleksey Kladov
73a6199248
reference grammar: fix item definition
...
extern_block should extern_block_item
2015-09-04 00:29:47 +03:00
Aleksey Kladov
f7d5c25b3d
reference grammar: whitespace cleanup
2015-09-03 23:42:33 +03:00
Tshepang Lekhonkhobe
6cdba4f766
book: it is RwLock, not RWLock
2015-09-03 22:14:28 +02:00
Manish Goregaokar
67616f7191
Rollup merge of #28186 - thomas07vt:thomas07vt-patch-trpl-rust-inside-other-languages.md, r=steveklabnik
...
The embed rust file that we compile prints out 'Thread finished..' messages along with a 'done!' r? @steveklabnik
2015-09-04 01:40:02 +05:30
Manish Goregaokar
0c2924386d
Rollup merge of #28184 - xiaochuanyu:patch-1, r=alexcrichton
...
Originally in an example it reads as follows:
```rust
fn inverse<T>() -> T
// this is using ConvertTo as if it were "ConvertFrom<i32>"
where i32: ConvertTo<T> {
42.convert()
}
```
There was no mention of `ConvertFrom` elsewhere in the page other than in this comment. Is this supposed to be `ConvertTo<i64>` ?
I'm confused by this example.
2015-09-04 01:40:01 +05:30
Tshepang Lekhonkhobe
23956ae1f4
book: improve flow
2015-09-03 21:54:00 +02:00
Tshepang Lekhonkhobe
197cec6ed9
book: Rust is a language, so no need to mention that fact here
2015-09-03 21:40:19 +02:00
Aleksey Kladov
59f2343bdb
reference grammar: remove procedure_type
2015-09-03 22:25:47 +03:00
Aleksey Kladov
000fe00726
reference grammar: remove duplicate else_tail rule
2015-09-03 22:19:56 +03:00
benshu
986f523b89
Take method invocation semantics out of chapter on deref coercion.
2015-09-03 21:17:59 +02:00
Tshepang Lekhonkhobe
3525a13fea
book: "word" feels more suitable than "name"
...
Also, add missing comma
2015-09-03 21:14:03 +02:00
Aleksey Kladov
83aee74fce
reference grammar: loop label should be optional
...
This adds missing `?` marks to productions for loops and break/continue.
It also adds missing option label to while let loop
2015-09-03 22:13:50 +03:00
Tshepang Lekhonkhobe
8b2b949830
book: replace comma with a more suitable character
2015-09-03 21:11:44 +02:00
Tshepang Lekhonkhobe
f6f31dd143
book: improve paragraph on stack de-allocation
2015-09-03 21:10:48 +02:00
John Thomas
6fcdead4ee
Bash output fix to match real 'ruby embed.rb' call
...
The embed rust file that we compile prints out 'Thread finished..' messages along with a 'done!'
2015-09-02 23:13:56 -07:00
Xiao Chuan Yu
865d6c3b5b
Fix mistake in trait.md
2015-09-03 01:36:22 -04:00
Jack Wilson
28bf68f3fe
Makes formatting of struct keyword consistent
2015-09-02 18:58:18 -07:00
bors
cfd76b364c
Auto merge of #28135 - jackwilsonv:patch-1, r=steveklabnik
...
Small formatting change
r? @steveklabnik
2015-09-02 19:08:18 +00:00
bors
cb40b8a2ab
Auto merge of #28155 - vchimishuk:doc-rust-inside-other-languages-tab, r=alexcrichton
...
Fixed x variable identation. How it was displayed in Firefox before: http://s16.postimg.org/c9448tn0k/Screenshot_from_2015_09_01_17_35_43.jpg
2015-09-02 04:55:37 +00:00
bors
e758946f96
Auto merge of #28149 - jakerr:atomic, r=alexcrichton
...
Makes the code agree with the comment: 'value answers "am I locked?"'.
2015-09-02 03:13:43 +00:00
Viacheslav Chimishuk
5ae8a0d38f
Source code style fixed: tab replaced with whitespaces.
2015-09-01 17:49:08 +03:00
Jake Kerr
8213f01a76
Reverse AtomicBool value in nomicon example to agree with its comment.
...
Makes the code agree with the comment: 'value answers "am I locked?"'.
2015-09-01 17:32:22 +09:00
Jack Wilson
7665a7f016
Makes formatting of i32 consistent
2015-08-31 15:52:02 -07:00
AlexDenisov
b03b0d4c10
Fix typo
2015-08-31 06:44:27 +02:00
bors
477561de4e
Auto merge of #28078 - apasel422:patch-1, r=alexcrichton
2015-08-29 04:58:45 +00:00
bors
e9111e6a0e
Auto merge of #28070 - mdchoate:patch-1, r=alexcrichton
2015-08-29 03:20:37 +00:00
Andrew Paseltiner
010b7f3621
Remove superfluous line from Nomicon
2015-08-28 22:07:02 -04:00
Michael Choate
645d7ae739
Fix typo in loops.md
2015-08-28 14:34:15 -04:00
Steve Klabnik
1c44722375
Be explicit about using crates.io's libc crate
...
Fixes #28053
2015-08-28 11:43:23 -04:00
Manish Goregaokar
ab3dc54bcf
Rollup merge of #28022 - steveklabnik:gh27936, r=alexcrichton
...
Fixes #27936
2015-08-28 03:38:37 +05:30
Steve Klabnik
af58e5cfea
Add Windows-specific comments to testing guide
...
Fixes #27936
2015-08-27 13:43:43 -04:00
Nikolay Kondratyev
424d9c2778
Fix docs typo
2015-08-26 05:06:00 +05:00
Matt Brubeck
93616af42f
Document the recursion_limit crate attribute
2015-08-25 10:02:58 -07:00
Steve Klabnik
d9de182fa5
Rollup merge of #27982 - frewsxcv:patch-25, r=steveklabnik
2015-08-25 09:43:07 -04:00
Steve Klabnik
c15d0cf270
Rollup merge of #27978 - mgrabovsky:doc-fix, r=steveklabnik
2015-08-25 09:43:07 -04:00
Adam Crume
574deb73ba
book: Mention that --ignored is a test binary argument
2015-08-24 21:53:02 -07:00
Adam Crume
f56a478377
book: Fix spacing in testing section
2015-08-24 21:52:33 -07:00
Corey Farwell
1629dce494
Use correct indefinite article in reference.md
2015-08-24 17:26:26 -04:00
Matěj Grabovský
82bed0a760
Clarify a sentence in the Book
2015-08-24 20:14:39 +02:00
Adam Crume
30fc4b765c
book: Talk about ignore attribute in testing guide
2015-08-23 13:53:52 -07:00
bors
d530379df6
Auto merge of #27922 - tshepang:dst-definition, r=alexcrichton
...
I am not sure this would work... I didn't test.
2015-08-23 06:06:52 +00:00
Steve Klabnik
17c1d0ce04
Rollup merge of #27935 - mbrubeck:cfg-test, r=steveklabnik
...
r? @steveklabnik
2015-08-22 19:15:44 -04:00
Steve Klabnik
1b130326b0
Rollup merge of #27934 - MatejLach:spacing_fix, r=steveklabnik
...
r @steveklabnik ?
2015-08-22 19:15:44 -04:00
Steve Klabnik
fb58dcdbd2
Rollup merge of #27926 - durka:emphasize-no-bin-doctest, r=steveklabnik
...
It came up twice in quick succession on IRC that rustdoc doesn't run tests in bin crates, and doesn't give any explanation/warning either as to why. I thought it couldn't hurt to emphasize that in the Book.
2015-08-22 19:15:43 -04:00
Steve Klabnik
3677a1feca
Rollup merge of #27924 - pornel:bookthreadjoin, r=steveklabnik
...
The chapter on concurrency has two examples that both start with:
let something = thread::spawn(…
but the returned values have different types, because the second example has `.join()` at the end of the expression.
I haven't noticed that join at first, and was wondering how is that possible that the result can have `.is_err()` and `.join()` methods.
I've changed the second example to have the same structure as the first, so they're easy to compare.
2015-08-22 19:15:43 -04:00
Steve Klabnik
b3e9615ed4
Rollup merge of #27921 - tshepang:missing-words, r=steveklabnik
2015-08-22 19:15:43 -04:00
Matt Brubeck
59b69d4ae7
Include cfg(test) in the reference
2015-08-21 09:54:58 -07:00
