xFrednet
eab0a75ff9
Update version attribute for 1.73 lints
2023-10-04 01:08:45 +02:00
DaniPopes
ad5653b296
Add missing lint description headers
2023-09-29 03:08:34 +02:00
Alex Macleod
01c25a8eb6
Remove most usage of hir_ty_to_ty
2023-09-20 14:05:00 +00:00
Dev381
01056c5aae
Fix missing semicolon in redundant_as_str docstring example
2023-09-17 18:10:21 -04:00
Dev381
1c9f3bef8b
Add redundant_as_str lint
...
This lint checks for `as_str` on a `String` immediately followed by `as_bytes` or `is_empty` as those methods are available on `String` too. This could possibly also be extended to `&[u8]` in the future.
2023-09-17 17:50:45 -04:00
y21
981e96008b
new lint: path_ends_with_ext
2023-09-15 16:17:51 +02:00
bors
c1f8ae3a4a
Auto merge of #11430 - TDecking:vec-fmt, r=giraffate
...
Correctly format `vec!` invocations
The [Rust Style Guide](https://doc.rust-lang.org/nightly/style-guide/expressions.html?highlight=vec#array-literals ) says that `vec!` should alwys be used with square brackets, not parenthesis. Within the lint documentation, that rule was violated twice.
changelog: none
2023-09-01 00:03:26 +00:00
bors
3da21b089f
Auto merge of #11396 - y21:issue11345, r=Jarcho
...
new lint: `iter_out_of_bounds`
Closes #11345
The original idea in the linked issue seemed to be just about arrays afaict, but I extended this to catch some other iterator sources such as `iter::once` or `iter::empty`.
I'm not entirely sure if this name makes a lot of sense now that it's not just about arrays anymore (specifically, not sure if you can call `.take(1)` on an `iter::Empty` to be "out of bounds"?).
changelog: [`iter_out_of_bounds`]: new lint
2023-08-30 19:51:32 +00:00
Tobias Decking
6eb7a46b88
Documentation Formatting
2023-08-30 13:36:37 +02:00
y21
11072b51fa
lint vecs, version bump, more tests
2023-08-25 01:13:35 +02:00
y21
86b6644379
new lint: iter_out_of_bounds
2023-08-24 20:21:55 +02:00
lengyijun
fb6fad20c8
[iter_overeager_cloned]: detect .cloned().all() and .cloned().any()
2023-08-24 08:44:25 +08:00
lengyijun
e440065a0f
[iter_overeager_cloned]: detect .cloned().map() and .cloned().for_each()
...
key idea:
for `f` in `.map(f)` and `.for_each(f)`:
1. `f` must be a closure with one parameter
2. don't lint if mutable paramter in clsure `f`: `|mut x| ...`
3. don't lint if parameter is moved
2023-08-19 21:18:14 +08:00
xFrednet
41570c1ee7
Update version attribute for 1.72 lints
2023-08-18 18:27:10 +02:00
lengyijun
fc061890d6
[iter_overeager_cloned]: detect .cloned().filter() and .cloned().find()
...
Key idea:
```
// before
iter.cloned().filter(|x| unimplemented!() )
// after
iter.filter(|&x| unimplemented!() ).cloned()
// before
iter.cloned().filter( foo )
// after
iter.filter(|&x| foo(x) ).cloned()
```
2023-08-14 09:13:01 +08:00
lengyijun
e5b0483c85
Small code style adjustments
2023-08-05 12:41:20 +08:00
Catherine Flores
779e0f4021
Do not lint unwrapping on ! or never-like enums
2023-08-02 14:00:12 -05:00
Your Name
72074a0f00
Alphabetically order arms in methods/mod.rs match
2023-08-02 16:44:26 +08:00
Philipp Krones
3d60241841
Merge remote-tracking branch 'upstream/master' into rustup
2023-07-28 23:44:28 +02:00
Timo
205a3741c1
make lint description more consistent (writer/reader -> write/read)
...
Co-authored-by: Takayuki Nakata <f.seasons017@gmail.com>
2023-07-27 21:19:35 +02:00
y21
136339f2d3
new lint: [readonly_write_lock]
2023-07-27 21:19:35 +02:00
Catherine
978b1daf99
New lint [filter_map_bool_then]
2023-07-25 17:42:36 -05:00
Samuel Moelius
e27977b847
Rename unwrap_or_else_default to unwrap_or_default
2023-07-19 20:36:10 -04:00
Samuel Moelius
84c411272d
Merge unwrap_or_else_default.rs into or_fun_call.rs
2023-07-19 20:36:10 -04:00
Catherine
4c79d8ace5
new lint iter_skip_zero
2023-07-19 03:26:15 -05:00
Catherine
9d08502496
New lint [string_lit_chars_any]
2023-07-19 00:38:22 -05:00
y21
c83d58f507
document that write!ing into a string never fails
2023-07-17 12:23:18 +02:00
y21
c3881569af
new lint: format_collect
2023-07-17 12:13:34 +02:00
Philipp Krones
d6d530fd0b
Merge commit ' d9c24d1b1e' into clippyup
2023-07-17 10:22:32 +02:00
Mahdi Dibaiee
fdb2e363d3
refactor(rustc_middle): Substs -> GenericArg
2023-07-14 13:27:35 +01:00
Philipp Krones
415fdb2d1a
Merge remote-tracking branch 'upstream/master' into rustup
2023-07-14 13:36:16 +02:00
y21
0b5dac0975
[unnecessary_literal_unwrap]: also handle unwrap_err_unchecked
2023-07-11 08:41:36 +02:00
y21
cd1c8532e9
[unnecessary_literal_unwrap]: lint unwrap_unchecked
2023-07-11 08:38:15 +02:00
y21
8fad54e8f9
new lint: read_line_without_trim
2023-07-03 22:51:38 +02:00
bors
c46ddeb9e1
Auto merge of #10987 - y21:type_id_on_box, r=llogiq
...
new lint: `type_id_on_box`
Closes #7687 .
A new lint that detects calling `.type_id()` on `Box<dyn Any>` (and not on the underlying `dyn Any`), which can make up for some pretty confusing bugs!
changelog: new lint: [`type_id_on_box`]
2023-07-03 06:16:14 +00:00
Philipp Krones
cb3ecf7b79
Merge commit ' 37f4c1725d' into clippyup
2023-07-02 14:59:02 +02:00
Catherine
cb5d7e344a
address comments
2023-07-01 12:37:16 -05:00
Catherine
fbb3f759e2
update docs
2023-07-01 12:36:02 -05:00
Catherine
354172a18e
New lint manual_try_fold
2023-07-01 12:36:02 -05:00
darklyspaced
c378bf9ddf
Revert "now passes dogfood by wrapping unwrap_recv and unwrap_arg into a tuple"
...
This reverts commit 7b91844a3207d90d4200a7b53d0ae1a7a1dca73a.
2023-06-27 11:29:02 +08:00
darklyspaced
b832175b2d
now passes dogfood by wrapping unwrap_recv and unwrap_arg into a tuple
...
was previously failing due to `check` having to many arguments.
2023-06-27 11:29:02 +08:00
darklyspaced
c60222dc12
changed the msrv to 1.70 to suggest is_some_and
...
if the msrv is not >= 1.70 then the `map_or` is suggested instead of `is_some_and` (even when `unwrap_or` returns false)
2023-06-27 11:29:02 +08:00
darklyspaced
9b7d8d1dc7
suggests is_some_and over map().unwrap_or(false)
2023-06-27 11:29:02 +08:00
y21
26ac76c15f
add it to the methods lint pass
2023-06-18 22:36:08 +02:00
y21
9ab1e8e95c
that was definitely not the right version
2023-06-18 22:27:20 +02:00
y21
c5a9adc2be
new lint: type_id_on_box
2023-06-18 22:20:10 +02:00
y21
5821fbbc30
add test case for not whole length, move sugg into variable
2023-06-15 20:23:12 +02:00
y21
20ae597ec4
add a description
2023-06-15 20:23:12 +02:00
y21
2748ab9565
new lint: drain_collect
2023-06-15 20:23:11 +02:00
Pavan Kumar Sunkara
6e4c5561be
Preserve type annotations when present
2023-06-12 16:19:26 +01:00
