bors
c8a056547b
Auto merge of #10564 - asquared31415:cast_doesnt_wrap, r=giraffate
...
make cast_possible_wrap work correctly for 16 bit {u,i}size
These changes make `cast_possible_wrap` aware of the different pointer widths and fixes the implementation to print the correct pointer widths.
Fixes #9337
changelog: `cast_possible_wrap` does not lint on `u8 as isize` or `usize as i8`, since these can never wrap.
`cast_possible_wrap` now properly considers 16 bit pointer size and prints the correct bit widths.
2023-06-06 23:54:27 +00:00
asquared31415
7cd0ec58aa
add more info link
2023-06-06 14:58:54 -04:00
bors
167f249141
Auto merge of #10760 - NanthR:almost_standard_formulation, r=xFrednet
...
Standard lint formulations
A WIP that fixes #10660 . Fix lints that don't conform to the standard formulation.
changelog: none
2023-06-04 10:48:03 +00:00
bors
52c235351a
Auto merge of #10879 - Centri3:ptr_cast_constness, r=blyxyas,xFrednet
...
[`ptr_cast_constness`]: Only lint on casts which don't change type
fixes #10874
changelog: [`ptr_cast_constness`]: Only lint on casts which don't change type
2023-06-03 13:19:59 +00:00
Raghul Nanth A
7ac15f9000
Add lint to check lint formulation messages
...
Fix lints that don't conform to the standard formulation
2023-06-03 00:00:30 +05:30
Centri3
ad7c44b3e4
only lint when cast_from and cast_to's ty are the same
2023-06-02 13:14:16 -05:00
bors
c85ceeae3f
Auto merge of #10821 - Centri3:unnecessary_operation_cast_underscore, r=dswij
...
Emit `unnecessary_cast` on raw pointers as well
Supersedes(?) #10782 , since this and #10567 will cover the original issue.
Does not lint on type aliases or inferred types.
changelog: [`unnecessary_cast`]: Also emit on casts between raw pointers with the same type and constness
2023-06-02 17:23:56 +00:00
Philipp Krones
aa3247c891
Merge remote-tracking branch 'upstream/master' into rustup
2023-06-02 10:17:55 +02:00
Urgau
1a5db18b11
Drop uplifted clippy::cast_ref_to_mut
2023-05-31 13:42:53 +02:00
Centri3
7f7979f80b
emit unnecessary_cast on raw pointers as well
2023-05-24 10:53:31 -05:00
bors
a0fd17d3f0
Auto merge of #10779 - Centri3:ptr_cast_constness, r=llogiq
...
Add new lint `ptr_cast_constness`
This adds a new lint which functions as the opposite side of the coin to `ptr_as_ptr`. Rather than linting only as casts that don't change constness, this lints only constness; suggesting to use `pointer::cast_const` or `pointer::cast_mut` instead.
changelog: new lint [`ptr_cast_constness`]
2023-05-23 21:40:50 +00:00
Philipp Krones
b76b0aeb63
Merge commit ' 435a8ad86c' into clippyup
2023-05-20 15:39:26 +02:00
Jason Newcomb
5351170744
Slightly refactor constant evaluation and add detection for empty macro expansion and cfged statements.
2023-05-18 15:43:33 -04:00
Centri3
97467e4aa3
change clippy::version to 1.71.0
2023-05-16 16:29:31 -05:00
Centri3
4ff1cd365d
add description and rename msrv tests
2023-05-16 11:20:00 -05:00
Catherine
f6a0437e74
Update clippy_lints/src/casts/ptr_cast_constness.rs
...
Co-authored-by: llogiq <bogusandre@gmail.com>
2023-05-15 13:14:45 -05:00
Centri3
c5a914b181
check msrv
2023-05-14 19:31:12 -05:00
Centri3
8c191add87
the implementation!!
2023-05-14 19:25:23 -05:00
Philipp Krones
7e9abb311d
Merge commit ' 371120bdbf' into clippyup
2023-05-05 17:45:49 +02:00
bors
96f8471d81
Auto merge of #10649 - jsoref:spelling, r=Jarcho
...
Spelling
This PR corrects misspellings identified by the [check-spelling action](https://github.com/marketplace/actions/check-spelling ).
The misspellings have been reported at https://github.com/jsoref/rust-clippy/actions/runs/4710771873#summary-12776860721
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/rust-clippy/actions/runs/4710771874#summary-12776860722
changelog: none
2023-04-23 22:30:06 +00:00
Josh Soref
d2061faf9e
Spelling
...
* applying
* binding
* complex
* constituent
* demonstrate
* desugaring
* exact
* expression
* for
* functionalities
* github
* implementation
* infers
* multiple conflicting traits
* mutable
* necessarily
* nightly
* nonexistent
* optional
* parameter
* reassignments
* resources
* substitution
* suggestion
* that
* that array is
* using the
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-04-23 10:52:27 -04:00
Philipp Krones
a1b75c5108
Merge commit ' a3ed905928' into clippyup
2023-04-23 13:28:56 +02:00
Philipp Krones
583c97e9bb
Merge remote-tracking branch 'upstream/master' into rustup
2023-04-23 03:39:03 -07:00
bors
d9c2957221
Auto merge of #10629 - Alexendoo:as-ptr-cast-mut-docs-ub, r=Jarcho
...
Fix UB in `as_ptr_cast_mut` documentation
changelog: none
Fixes #10628
There's no `String::as_mut_ptr` surprisingly, so the example is actually calling `str::as_mut_ptr` on an empty `str`
2023-04-12 16:47:34 +00:00
bluthej
6409556926
Standardize lint formulation
2023-04-12 13:48:03 +02:00
Philipp Krones
6b95029f17
Merge commit ' 83e42a2337' into clippyup
2023-04-11 15:31:08 +02:00
Alex Macleod
8f979af3d1
Fix UB in as_ptr_cast_mut documentation
2023-04-11 11:17:18 +00:00
asquared31415
6681914b54
make cast_possible_wrap not lint on conversions for sizes that cannot wrap, and make it work correctly for 16 bit {u,i}size
2023-03-28 23:55:47 -04:00
J-ZhengLi
52c4dc65d9
fix [cast_possible_truncation] offering wrong suggestion when casting from float
...
suggest `try_into` when casting to wildcard type;
fix [`cast_possible_truncation`] suggesting useless parenthesis;
remove suggesting for float to float conversion in [`cast_possible_truncation`]
style nit
2023-03-25 09:26:43 +08:00
Philipp Krones
cf8a67d9ad
Merge commit ' 3c06e0b1ce' into clippyup
2023-03-10 10:53:50 +01:00
Jason Newcomb
efbcb99b73
Use snippet_with_context more
2023-03-03 00:55:53 -05:00
Jason Newcomb
0413fb35ba
Merge commit ' 149392b0ba' into clippyup
2023-02-25 19:28:50 -05:00
Jason Newcomb
bc184e9c7d
Merge branch 'master' into rustup
2023-02-25 17:43:19 -05:00
Kyle Matsuda
98c4a49db8
remove bound_type_of query; make type_of return EarlyBinder; change type_of in metadata
2023-02-16 17:05:56 -07:00
Kyle Matsuda
f0565c939e
change usages of type_of to bound_type_of
2023-02-16 17:01:52 -07:00
Samuel Tardieu
d9dc1679f5
cast_possible_truncation: issue proper help message
2023-02-12 08:56:21 +01:00
Philipp Krones
5c7a65251a
Merge commit ' 1480cea393' into clippyup
2023-01-27 21:09:08 +01:00
Kyle Matsuda
afb586fa1f
change fn_sig query to use EarlyBinder; remove bound_fn_sig query; add EarlyBinder to fn_sig in metadata
2023-01-26 20:28:25 -07:00
Kyle Matsuda
38899d0c29
replace usages of fn_sig query with bound_fn_sig
2023-01-26 20:15:36 -07:00
Michael Goulet
bd1d8971cf
rename find_parent_node to opt_parent_id
2023-01-04 00:43:13 +00:00
Philipp Krones
4ccafea92d
Merge commit ' 4f3ab69ea0' into clippyup
2022-12-29 14:28:34 +01:00
Philipp Krones
1c422524c7
Merge commit ' 4bdfb0741d' into clippyup
2022-12-17 14:12:54 +01:00
Philipp Krones
d05e2865a0
Merge commit ' d822110d3b' into clippyup
2022-12-01 18:29:38 +01:00
hkalbasi
0aaea40eb2
move some layout logic to rustc_target::abi::layout
2022-11-24 16:26:12 +03:30
Philipp Krones
46c5a5d234
Merge commit ' f4850f7292' into clippyup
2022-11-21 20:51:52 +01:00
Maybe Waffle
471d855a8e
Update tooling
2022-10-27 18:41:26 +04:00
flip1995
cd0bb7de01
Merge commit ' 4f142aa105' into clippyup
2022-10-23 15:18:45 +02:00
Philipp Krones
d75b25faab
Merge commit ' ac0e10aa68' into clippyup
2022-10-06 09:44:38 +02:00
Takayuki Maeda
4bcaddeeb2
separate the receiver from arguments in HIR under /clippy
2022-09-05 22:25:57 +09:00
Jason Newcomb
fb41bfa774
Merge commit ' f51aade56f' into clippyup
2022-08-31 09:24:45 -04:00
