`TyCtxt::short_string` ensures that user visible type paths aren't overwhelming on the terminal output, and properly saves the long name to disk as a side-channel. We already use these throughout the compiler and have been using them as needed when users find cases where the output is verbose. This is a proactive search of some cases to use `short_string`. We add support for shortening the path of "trait path only". Every manual use of `short_string` is a bright marker that that error should be using structured diagnostics instead (as they have proper handling of long types without the maintainer having to think abou tthem). When we don't actually print out a shortened type we don't need the "use `--verbose`" note. On E0599 show type identity to avoid expanding the receiver's generic parameters. Unify wording on `long_ty_path` everywhere.
66 lines
2 KiB
Rust
66 lines
2 KiB
Rust
//@ edition: 2021
|
|
//@ run-rustfix
|
|
|
|
#![allow(unused)]
|
|
|
|
struct Foo;
|
|
|
|
impl Foo {
|
|
fn get(&self) -> u8 {
|
|
42
|
|
}
|
|
}
|
|
|
|
fn test_result_in_result() -> Result<(), ()> {
|
|
let res: Result<_, ()> = Ok(Foo);
|
|
res.get();
|
|
//~^ ERROR no method named `get` found for enum `Result<T, E>` in the current scope
|
|
//~| HELP use the `?` operator
|
|
Ok(())
|
|
}
|
|
|
|
async fn async_test_result_in_result() -> Result<(), ()> {
|
|
let res: Result<_, ()> = Ok(Foo);
|
|
res.get();
|
|
//~^ ERROR no method named `get` found for enum `Result<T, E>` in the current scope
|
|
//~| HELP use the `?` operator
|
|
Ok(())
|
|
}
|
|
|
|
fn test_result_in_unit_return() {
|
|
let res: Result<_, ()> = Ok(Foo);
|
|
res.get();
|
|
//~^ ERROR no method named `get` found for enum `Result<T, E>` in the current scope
|
|
//~| HELP consider using `Result::expect` to unwrap the `Foo` value, panicking if the value is a `Result::Err`
|
|
}
|
|
|
|
async fn async_test_result_in_unit_return() {
|
|
let res: Result<_, ()> = Ok(Foo);
|
|
res.get();
|
|
//~^ ERROR no method named `get` found for enum `Result<T, E>` in the current scope
|
|
//~| HELP consider using `Result::expect` to unwrap the `Foo` value, panicking if the value is a `Result::Err`
|
|
}
|
|
|
|
fn test_option_in_option() -> Option<()> {
|
|
let res: Option<_> = Some(Foo);
|
|
res.get();
|
|
//~^ ERROR no method named `get` found for enum `Option<T>` in the current scope
|
|
//~| HELP use the `?` operator
|
|
Some(())
|
|
}
|
|
|
|
fn test_option_in_unit_return() {
|
|
let res: Option<_> = Some(Foo);
|
|
res.get();
|
|
//~^ ERROR no method named `get` found for enum `Option<T>` in the current scope
|
|
//~| HELP consider using `Option::expect` to unwrap the `Foo` value, panicking if the value is an `Option::None`
|
|
}
|
|
|
|
fn test_option_private_method() {
|
|
let res: Option<_> = Some(vec![1, 2, 3]);
|
|
res.len();
|
|
//~^ ERROR method `len` is private
|
|
//~| HELP consider using `Option::expect` to unwrap the `Vec<{integer}>` value, panicking if the value is an `Option::None`
|
|
}
|
|
|
|
fn main() {}
|