bors d03fe84169 Auto merge of #79328 - c410-f3r:hir-if, r=matthewjasper ... Reintroduce hir::ExprKind::If Basically copied and paste #59288/https://github.com/rust-lang/rust-clippy/pull/4080 with some modifications. The vast majority of tests were fixed and now there are only a few remaining. Since I am still unable to figure out the missing pieces, any help with the following list is welcome. - [ ] **Unnecessary `typeck` exception**: [Cheated on this one to make CI green.](https://github.com/rust-lang/rust/pull/79328/files#diff-3faee9ba23fc54a12b7c43364ba81f8c5660045c7e1d7989a02a0cee1c5b2051) - [x] **Incorrect span**: [Span should reference `then` and `else` separately.](https://github.com/rust-lang/rust/pull/79328/files#diff-cf2c46e82222ee4b1037a68fff8a1af3c4f1de7a6b3fd798aacbf3c0475abe3d) - [x] **New note regarding `assert!`**: [Modified but not "wrong". Maybe can be a good thing?](https://github.com/rust-lang/rust/pull/79328/files#diff-9e0d7c89ed0224e2b62060c957177c27db43c30dfe3c2974cb6b5091cda9cfb5) - [x] **Inverted report location**: [Modified but not "wrong". Locations were inverted.](https://github.com/rust-lang/rust/pull/79328/files#diff-f637ce7c1f68d523a165aa9651765df05e36c4d7d279194b1a6b28b48a323691) - [x] **`src/test/ui/point-to-type-err-cause-on-impl-trait-return.rs` has weird errors**: [Not sure why this is happening.](https://github.com/rust-lang/rust/pull/79328/files#diff-c823c09660f5b112f95e97e8ff71f1797b6c7f37dbb3d16f8e98bbaea8072e95) - [x] **Missing diagnostic**: [???](https://github.com/rust-lang/rust/pull/79328/files#diff-6b8ab09360d725ba4513933827f9796b42ff9522b0690f80b76de067143af2fc)		2021-01-14 14:41:58 +00:00
..
call_expressions.rs	Rename TypeckTables to TypeckResults.	2020-07-17 08:47:04 +00:00
closure_expressions.rs	simplify-locals: Remove unused assignments regardless of rvalue kind	2020-10-26 10:48:28 +01:00
consts.rs	hir: replace "items" terminology with "nodes" where appropriate.	2020-03-19 14:36:04 +02:00
enum_constructors.rs	simplify-locals: Remove unused set-discriminant statements	2020-10-26 10:41:44 +01:00
enum_defs.rs	hir: replace "items" terminology with "nodes" where appropriate.	2020-03-19 14:36:04 +02:00
exported_vs_not.rs	mir_built is a lie	2020-07-15 12:58:32 +02:00
extern_mods.rs	Update test.	2020-11-26 21:32:28 +01:00
for_loops.rs	Rename TypeckTables to TypeckResults.	2020-07-17 08:47:04 +00:00
function_interfaces.rs	Rename TypeckTables to TypeckResults.	2020-07-17 08:47:04 +00:00
if_expressions.rs	Reintroduce hir::ExprKind::If	2021-01-07 18:54:12 -03:00
indexing_expressions.rs	hir: replace "items" terminology with "nodes" where appropriate.	2020-03-19 14:36:04 +02:00
inherent_impls.rs	Update code to account for extern ABI requirement	2021-01-13 07:49:45 -05:00
inline_asm.rs	mir_built is a lie	2020-07-15 12:58:32 +02:00
let_expressions.rs	Rename TypeckTables to TypeckResults.	2020-07-17 08:47:04 +00:00
loop_expressions.rs	Rename TypeckTables to TypeckResults.	2020-07-17 08:47:04 +00:00
match_expressions.rs	Rename TypeckTables to TypeckResults.	2020-07-17 08:47:04 +00:00
panic_exprs.rs	mir_built is a lie	2020-07-15 12:58:32 +02:00
statics.rs	hir: replace "items" terminology with "nodes" where appropriate.	2020-03-19 14:36:04 +02:00
struct_constructors.rs	Rename TypeckTables to TypeckResults.	2020-07-17 08:47:04 +00:00
struct_defs.rs	hir: replace "items" terminology with "nodes" where appropriate.	2020-03-19 14:36:04 +02:00
trait_defs.rs	Update code to account for extern ABI requirement	2021-01-13 07:49:45 -05:00
trait_impls.rs	hir: replace "items" terminology with "nodes" where appropriate.	2020-03-19 14:36:04 +02:00
type_defs.rs	hir: replace "items" terminology with "nodes" where appropriate.	2020-03-19 14:36:04 +02:00
unary_and_binary_exprs.rs	Rename TypeckTables to TypeckResults.	2020-07-17 08:47:04 +00:00
while_let_loops.rs	Rename TypeckTables to TypeckResults.	2020-07-17 08:47:04 +00:00
while_loops.rs	Rename TypeckTables to TypeckResults.	2020-07-17 08:47:04 +00:00