bors 96fe3c31c2 Auto merge of #147022 - Zalathar:no-args, r=wesleywiser ... Remove current code for embedding command-line args in PDB The compiler currently has code that will obtain a list of quoted command-line arguments, and pass it through to TargetMachine creation, so that the command-line args can be embedded in PDB output. This PR removes that code, due to subtle concerns that might not have been apparent when it was originally added. --- Those concerns include: - The entire command-line quoting process is repeated every time a target-machine-factory is created. In incremental builds this typically occurs 500+ times, instead of happening only once. The repeated quoting constitutes a large chunk of instructions executed in the `large-workspace` benchmark. - See https://github.com/rust-lang/rust/pull/146804#issuecomment-3317322958 for an example of the perf consequences of skipping all that work. - This overhead occurs even when building for targets or configurations that don't emit PDB output. - Command-line arguments are obtained in a way that completely bypasses the query system, which is a problem for the integrity of incremental compilation. - Fixing this alone is likely to inhibit incremental rebuilds for most or all CGUs, even in builds that don't emit PDB output. - Command-line arguments and the executable path are obtained in a way that completely bypasses the compiler's path-remapping system, which is a reproducibility hazard. - https://github.com/rust-lang/rust/issues/128842 --- Relevant PRs: - https://github.com/rust-lang/rust/pull/113492 - https://github.com/rust-lang/rust/pull/130446 - https://github.com/rust-lang/rust/pull/131805 - https://github.com/rust-lang/rust/pull/146700 - https://github.com/rust-lang/rust/pull/146973 Zulip thread: - https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Some.20PDB.20info.20bypasses.20the.20query.20system.20and.20path.20remapping/with/541432211 --- According to rust-lang/rust#96475, one of the big motivations for embedding the command-line arguments was to enable tools like Live++. [It appears that Live++ doesn't actually support Rust yet](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/embeded.20compiler.20args.20and.20--remap-path-prefix/near/523800010), so it's possible that there aren't any existing workflows for this removal to break. In the future, there could be a case for reintroducing some or all of this functionality, guarded behind an opt-in flag so that it doesn't cause problems for other users. But as it stands, the current implementation puts a disproportionate burden on other users and on compiler maintainers.		2025-10-22 00:21:08 +00:00
..
assembly-llvm	Add support for //@ ignore-i586	2025-10-21 12:39:49 +11:00
auxiliary	Add test for addrspacecasting global vars	2025-09-03 08:40:51 +02:00
codegen-llvm	Auto merge of #147476 - ehuss:cold-attribute-test, r=chenyukang	2025-10-21 07:41:32 +00:00
codegen-units	pub async fn implementation coroutine (func::{closure#0}) is monomorphized, when func itself is monomorphized	2025-09-01 13:45:00 +07:00
coverage	Auto merge of #145882 - m-ou-se:format-args-extend-1-arg, r=petrochenkov	2025-09-26 04:34:09 +00:00
coverage-run-rustdoc
crashes	instantiate predicate binder without recanonicalizing goal in new solver	2025-10-20 10:31:08 +02:00
debuginfo	Auto merge of #146414 - GuillaumeGomez:run-test-with-gcc-backend, r=Kobzol	2025-10-14 09:21:23 +00:00
incremental	Ignore failing incremental tests for GCC backend	2025-10-13 15:20:49 +02:00
mir-opt	GVN: Preserve derefs at terminators that cannot write to memory	2025-10-16 23:03:05 +08:00
pretty	Update autodiff tests for the new intrinsics impl	2025-08-14 18:33:43 +00:00
run-make	Remove current code for embedding command-line args in PDB	2025-10-18 12:24:40 +11:00
run-make-cargo	Skip the panic-immediate-abort-works test when cross-compiling	2025-09-22 21:13:38 -04:00
rustdoc	Add regression test for doc cfg applied on public items inside private items	2025-09-29 18:08:51 +02:00
rustdoc-gui	rustdoc-search: add test case for throbber	2025-10-07 12:59:58 -07:00
rustdoc-js	rustdoc: add testcase for traitParent deduplication	2025-10-02 15:29:22 -05:00
rustdoc-js-std	rustdoc search: relax rules for identifiers	2025-10-20 12:58:55 -05:00
rustdoc-json	Add tests for doc(attribute = "...") attribute	2025-08-28 15:56:30 +02:00
rustdoc-ui	Rollup merge of #147734 - fmease:tighten-relaxed, r=lcnr	2025-10-20 22:30:53 +11:00
ui	Auto merge of #146725 - lcnr:eager-instantiate-binder, r=BoxyUwU	2025-10-21 21:09:46 +00:00
ui-fulldeps	Remove current code for embedding command-line args in PDB	2025-10-18 12:24:40 +11:00
COMPILER_TESTS.md