user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
rust/compiler/rustc_codegen_ssa
History
Matthias Krüger e9e2ebb051
Rollup merge of #124414 - lqd:subdiagnostics, r=davidtwco 
remove extraneous note on `UnableToRunDsymutil` diagnostic

If I understand [this FIXME](1367827eac/compiler/rustc_macros/src/diagnostics/diagnostic.rs (L205)) correctly, it seems we don't yet validate subdiagnostics, so `#[note]` and co in the `#[derive(Diagnostic]` item could be out-of-sync with the fluent message, without causing compile errors.

It was the case for `rustc_codegen_ssa::errors::UnableToRunDsymutil`, causing the ICE in #124392.

I've grepped and scripted my way through most of our diagnostics structs and fluent bundles and the above was the only such extraneous `#[note]`/`#[note(name)]`/`#[help]`/`#[warning]` I could find, so hopefully there aren't many others like it.

I haven't checked if the opposite can happen, a `.note = ` in a fluent message that is lacking a corresponding `#[note]` on the struct and not causing an error, but maybe it's possible?

r? ``@davidtwco``
fixes #124392
2024-05-02 19:42:48 +02:00
..
src Rollup merge of #124414 - lqd:subdiagnostics, r=davidtwco 2024-05-02 19:42:48 +02:00
Cargo.toml Update ar_archive_writer to 0.2.0 2024-04-09 17:45:02 +00:00
messages.ftl Handle calls to upstream monomorphizations in compiler_builtins 2024-03-16 15:22:05 -04:00
README.md mv compiler to compiler/ 2020-08-30 18:45:07 +03:00

README.md

Please read the rustc-dev-guide chapter on Backend Agnostic Codegen.