Matthias Krüger 7d63382000 Rollup merge of #145656 - folkertdev:stabilize-s390x-vector, r=Amanieu ... Stabilize s390x `vector` target feature and `is_s390x_feature_detected!` macro closes https://github.com/rust-lang/rust/issues/145649 closes https://github.com/rust-lang/rust/issues/135413 cc: https://github.com/rust-lang/rust/issues/130869 reference PR: https://github.com/rust-lang/reference/pull/1972 # Stabilization report ## Summary This PR stabilizes the following s390x target features: - `vector` - `vector-enhancements-1` - `vector-enhancements-2` - `vector-enhancements-3` - `vector-packed-decimal` - `vector-packed-decimal-enhancement` - `vector-packed-decimal-enhancement-2` - `vector-packed-decimal-enhancement-3` - `nnp-assist` - `miscellaneous-extensions-2` - `miscellaneous-extensions-3` - `miscellaneous-extensions-4` Additionally, it stabilizes the `std::arch::is_s390x_feature_detected!` macro itself and stably accepts the target features listed above. ## Tests & ABI details Only the `vector` target feature changes the ABI, much like e.g. `avx2` it will, depending on the ABI, pass vector types in vector registers. This behavior is tested extensively: - [tests/assembly-llvm/s390x-vector-abi.rs](22a86f8280/tests/assembly-llvm/s390x-vector-abi.rs) - [tests/codegen-llvm/s390x-simd.rs](22a86f8280/tests/assembly-llvm/s390x-vector-abi.rs) - [tests/ui/abi/simd-abi-checks-s390x.rs ](22a86f8280/tests/ui/abi/simd-abi-checks-s390x.rs ) The remaining features don't influence the ABI, they only influence instruction selection. In stdarch we test that the expected instructions are in fact generated when the target feature is enabled. ## Implementation history For `is_s390x_feature_detected!`: - https://github.com/rust-lang/stdarch/pull/1699 - https://github.com/rust-lang/rust/pull/138275 - https://github.com/rust-lang/stdarch/pull/1720 - https://github.com/rust-lang/stdarch/pull/1832 For `vector` and friends - https://github.com/rust-lang/rust/pull/127506 - https://github.com/rust-lang/rust/pull/135630 - https://github.com/rust-lang/rust/pull/141250 ## Unresolved questions There is a fixme in [tests/ui/abi/simd-abi-checks-s390x.rs](22a86f8280/tests/ui/abi/simd-abi-checks-s390x.rs): ``` // FIXME: +soft-float itself doesn't set -vector //`@[z13_soft_float]` compile-flags: --target s390x-unknown-linux-gnu -C target-cpu=z13 -C target-feature=-vector,+soft-float //`@[z13_soft_float]` needs-llvm-components: systemz ``` I'm not sure whether that blocks stabilization? --- The implementation first extracts the listed target features into their own `s390x_target_feature_vector` rust feature, and then stabilizes that. best reviewed commit-by-commit r? `@Amanieu` cc `@uweigand` `@taiki-e`		2025-11-08 15:42:19 +01:00
..
assembly-llvm	stabilize s390x_target_feature_vector	2025-11-06 12:49:48 +01:00
auxiliary	Rollup merge of #147355 - sayantn:masked-loads, r=RalfJung,bjorn3	2025-11-05 10:59:18 +11:00
codegen-llvm	Rollup merge of #145656 - folkertdev:stabilize-s390x-vector, r=Amanieu	2025-11-08 15:42:19 +01:00
codegen-units	pub async fn implementation coroutine (func::{closure#0}) is monomorphized, when func itself is monomorphized	2025-09-01 13:45:00 +07:00
coverage	Add coverage scope for controlling paths in code coverage	2025-10-27 12:54:24 +01:00
coverage-run-rustdoc
crashes	feat: Use annotate-snippets by default on nightly	2025-11-05 09:01:07 -07:00
debuginfo	Minor fixes to StdNonZeroNumberProvider for gdb	2025-11-05 11:42:54 -07:00
incremental	Add a fast path for lowering trivial consts	2025-10-25 16:59:53 -04:00
mir-opt	Rollup merge of #147925 - fneddy:fix_big_endian_GVN_tests, r=saethlin	2025-11-05 10:59:18 +11:00
pretty	Remove QPath::LangItem from ranges	2025-10-27 21:19:38 -05:00
run-make	Auto merge of #148573 - matthiaskrgr:rollup-cn5viia, r=matthiaskrgr	2025-11-06 14:52:37 +00:00
run-make-cargo	Skip the panic-immediate-abort-works test when cross-compiling	2025-09-22 21:13:38 -04:00
rustdoc	Rollup merge of #148213 - GuillaumeGomez:fix-exit-of-expansion, r=yotamofek	2025-11-06 12:29:58 +01:00
rustdoc-gui	rustdoc-search: add test case for throbber	2025-10-07 12:59:58 -07:00
rustdoc-js	rustdoc-search: remove broken index special case	2025-11-05 23:41:43 -07:00
rustdoc-js-std	Add regression test for including derive macros in macro filtering	2025-10-27 16:00:32 +01:00
rustdoc-json	Add tests for doc(attribute = "...") attribute	2025-08-28 15:56:30 +02:00
rustdoc-ui	feat: Use annotate-snippets by default on nightly	2025-11-05 09:01:07 -07:00
ui	Rollup merge of #145656 - folkertdev:stabilize-s390x-vector, r=Amanieu	2025-11-08 15:42:19 +01:00
ui-fulldeps	When more than a single impl and less than 4 could apply, point at them	2025-10-31 20:44:01 +00:00
COMPILER_TESTS.md