15ed281699
Port clippy away from compiletest to ui_test Reasons to do this: * runs completely on stable Rust * is easier to extend with new features * has its own dogfood test suite, so changes can be tested in [the `ui_test` repo](https://github.com/oli-obk/ui_test) * supports dependencies from crates.io without having to manually fiddle with command line flags * supports `ui-cargo`, `ui`, `ui-toml` out of the box, no need to find and run the tests ourselves One thing that is a big difference to `compiletest` is that if a test emits *any* error, you need to mark all of them with `//~ ERROR:` annotations. Since many clippy tests did not have annotations, I changed many lints to be `warn` in their test so that only the `stderr` output is tested. TODO: * [ ] check that this still works as a subtree in the rustc repo changelog: none <!-- changelog_checked --> Note: at present the latest changes needed for clippy are only available as a git dependency, but I expect to publish a new crates.io version soon |
||
|---|---|---|
| .. | ||
| infrastructure | ||
| proposals | ||
| adding_lints.md | ||
| basics.md | ||
| common_tools_writing_lints.md | ||
| lint_passes.md | ||
| macro_expansions.md | ||
| README.md | ||
| type_checking.md | ||
Clippy Development
Hello fellow Rustacean! If you made it here, you're probably interested in making Clippy better by contributing to it. In that case, welcome to the project!
Note: If you're just interested in using Clippy, there's nothing to see from this point onward, and you should return to one of the earlier chapters.
Getting started
If this is your first time contributing to Clippy, you should first read the Basics docs. This will explain the basics on how to get the source code and how to compile and test the code.
Additional Readings for Beginners
If a dear reader of this documentation has never taken a class on compilers and interpreters, it might be confusing as to why AST level deals with only the language's syntax. And some readers might not even understand what lexing, parsing, and AST mean.
This documentation serves by no means as a crash course on compilers or language design. And for details specifically related to Rust, the Rustc Development Guide is a far better choice to peruse.
The Syntax and AST chapter and the High-Level IR chapter are great introduction to the concepts mentioned in this chapter.
Some readers might also find the introductory chapter of Robert Nystrom's Crafting Interpreters a helpful overview of compiled and interpreted languages before jumping back to the Rustc guide.
Writing code
If you have done the basic setup, it's time to start hacking.
The Adding lints chapter is a walk through on how to add a new lint to Clippy. This is also interesting if you just want to fix a lint, because it also covers how to test lints and gives an overview of the bigger picture.
If you want to add a new lint or change existing ones apart from bugfixing, it's also a good idea to give the stability guarantees and lint categories sections of the Clippy 1.0 RFC a quick read. The lint categories are also described earlier in this book.
Note: Some higher level things about contributing to Clippy are still covered in the
CONTRIBUTING.mddocument. Some of those will be moved to the book over time, like:
- Finding something to fix
- IDE setup
- High level overview on how Clippy works
- Triage procedure
- Bors and Homu