rust/library/std/src/sys
Yuki Okushi 1c4a5f8d1e
Rollup merge of #77147 - fusion-engineering-forks:static-mutex, r=dtolnay
Split sys_common::Mutex in StaticMutex and MovableMutex.

The (unsafe) `Mutex` from `sys_common` had a rather complicated interface. You were supposed to call `init()` manually, unless you could guarantee it was neither moved nor used reentrantly.

Calling `destroy()` was also optional, although it was unclear if 1) resources might be leaked or not, and 2) if `destroy()` should only be called when `init()` was called.

This allowed for a number of interesting (confusing?) different ways to use this `Mutex`, all captured in a single type.

In practice, this type was only ever used in two ways:

1. As a static variable. In this case, neither `init()` nor `destroy()` are called. The variable is never moved, and it is never used reentrantly. It is only ever locked using the `LockGuard`, never with `raw_lock`.

2. As a `Box`ed variable. In this case, both `init()` and `destroy()` are called, it will be moved and possibly used reentrantly.

No other combinations are used anywhere in `std`.

This change simplifies things by splitting this `Mutex` type into two types matching the two use cases: `StaticMutex` and `MovableMutex`.

The interface of both new types is now both safer and simpler. The first one does not call nor expose `init`/`destroy`, and the second one calls those automatically in its `new()` and `Drop` functions. Also, the locking functions of `MovableMutex` are no longer unsafe.

---

This will also make it easier to conditionally box mutexes later, by moving that decision into sys/sys_common. Some of the mutex implementations (at least those of Wasm and 'sys/unsupported') are safe to move, so wouldn't need a box. ~~(But that's blocked on  #76932 for now.)~~ (See #77380.)
2020-10-02 08:25:15 +09:00
..
cloudabi Make raw standard stream constructors const 2020-08-21 13:17:20 +02:00
hermit Split sys_common::Mutex in StaticMutex and MovableMutex. 2020-09-27 10:05:56 +02:00
sgx Prefer asm! in std - all in sgx module 2020-09-28 13:08:34 +00:00
unix Rollup merge of #77147 - fusion-engineering-forks:static-mutex, r=dtolnay 2020-10-02 08:25:15 +09:00
unsupported Consolidate wasi::process and unsupported::process 2020-09-15 07:01:13 -07:00
vxworks Rollup merge of #77147 - fusion-engineering-forks:static-mutex, r=dtolnay 2020-10-02 08:25:15 +09:00
wasi spend another CI build to delete a double newline 2020-09-20 14:04:23 +02:00
wasm Consolidate byte-identical modules. 2020-09-15 07:01:07 -07:00
windows Work around potential merging/duplication issues in sys/windows/compat. 2020-10-01 16:52:11 +02:00
mod.rs mv std libs to library/ 2020-07-27 19:51:13 -05:00