rust/compiler/rustc_borrowck/src
Matthias Krüger 21e7463bf8
Rollup merge of #112019 - jieyouxu:issue-111554, r=compiler-errors
Don't suggest changing `&self` and `&mut self` in function signature to be mutable when taking `&mut self` in closure

Current suggestion for when taking a mutable reference to `self` in a closure (as an upvar) will produce a machine-applicable suggestion to change the `self` in the function signature to `mut self`, but does not account for the specialness of implicit self in that it can already have `&` and `&mut` (see #111554). This causes the function signature to become `test(&mut mut self)` which does not seem desirable.

```
error[E0596]: cannot borrow `self` as mutable, as it is not declared as mutable
   --> src/sound_player.rs:870:11
    |
869 |     pub fn test(&mut self) {
    |                      ---- help: consider changing this to be mutable: `mut self`
870 |     || test2(&mut self);
    |              ^^^^^^^^^ cannot borrow as mutable
```

This PR suppresses the "changing this to be mutable" suggestion if the implicit self is either `ImplicitSelfKind::ImmRef` or `ImplicitSelfKind::MutRef`.

Fixes #111554.
2023-06-06 12:00:33 +02:00
..
constraints Split {Idx, IndexVec, IndexSlice} into their own modules 2023-04-24 13:53:35 +00:00
diagnostics Rollup merge of #112019 - jieyouxu:issue-111554, r=compiler-errors 2023-06-06 12:00:33 +02:00
region_infer Rollup merge of #111980 - compiler-errors:unmapped-substs, r=lcnr 2023-06-01 11:09:43 +05:30
type_check Rollup merge of #111980 - compiler-errors:unmapped-substs, r=lcnr 2023-06-01 11:09:43 +05:30
util Move some utils out of rustc_const_eval 2023-04-16 12:05:54 +02:00
borrow_set.rs Allow consumers to retrieve borrowck output 2023-05-23 13:11:23 +02:00
borrowck_errors.rs Add #[track_caller] to struct_span_err_with_code (drive-by cleanup) 2023-04-19 19:10:37 +00:00
constraint_generation.rs Remove ToRegionVid. 2023-04-13 12:20:41 +10:00
consumers.rs Move DefiningAnchor 2023-05-25 03:21:21 +00:00
dataflow.rs Auto merge of #111925 - Manishearth:rollup-z6z6l2v, r=Manishearth 2023-05-25 00:33:43 +00:00
def_use.rs unique borrows are mutating uses 2023-05-29 17:15:48 +02:00
facts.rs Various minor Idx-related tweaks 2023-04-16 02:42:50 -07:00
invalidation.rs Remove DesugaringKind::Replace. 2023-05-25 17:40:46 +00:00
lib.rs Remove DesugaringKind::Replace. 2023-05-25 17:40:46 +00:00
location.rs Split {Idx, IndexVec, IndexSlice} into their own modules 2023-04-24 13:53:35 +00:00
member_constraints.rs remove unused muts 2023-04-28 20:19:48 +02:00
nll.rs Rename tcx.mk_re_* => Region::new_* 2023-05-29 17:54:53 +00:00
path_utils.rs Move mir::Fieldabi::FieldIdx 2023-03-28 22:22:37 -07:00
place_ext.rs Allow consumers to retrieve borrowck output 2023-05-23 13:11:23 +02:00
places_conflict.rs Allow consumers to retrieve borrowck output 2023-05-23 13:11:23 +02:00
prefixes.rs lint auto pass 2022-11-09 20:42:16 +08:00
renumber.rs check array type of repeat exprs is wf 2023-05-04 11:22:40 +01:00
session_diagnostics.rs Don't call await a method 2023-04-27 17:18:12 +00:00
universal_regions.rs Rename tcx.mk_re_* => Region::new_* 2023-05-29 17:54:53 +00:00
used_muts.rs Rollup merge of #108856 - Zeegomo:remove-drop-and-rep, r=tmiasko 2023-03-08 21:26:51 +01:00