Christopher Serr 2e8c1d13ad Don't filter code suggestions on Applicability ... I've noticed that there are various suggestions that rust-analyzer seems to filter out, even if they make sense. Here's an example of where it seems like there should be a suggestion, but there isn't:  It turns out that this specific suggestion is not considered `MachineApplicable`, which are the only suggestions that rust-analyzer accepts. However if you read the documentation for `MachineApplicable`, b3897e3d13/compiler/rustc_lint_defs/src/lib.rs (L27-L29) then you realize that these are specifically only those suggestions that rust-analyzer could even automatically apply (in some distant future, behind some setting or so). Other suggestions that may have some semantic impact do not use `MachineApplicable`. So all other suggestions are still intended to be suggested to the user, just not automatically applied without the user being consulted. b3897e3d13/compiler/rustc_lint_defs/src/lib.rs (L22-L24) So with that in mind, rust-analyzer should almost definitely not filter out `MaybeIncorrect` (which honestly is named horribly, it just means that it's a semantic change, not just a syntactical one). Then there's `HasPlaceholders` which basically is just another semantic one, but with placeholders. The user will have to make some adjustments, but the suggestion still is perfectly valid. rust-analyzer could probably detect those placeholders and put proper "tab through" markers there for the IDE, but that's not necessary for now. Then the last one is `Unspecified` which is so unknown that I don't even know how to judge it, meaning that the suggestion should probably also just be suggested to the user and then they can decide. So with all that in mind, I'm proposing to get rid of the check for Applicability entirely.		2021-02-01 16:57:04 +01:00
..
src	Don't filter code suggestions on Applicability	2021-02-01 16:57:04 +01:00
tests/rust-analyzer	Simplify heavy tests	2021-01-28 19:15:49 +03:00
build.rs	Fix fmt	2020-06-19 02:25:07 +08:00
Cargo.toml	Make always-assert crate reusable	2021-01-26 22:13:42 +03:00