ac0a11a8bc
An `if … { … } else { … }` used as the left operand of a binary
expression requires parentheses to be parsed as an expression.
50 lines
2.2 KiB
Rust
50 lines
2.2 KiB
Rust
#![warn(clippy::obfuscated_if_else)]
|
|
#![allow(clippy::unnecessary_lazy_evaluations, clippy::unit_arg, clippy::unused_unit)]
|
|
|
|
fn main() {
|
|
true.then_some("a").unwrap_or("b");
|
|
//~^ ERROR: this method chain can be written more clearly with `if .. else ..`
|
|
true.then(|| "a").unwrap_or("b");
|
|
//~^ ERROR: this method chain can be written more clearly with `if .. else ..`
|
|
|
|
let a = 1;
|
|
(a == 1).then_some("a").unwrap_or("b");
|
|
//~^ ERROR: this method chain can be written more clearly with `if .. else ..`
|
|
(a == 1).then(|| "a").unwrap_or("b");
|
|
//~^ ERROR: this method chain can be written more clearly with `if .. else ..`
|
|
|
|
let partial = (a == 1).then_some("a");
|
|
partial.unwrap_or("b"); // not lint
|
|
|
|
let mut a = 0;
|
|
true.then_some(a += 1).unwrap_or(());
|
|
//~^ ERROR: this method chain can be written more clearly with `if .. else ..`
|
|
true.then_some(()).unwrap_or(a += 2);
|
|
//~^ ERROR: this method chain can be written more clearly with `if .. else ..`
|
|
}
|
|
|
|
fn issue11141() {
|
|
// Parentheses are required around the left side of a binary expression
|
|
let _ = true.then_some(40).unwrap_or(17) | 2;
|
|
//~^ ERROR: this method chain can be written more clearly with `if .. else ..`
|
|
|
|
// Parentheses are required only for the leftmost expression
|
|
let _ = true.then_some(30).unwrap_or(17) | true.then_some(2).unwrap_or(3) | true.then_some(10).unwrap_or(1);
|
|
//~^ ERROR: this method chain can be written more clearly with `if .. else ..`
|
|
|
|
// Parentheses are not required around the right side of a binary expression
|
|
let _ = 2 | true.then_some(40).unwrap_or(17);
|
|
//~^ ERROR: this method chain can be written more clearly with `if .. else ..`
|
|
|
|
// Parentheses are not required for a cast
|
|
let _ = true.then_some(42).unwrap_or(17) as u8;
|
|
//~^ ERROR: this method chain can be written more clearly with `if .. else ..`
|
|
|
|
// Parentheses are not required for a deref
|
|
let _ = *true.then_some(&42).unwrap_or(&17);
|
|
//~^ ERROR: this method chain can be written more clearly with `if .. else ..`
|
|
|
|
// Parentheses are not required for a deref followed by a cast
|
|
let _ = *true.then_some(&42).unwrap_or(&17) as u8;
|
|
//~^ ERROR: this method chain can be written more clearly with `if .. else ..`
|
|
}
|