ac0a11a8bc
An `if … { … } else { … }` used as the left operand of a binary
expression requires parentheses to be parsed as an expression.
89 lines
4.1 KiB
Text
89 lines
4.1 KiB
Text
error: this method chain can be written more clearly with `if .. else ..`
|
|
--> tests/ui/obfuscated_if_else.rs:5:5
|
|
|
|
|
LL | true.then_some("a").unwrap_or("b");
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if true { "a" } else { "b" }`
|
|
|
|
|
= note: `-D clippy::obfuscated-if-else` implied by `-D warnings`
|
|
= help: to override `-D warnings` add `#[allow(clippy::obfuscated_if_else)]`
|
|
|
|
error: this method chain can be written more clearly with `if .. else ..`
|
|
--> tests/ui/obfuscated_if_else.rs:7:5
|
|
|
|
|
LL | true.then(|| "a").unwrap_or("b");
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if true { "a" } else { "b" }`
|
|
|
|
error: this method chain can be written more clearly with `if .. else ..`
|
|
--> tests/ui/obfuscated_if_else.rs:11:5
|
|
|
|
|
LL | (a == 1).then_some("a").unwrap_or("b");
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if a == 1 { "a" } else { "b" }`
|
|
|
|
error: this method chain can be written more clearly with `if .. else ..`
|
|
--> tests/ui/obfuscated_if_else.rs:13:5
|
|
|
|
|
LL | (a == 1).then(|| "a").unwrap_or("b");
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if a == 1 { "a" } else { "b" }`
|
|
|
|
error: this method chain can be written more clearly with `if .. else ..`
|
|
--> tests/ui/obfuscated_if_else.rs:20:5
|
|
|
|
|
LL | true.then_some(a += 1).unwrap_or(());
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if true { a += 1 } else { () }`
|
|
|
|
error: this method chain can be written more clearly with `if .. else ..`
|
|
--> tests/ui/obfuscated_if_else.rs:22:5
|
|
|
|
|
LL | true.then_some(()).unwrap_or(a += 2);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if true { () } else { a += 2 }`
|
|
|
|
error: this method chain can be written more clearly with `if .. else ..`
|
|
--> tests/ui/obfuscated_if_else.rs:28:13
|
|
|
|
|
LL | let _ = true.then_some(40).unwrap_or(17) | 2;
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(if true { 40 } else { 17 })`
|
|
|
|
error: this method chain can be written more clearly with `if .. else ..`
|
|
--> tests/ui/obfuscated_if_else.rs:32:13
|
|
|
|
|
LL | let _ = true.then_some(30).unwrap_or(17) | true.then_some(2).unwrap_or(3) | true.then_some(10).unwrap_or(1);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(if true { 30 } else { 17 })`
|
|
|
|
error: this method chain can be written more clearly with `if .. else ..`
|
|
--> tests/ui/obfuscated_if_else.rs:32:48
|
|
|
|
|
LL | let _ = true.then_some(30).unwrap_or(17) | true.then_some(2).unwrap_or(3) | true.then_some(10).unwrap_or(1);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if true { 2 } else { 3 }`
|
|
|
|
error: this method chain can be written more clearly with `if .. else ..`
|
|
--> tests/ui/obfuscated_if_else.rs:32:81
|
|
|
|
|
LL | let _ = true.then_some(30).unwrap_or(17) | true.then_some(2).unwrap_or(3) | true.then_some(10).unwrap_or(1);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if true { 10 } else { 1 }`
|
|
|
|
error: this method chain can be written more clearly with `if .. else ..`
|
|
--> tests/ui/obfuscated_if_else.rs:36:17
|
|
|
|
|
LL | let _ = 2 | true.then_some(40).unwrap_or(17);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if true { 40 } else { 17 }`
|
|
|
|
error: this method chain can be written more clearly with `if .. else ..`
|
|
--> tests/ui/obfuscated_if_else.rs:40:13
|
|
|
|
|
LL | let _ = true.then_some(42).unwrap_or(17) as u8;
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if true { 42 } else { 17 }`
|
|
|
|
error: this method chain can be written more clearly with `if .. else ..`
|
|
--> tests/ui/obfuscated_if_else.rs:44:14
|
|
|
|
|
LL | let _ = *true.then_some(&42).unwrap_or(&17);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if true { &42 } else { &17 }`
|
|
|
|
error: this method chain can be written more clearly with `if .. else ..`
|
|
--> tests/ui/obfuscated_if_else.rs:48:14
|
|
|
|
|
LL | let _ = *true.then_some(&42).unwrap_or(&17) as u8;
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `if true { &42 } else { &17 }`
|
|
|
|
error: aborting due to 14 previous errors
|
|
|