user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
rust/crates
History
bors[bot] 4abdf323af
Merge #5732 
5732: Consider only IdentPats for param name hints r=matklad a=SomeoneToIgnore

Closes https://github.com/rust-analyzer/rust-analyzer/issues/4960

Avoid displaying any param name hints like 
<img width="590" alt="image" src="https://user-images.githubusercontent.com/2690773/90071461-47a4ad80-dcfe-11ea-9330-fb4f4e2d1b71.png">

Those hints seem to occupy plenty of space for no apparent benefit, with their destructured content not used in the code with the function hints.

I'm not entirely sure if we should show something else than `IdentPat`s, since I don't understand some of the `Pat` variant meanings:
a1c187eef3/crates/syntax/src/ast/generated/nodes.rs (L1336-L1352)

Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
2020-08-13 10:20:59 +00:00
..
arena Rename ra_arena 2020-08-12 16:22:05 +02:00
cfg Rename ra_cfg -> cfg 2020-08-13 10:36:04 +02:00
expect Fix clippy warnings 2020-08-10 15:05:01 +03:00
flycheck Rename ra_toolchain -> toolchain 2020-08-12 16:52:28 +02:00
mbe Rename ra_mbe -> mbe 2020-08-13 10:36:04 +02:00
parser Rename ra_syntax -> syntax 2020-08-12 18:30:53 +02:00
paths Add a license field to all the crates 2020-07-14 10:57:26 +09:00
proc_macro_srv Rename ra_mbe -> mbe 2020-08-13 10:36:04 +02:00
profile Rename ra_prof -> profile 2020-08-12 16:35:29 +02:00
project_model Rename ra_project_model -> project_model 2020-08-13 12:05:30 +02:00
ra_assists Remove ra_fmt crate 2020-08-13 11:59:42 +02:00
ra_db Rename ra_cfg -> cfg 2020-08-13 10:36:04 +02:00
ra_hir Rename ra_syntax -> syntax 2020-08-12 18:30:53 +02:00
ra_hir_def fmt 2020-08-13 10:36:04 +02:00
ra_hir_expand Rename ra_mbe -> mbe 2020-08-13 10:36:04 +02:00
ra_hir_ty Rename ra_syntax -> syntax 2020-08-12 18:30:53 +02:00
ra_ide Merge #5732 2020-08-13 10:20:59 +00:00
ra_ide_db Rename ra_syntax -> syntax 2020-08-12 18:30:53 +02:00
ra_proc_macro Rename ra_tt -> tt 2020-08-12 16:46:54 +02:00
ra_ssr Rename ra_syntax -> syntax 2020-08-12 18:30:53 +02:00
rust-analyzer Rename ra_project_model -> project_model 2020-08-13 12:05:30 +02:00
stdx Replace SepBy with Itertools 2020-08-12 15:04:06 +02:00
syntax Remove deprecated function 2020-08-13 11:37:54 +02:00
test_utils Use split_once polyfill 2020-07-30 22:23:12 +02:00
text_edit Rename ra_text_edit -> text_edit 2020-08-12 17:03:06 +02:00
toolchain Rename ra_toolchain -> toolchain 2020-08-12 16:52:28 +02:00
tt Rename ra_tt -> tt 2020-08-12 16:46:54 +02:00
vfs Revert style preference-related fixes 2020-08-12 14:08:55 +03:00
vfs-notify Simplify exclusion logic 2020-07-18 16:40:10 +02:00