user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
rust/src/test/ui/resolve
History
bors d95745e5fa Auto merge of #85427 - ehuss:fix-use-placement, r=jackh726 
Fix use placement for suggestions near main.

This fixes an edge case for the suggestion to add a `use`. When running with `--test`, the `main` function will be annotated with an `#[allow(dead_code)]` attribute. The `UsePlacementFinder` would end up using the dummy span of that synthetic attribute. If there are top-level inner attributes, this would place the `use` in the wrong position. The solution here is to ignore attributes with dummy spans.

In the process of working on this, I discovered that the `use_suggestion_placement` test was broken. `UsePlacementFinder` is unaware of active attributes. Attributes like `#[derive]` don't exist in the AST since they are removed. Fixing that is difficult, since the AST does not retain enough information. I considered trying to place the `use` towards the top of the module after any `extern crate` items, but I couldn't find a way to get a span for the start of a module block (the `mod` span starts at the `mod` keyword, and it seems tricky to find the spot just after the opening bracket and past inner attributes). For now, I just put some comments about the issue. This appears to have been a known issue in #44215 where the test for it was introduced, and the fix seemed to be deferred to later.
2021-06-24 14:56:28 +00:00
..
auxiliary detect when suggested paths enter extern crates more rigorously 2021-04-11 23:44:54 +01:00
associated-fn-called-as-fn.rs Suggest calling associated fn inside traits 2020-10-26 16:31:11 -07:00
associated-fn-called-as-fn.stderr Suggest calling associated fn inside traits 2020-10-26 16:31:11 -07:00
bad-env-capture.rs Move some tests to more reasonable directories - 6 2021-04-17 18:53:54 -03:00
bad-env-capture.stderr Move some tests to more reasonable directories - 6 2021-04-17 18:53:54 -03:00
bad-env-capture2.rs Move some tests to more reasonable directories - 6 2021-04-17 18:53:54 -03:00
bad-env-capture2.stderr Move some tests to more reasonable directories - 6 2021-04-17 18:53:54 -03:00
bad-env-capture3.rs Move some tests to more reasonable directories - 6 2021-04-17 18:53:54 -03:00
bad-env-capture3.stderr Move some tests to more reasonable directories - 6 2021-04-17 18:53:54 -03:00
bad-expr-path.rs Move some tests to more reasonable directories - 6 2021-04-17 18:53:54 -03:00
bad-expr-path.stderr Move some tests to more reasonable directories - 6 2021-04-17 18:53:54 -03:00
bad-expr-path2.rs Move some tests to more reasonable directories - 6 2021-04-17 18:53:54 -03:00
bad-expr-path2.stderr Move some tests to more reasonable directories - 6 2021-04-17 18:53:54 -03:00
bad-module.rs Move some tests to more reasonable directories - 6 2021-04-17 18:53:54 -03:00
bad-module.stderr Move some tests to more reasonable directories - 6 2021-04-17 18:53:54 -03:00
bad-type-env-capture.rs Move some tests to more reasonable directories - 6 2021-04-17 18:53:54 -03:00
bad-type-env-capture.stderr Move some tests to more reasonable directories - 6 2021-04-17 18:53:54 -03:00
block-with-trait-parent.rs resolve: Adjust hygienic_lexical_parent to account for enum and trait modules 2019-09-07 17:42:24 +03:00
crate-called-as-function.rs Add tests for resolution changes 2021-01-18 14:01:09 +01:00
crate-called-as-function.stderr Add tests for resolution changes 2021-01-18 14:01:09 +01:00
enums-are-namespaced-xc.rs Point at local similarly named element and tweak references to variants 2019-10-27 11:50:43 -07:00
enums-are-namespaced-xc.stderr reword "possible candidate" import suggestion 2020-05-07 00:33:25 -04:00
extern-prelude-fail.rs Move some tests to subdirectories 2020-12-07 02:25:09 +03:00
extern-prelude-fail.stderr Move some tests to subdirectories 2020-12-07 02:25:09 +03:00
extern-prelude.rs Move some tests to subdirectories 2020-12-07 02:25:09 +03:00
impl-items-vis-unresolved.rs Appease tidy 2020-01-12 15:37:50 +00:00
impl-items-vis-unresolved.stderr Update output-default.json and rustdoc test 2020-01-12 15:37:50 +00:00
issue-2330.rs Move some tests to more suitable subdirs 2021-03-06 18:24:53 +09:00
issue-2330.stderr Move some tests to more suitable subdirs 2021-03-06 18:24:53 +09:00
issue-2356.rs Remove licenses 2018-12-25 21:08:33 -07:00
issue-2356.stderr Suggest calling associated fn inside traits 2020-10-26 16:31:11 -07:00
issue-3907-2.rs Update ui test suite to use dyn 2019-05-29 00:57:31 -04:00
issue-3907-2.stderr review comments 2020-10-20 09:26:15 -07:00
issue-3907.rs Update ui test suite to use dyn 2019-05-29 00:57:31 -04:00
issue-3907.stderr Add a suggestion when using a type alias instead of trait alias 2021-04-01 09:53:46 +09:00
issue-5035-2.rs Update ui test suite to use dyn 2019-05-29 00:57:31 -04:00
issue-5035-2.stderr fix suggestion for unsized function parameters 2021-04-19 20:06:19 +02:00
issue-5035.rs Update ui test suite to use dyn 2019-05-29 00:57:31 -04:00
issue-5035.stderr Add a suggestion when using a type alias instead of trait alias 2021-04-01 09:53:46 +09:00
issue-6702.rs Point at local similarly named element and tweak references to variants 2019-10-27 11:50:43 -07:00
issue-6702.stderr Suggest struct pat on incorrect unit or tuple pat 2020-07-14 10:41:44 -07:00
issue-10200.rs Move some tests to more reasonable directories 2021-01-11 19:49:51 -03:00
issue-10200.stderr Move some tests to more reasonable directories 2021-01-11 19:49:51 -03:00
issue-14254.rs Remove licenses 2018-12-25 21:08:33 -07:00
issue-14254.stderr Suggest calling associated fn inside traits 2020-10-26 16:31:11 -07:00
issue-16058.rs Ignore SGX on a few ui tests 2020-05-05 19:19:39 -07:00
issue-16058.stderr reword "possible candidate" import suggestion 2020-05-07 00:33:25 -04:00
issue-17518.rs Remove licenses 2018-12-25 21:08:33 -07:00
issue-17518.stderr reword "possible candidate" import suggestion 2020-05-07 00:33:25 -04:00
issue-18252.rs Point at local similarly named element and tweak references to variants 2019-10-27 11:50:43 -07:00
issue-18252.stderr Suggest struct pat on incorrect unit or tuple pat 2020-07-14 10:41:44 -07:00
issue-19452.rs Moved issue tests to subdirs and normalised names. 2019-03-14 01:00:49 +00:00
issue-19452.stderr Point at item definition in foreign crates 2020-08-10 12:04:10 -07:00
issue-21221-1.rs Remove licenses 2018-12-25 21:08:33 -07:00
issue-21221-1.stderr Prefer accessible paths in 'use' suggestions 2020-06-21 18:49:39 +03:00
issue-21221-2.rs Remove licenses 2018-12-25 21:08:33 -07:00
issue-21221-2.stderr Add re-exports to use suggestions 2020-06-23 13:37:50 +03:00
issue-21221-3.rs Remove licenses 2018-12-25 21:08:33 -07:00
issue-21221-3.stderr reword "possible candidate" import suggestion 2020-05-07 00:33:25 -04:00
issue-21221-4.rs Remove licenses 2018-12-25 21:08:33 -07:00
issue-21221-4.stderr reword "possible candidate" import suggestion 2020-05-07 00:33:25 -04:00
issue-22692.rs Remove licenses 2018-12-25 21:08:33 -07:00
issue-22692.stderr Deduplicate code for path suggestion 2019-03-24 19:43:02 -07:00
issue-23305.rs Update ui test suite to use dyn 2019-05-29 00:57:31 -04:00
issue-23305.stderr Add descriptions for all queries 2020-05-31 20:15:32 +01:00
issue-24968.rs Remove licenses 2018-12-25 21:08:33 -07:00
issue-24968.stderr Remove licenses 2018-12-25 21:08:33 -07:00
issue-33876.rs Update ui test suite to use dyn 2019-05-29 00:57:31 -04:00
issue-33876.stderr Update ui test suite to use dyn 2019-05-29 00:57:31 -04:00
issue-39226.rs Remove licenses 2018-12-25 21:08:33 -07:00
issue-39226.stderr Tweak ordering of suggestions 2020-08-10 12:04:10 -07:00
issue-49074.rs Move some tests to subdirectories 2020-12-07 02:25:09 +03:00
issue-49074.stderr Move some tests to subdirectories 2020-12-07 02:25:09 +03:00
issue-50599.rs Move some tests to more reasonable directories 2021-01-31 19:46:46 -03:00
issue-50599.stderr Move some tests to more reasonable directories 2021-01-31 19:46:46 -03:00
issue-54379.rs Do not complain about unmentioned fields in recovered patterns 2019-03-14 18:28:24 -07:00
issue-54379.stderr Fix span for incorrect pattern field and add label 2020-10-02 00:44:16 -07:00
issue-57523.rs Use check-pass in ui tests where appropriate 2019-11-04 16:03:46 +01:00
issue-65025-extern-static-parent-generics.rs resolve: prohibit foreign statics w/ generics 2019-10-08 18:46:24 +01:00
issue-65025-extern-static-parent-generics.stderr resolve: prohibit foreign statics w/ generics 2019-10-08 18:46:24 +01:00
issue-65035-static-with-parent-generics.rs adjust tests 2020-05-09 14:40:17 +02:00
issue-65035-static-with-parent-generics.stderr update tests 2020-12-26 18:24:10 +01:00
issue-69401-trait-fn-no-body-ty-local.rs late resolve, visit_fn: bail early if there's no body. 2020-02-28 07:58:37 +01:00
issue-69401-trait-fn-no-body-ty-local.stderr late resolve, visit_fn: bail early if there's no body. 2020-02-28 07:58:37 +01:00
issue-70736-async-fn-no-body-def-collector.rs def_collector, visit_fn: account for no body 2020-04-03 17:01:21 +02:00
issue-70736-async-fn-no-body-def-collector.stderr clarifies error when finding mismatched returned types for async functions 2021-02-24 18:46:54 -08:00
issue-80079.rs detect when suggested paths enter extern crates more rigorously 2021-04-11 23:44:54 +01:00
issue-80079.stderr detect when suggested paths enter extern crates more rigorously 2021-04-11 23:44:54 +01:00
issue-81508.rs Fixed diagnostic and added test for issue 81508 2021-04-01 22:55:47 -04:00
issue-81508.stderr Added additional comments and minor edits 2021-04-07 12:35:39 -04:00
issue-82156.rs Fix popping singleton paths in when generating E0433 2021-02-18 19:13:40 +03:00
issue-82156.stderr Fix popping singleton paths in when generating E0433 2021-02-18 19:13:40 +03:00
issue-82865.rs Add a regression test for issue-82865 2021-03-30 07:34:49 +09:00
issue-82865.stderr Show macro name in 'this error originates in macro' message 2021-05-12 19:03:06 -04:00
issue-85348.rs Disallow shadowing const parameters 2021-05-19 18:51:42 +02:00
issue-85348.stderr Disallow shadowing const parameters 2021-05-19 18:51:42 +02:00
levenshtein.rs tests: remove ignore directives from tests that mention core/alloc/std spans. 2020-04-02 11:48:34 +03:00
levenshtein.stderr mv std libs to library/ 2020-07-27 19:51:13 -05:00
macro-determinacy-non-module.rs resolve: Do not put macros into module.unexpanded_invocations unless necessary 2020-11-22 14:42:29 +03:00
missing-in-namespace.rs Add tests for resolution changes 2021-01-18 14:01:09 +01:00
missing-in-namespace.stderr Add tests for resolution changes 2021-01-18 14:01:09 +01:00
name-clash-nullary.rs Remove licenses 2018-12-25 21:08:33 -07:00
name-clash-nullary.stderr pretty: trim paths of unique symbols 2020-09-02 22:26:37 +03:00
no-implicit-prelude.rs Move some tests to more reasonable directories - 5 2021-03-20 11:41:24 -03:00
no-implicit-prelude.stderr Move some tests to more reasonable directories - 5 2021-03-20 11:41:24 -03:00
privacy-enum-ctor.rs Remove licenses 2018-12-25 21:08:33 -07:00
privacy-enum-ctor.stderr resolve: suggest variants with placeholders 2020-10-15 17:57:57 +01:00
privacy-struct-ctor.rs resolve: fix error title regarding private constructors 2019-10-11 18:09:23 +03:00
privacy-struct-ctor.stderr Suggest struct pat on incorrect unit or tuple pat 2020-07-14 10:41:44 -07:00
raw-ident-in-path.rs diagnostics: Differentiate between edition meanings of ::foo in resolve diagnostics for ::foo::Bar 2021-03-07 14:24:47 -08:00
raw-ident-in-path.stderr diagnostics: Differentiate between edition meanings of ::foo in resolve diagnostics for ::foo::Bar 2021-03-07 14:24:47 -08:00
resolve-assoc-suggestions.rs Point at local similarly named element and tweak references to variants 2019-10-27 11:50:43 -07:00
resolve-assoc-suggestions.stderr Suggest calling associated fn inside traits 2020-10-26 16:31:11 -07:00
resolve-bad-import-prefix.rs Remove licenses 2018-12-25 21:08:33 -07:00
resolve-bad-import-prefix.stderr Update tests 2019-03-11 23:10:26 +03:00
resolve-bad-visibility.rs resolve: Move late resolution into a separate visitor 2019-08-10 13:15:15 +03:00
resolve-bad-visibility.stderr Update ui tests 2019-10-30 14:49:53 +01:00
resolve-conflict-extern-crate-vs-extern-crate.rs Remove lint annotations in specific crates that are already enforced by rustbuild 2019-07-28 18:46:24 +03:00
resolve-conflict-extern-crate-vs-extern-crate.stderr Remove lint annotations in specific crates that are already enforced by rustbuild 2019-07-28 18:46:24 +03:00
resolve-conflict-import-vs-extern-crate.rs Remove licenses 2018-12-25 21:08:33 -07:00
resolve-conflict-import-vs-extern-crate.stderr Update tests 2019-03-11 23:10:26 +03:00
resolve-conflict-import-vs-import.fixed Audit uses of tool_only_span_suggestion 2020-07-02 15:18:33 +09:00
resolve-conflict-import-vs-import.rs Audit uses of tool_only_span_suggestion 2020-07-02 15:18:33 +09:00
resolve-conflict-import-vs-import.stderr Audit uses of tool_only_span_suggestion 2020-07-02 15:18:33 +09:00
resolve-conflict-item-vs-extern-crate.rs Remove licenses 2018-12-25 21:08:33 -07:00
resolve-conflict-item-vs-extern-crate.stderr Update tests 2019-03-11 23:10:26 +03:00
resolve-conflict-item-vs-import.rs Remove licenses 2018-12-25 21:08:33 -07:00
resolve-conflict-item-vs-import.stderr Remove licenses 2018-12-25 21:08:33 -07:00
resolve-conflict-type-vs-import.rs Remove licenses 2018-12-25 21:08:33 -07:00
resolve-conflict-type-vs-import.stderr Remove licenses 2018-12-25 21:08:33 -07:00
resolve-hint-macro.rs Remove licenses 2018-12-25 21:08:33 -07:00
resolve-hint-macro.stderr Add missing primary label 2020-08-10 12:04:10 -07:00
resolve-inconsistent-binding-mode.rs resolve, inconsistent binding mode: tweak wording. 2020-03-04 03:58:52 +01:00
resolve-inconsistent-binding-mode.stderr resolve, inconsistent binding mode: tweak wording. 2020-03-04 03:58:52 +01:00
resolve-inconsistent-names.rs resolve, inconsistent binding mode: tweak wording. 2020-03-04 03:58:52 +01:00
resolve-inconsistent-names.stderr resolve, inconsistent binding mode: tweak wording. 2020-03-04 03:58:52 +01:00
resolve-label.rs resolve: disallow label use through closure/async 2020-07-02 13:48:32 +01:00
resolve-label.stderr resolve: disallow label use through closure/async 2020-07-02 13:48:32 +01:00
resolve-primitive-fallback.rs On mismatched argument count point at arguments 2020-02-11 12:42:00 -08:00
resolve-primitive-fallback.stderr Rework diagnostics for wrong number of generic args 2021-01-10 13:07:40 +01:00
resolve-pseudo-shadowing.rs Move some tests to subdirectories 2020-12-07 02:25:09 +03:00
resolve-self-in-impl-2.rs Remove licenses 2018-12-25 21:08:33 -07:00
resolve-self-in-impl-2.stderr hide --explain hint if error has no extended info 2019-04-18 13:29:28 -04:00
resolve-self-in-impl.rs Remove licenses 2018-12-25 21:08:33 -07:00
resolve-self-in-impl.stderr Add descriptions for all queries 2020-05-31 20:15:32 +01:00
resolve-speculative-adjustment.rs Remove licenses 2018-12-25 21:08:33 -07:00
resolve-speculative-adjustment.stderr Suggest calling associated fn inside traits 2020-10-26 16:31:11 -07:00
resolve-type-param-in-item-in-trait.rs Make name resolution handle consts in GenericParamsFromOuterFunction properly 2019-02-07 15:03:20 +01:00
resolve-type-param-in-item-in-trait.stderr Resolve inconsistency in error messages between "parameter" and "variable". 2019-04-17 13:25:07 +03:00
resolve-unknown-trait.rs Remove licenses 2018-12-25 21:08:33 -07:00
resolve-unknown-trait.stderr Remove licenses 2018-12-25 21:08:33 -07:00
resolve-variant-assoc-item.rs clarify what the item is in "not a module" error 2019-04-10 12:55:21 -04:00
resolve-variant-assoc-item.stderr clarify what the item is in "not a module" error 2019-04-10 12:55:21 -04:00
shadow-const-param.rs Disallow shadowing const parameters 2021-05-19 18:51:42 +02:00
shadow-const-param.stderr Disallow shadowing const parameters 2021-05-19 18:51:42 +02:00
suggest-path-instead-of-mod-dot-item.rs Remove licenses 2018-12-25 21:08:33 -07:00
suggest-path-instead-of-mod-dot-item.stderr Tweak ordering of suggestions 2020-08-10 12:04:10 -07:00
token-error-correct-2.rs tweak wording of mismatched delimiter errors 2020-01-03 08:40:15 -05:00
token-error-correct-2.stderr tweak wording of mismatched delimiter errors 2020-01-03 08:40:15 -05:00
token-error-correct-3.rs Drop support for cloudabi targets 2020-11-22 17:11:41 -05:00
token-error-correct-3.stderr Drop support for cloudabi targets 2020-11-22 17:11:41 -05:00
token-error-correct-4.fixed Audit uses of span_suggestion_short 2020-07-02 15:18:33 +09:00
token-error-correct-4.rs Audit uses of span_suggestion_short 2020-07-02 15:18:33 +09:00
token-error-correct-4.stderr Audit uses of span_suggestion_short 2020-07-02 15:18:33 +09:00
token-error-correct.rs tweak wording of mismatched delimiter errors 2020-01-03 08:40:15 -05:00
token-error-correct.stderr tweak wording of mismatched delimiter errors 2020-01-03 08:40:15 -05:00
tuple-struct-alias.rs Point at local similarly named element and tweak references to variants 2019-10-27 11:50:43 -07:00
tuple-struct-alias.stderr Point at local similarly named element and tweak references to variants 2019-10-27 11:50:43 -07:00
typo-suggestion-named-underscore.rs Do not suggest things named underscore 2020-02-02 04:55:37 +09:00
typo-suggestion-named-underscore.stderr Do not suggest things named underscore 2020-02-02 04:55:37 +09:00
unboxed-closure-sugar-nonexistent-trait.rs Remove licenses 2018-12-25 21:08:33 -07:00
unboxed-closure-sugar-nonexistent-trait.stderr Add a suggestion when using a type alias instead of trait alias 2021-04-01 09:53:46 +09:00
unresolved_static_type_field.rs Remove licenses 2018-12-25 21:08:33 -07:00
unresolved_static_type_field.stderr review comments: change wording 2019-04-18 18:39:56 -07:00
use_suggestion.rs Improve E0433, so that it suggests missing imports 2020-06-02 20:41:25 +02:00
use_suggestion.stderr Clarify message about unresolved use 2020-09-01 18:38:14 +01:00
use_suggestion_placement.fixed Fix use placement for suggestions near main. 2021-05-18 07:37:14 -07:00
use_suggestion_placement.rs Fix use placement for suggestions near main. 2021-05-18 07:37:14 -07:00
use_suggestion_placement.stderr Fix use placement for suggestions near main. 2021-05-18 07:37:14 -07:00
visibility-indeterminate.rs resolve: Remove ! from "cannot find" diagnostics for macros 2019-09-15 13:22:07 +03:00
visibility-indeterminate.stderr update ui tests 2019-10-31 14:27:16 +01:00