user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
rust/library/core/src
History
bors 5b74275f89 Auto merge of #142294 - GuillaumeGomez:specialize-tostring-on-128-integers, r=tgross35 
Use a distinct `ToString` implementation for `u128` and `i128`

Part of https://github.com/rust-lang/rust/issues/135543.

Follow-up of rust-lang/rust#136264.

When working on https://github.com/rust-lang/rust/pull/142098, I realized that `i128` and `u128` could also benefit from a distinct `ToString` implementation so here it.

The last commit is just me realizing that I forgot to add the format tests for `usize` and `isize`.

Here is the bench comparison:

| bench name | last nightly | with this PR | diff |
|-|-|-|-|
| bench_i128 | 29.25 ns/iter (+/- 0.66) | 17.52 ns/iter (+/- 0.7) | -40.1% |
| bench_u128 | 34.06 ns/iter (+/- 0.21) | 16.1 ns/iter (+/- 0.6) | -52.7% |

I used this code to test:

```rust
#![feature(test)]

extern crate test;

use test::{Bencher, black_box};

#[inline(always)]
fn convert_to_string<T: ToString>(n: T) -> String {
    n.to_string()
}

macro_rules! decl_benches {
    ($($name:ident: $ty:ident,)+) => {
        $(
	    #[bench]
            fn $name(c: &mut Bencher) {
                c.iter(|| convert_to_string(black_box({ let nb: $ty = 20; nb })));
            }
	)+
    }
}

decl_benches! {
    bench_u128: u128,
    bench_i128: i128,
}
```
2025-06-20 02:55:43 +00:00
..
alloc Add some track_caller info to precondition panics 2025-05-21 09:10:06 -04:00
array impl Default for array::IntoIter 2025-05-26 15:21:03 +08:00
ascii Add some track_caller info to precondition panics 2025-05-21 09:10:06 -04:00
async_iter Reformat using the new identifier sorting from rustfmt 2024-09-22 19:11:29 -04:00
bstr Replace colon with parentheses, add missing period 2025-04-21 10:48:46 -04:00
cell Rollup merge of #129334 - ChayimFriedman2:more-lazy-methods, r=Amanieu 2025-05-10 16:26:01 +02:00
char Get rid of EscapeDebugInner. 2025-06-15 22:08:41 +02:00
clone CloneToUninit: use a private specialization trait 2024-07-29 20:44:43 +03:00
cmp Use generic NonZero everywhere in core. 2024-02-22 15:17:33 +01:00
convert library/compiler: add PointeeSized bounds 2025-06-16 23:04:33 +00:00
ffi Delegate <CStr as Debug> to ByteStr 2025-06-12 12:53:14 -04:00
fmt Auto merge of #142294 - GuillaumeGomez:specialize-tostring-on-128-integers, r=tgross35 2025-06-20 02:55:43 +00:00
future update cfg(bootstrap) 2025-05-12 15:33:37 +02:00
hash library/compiler: add PointeeSized bounds 2025-06-16 23:04:33 +00:00
intrinsics library/compiler: add PointeeSized bounds 2025-06-16 23:04:33 +00:00
io Remove a panicking branch in BorrowedCursor::advance 2025-06-17 13:09:49 +02:00
iter 100% safe implementation of RepeatN 2025-06-13 22:32:15 +02:00
macros Specify the behavior of file! 2025-06-09 15:25:26 -05:00
marker Call out possibility of invariant result 2025-05-26 15:06:36 -04:00
mem Rollup merge of #141811 - mejrs:bye_locals, r=compiler-errors 2025-06-14 11:27:10 +02:00
net Add Ipv4Addr and Ipv6Addr diagnostic items 2025-05-14 09:34:25 +02:00
num chore(doctest): Remove redundant blank lines 2025-06-12 16:29:09 +09:00
ops lint: don't consider sizedness in upcastable lint 2025-06-16 23:04:33 +00:00
panic Fix Debug for Location. 2025-06-11 18:28:05 +02:00
pin centralize aliasing rules discussion in UnsafeCell docs 2025-06-07 21:57:45 +02:00
prelude update cfg(bootstrap) 2025-05-12 15:33:37 +02:00
ptr Auto merge of #142613 - workingjubilee:rollup-yuod2hg, r=workingjubilee 2025-06-17 18:14:08 +00:00
range Reformat using the new identifier sorting from rustfmt 2024-09-22 19:11:29 -04:00
slice Get rid of EscapeDebugInner. 2025-06-15 22:08:41 +02:00
str Stabilize const_eq_ignore_ascii_case 2025-06-05 07:09:16 +00:00
sync core docs: improve clarity of considerations about atomic CAS operations 2025-06-10 17:14:04 +02:00
task Rollup merge of #142158 - xizheyin:141617, r=jdonszelmann 2025-06-13 05:16:56 +02:00
unicode Remove unneeded parentheses. 2025-03-08 12:56:00 +01:00
any.rs fix missing word in comment 2025-04-16 18:53:40 -07:00
arch.rs update version placeholders 2025-05-12 15:33:30 +02:00
ascii.rs Get rid of EscapeDebugInner. 2025-06-15 22:08:41 +02:00
asserting.rs Reformat use declarations. 2024-07-29 08:26:52 +10:00
bool.rs Move select_unpredictable to the hint module 2025-04-13 01:34:25 +01:00
borrow.rs Suggest borrowing on fn argument that is impl AsRef 2024-05-09 23:25:31 +00:00
cell.rs Rename BorrowFlag type to BorrowCounter 2025-06-16 11:24:38 -04:00
clone.rs library/compiler: add PointeeSized bounds 2025-06-16 23:04:33 +00:00
cmp.rs library/compiler: add PointeeSized bounds 2025-06-16 23:04:33 +00:00
contracts.rs Apply suggestions from code review 2025-04-10 16:32:56 -07:00
default.rs Remove #[cfg(not(test))] gates in core 2025-03-06 13:21:59 -08:00
error.md Mention core's PanicInfo in error.md. 2024-06-11 15:47:00 +02:00
error.rs Remove #[cfg(not(test))] gates in core 2025-03-06 13:21:59 -08:00
escape.rs Get rid of EscapeDebugInner. 2025-06-15 22:08:41 +02:00
hint.rs Auto merge of #129658 - saethlin:spare-a-crumb, r=jhpratt 2025-05-27 22:11:53 +00:00
internal_macros.rs Use cfg_match in core 2025-03-26 14:32:35 -04:00
lib.miri.rs add 'x.py miri', and make it work for 'library/{core,alloc,std}' 2024-04-03 20:27:20 +02:00
lib.rs stabilize gai 2025-06-11 15:30:15 +01:00
marker.rs library/compiler: add PointeeSized bounds 2025-06-16 23:04:33 +00:00
option.rs Rollup merge of #142158 - xizheyin:141617, r=jdonszelmann 2025-06-13 05:16:56 +02:00
panic.rs update cfgs 2024-11-27 15:14:54 +00:00
panicking.rs update cfg(bootstrap) 2025-05-12 15:33:37 +02:00
pat.rs update cfgs 2025-04-09 12:29:59 +01:00
pin.rs Remove more library bootstrap 2025-06-02 14:46:19 -07:00
primitive.rs Reformat using the new identifier sorting from rustfmt 2024-09-22 19:11:29 -04:00
primitive_docs.rs Rollup merge of #141947 - zachs18:patch-4, r=workingjubilee,traviscross 2025-06-12 20:03:36 +02:00
random.rs random: add tracking issue, address other comments 2024-09-23 10:36:16 +02:00
range.rs update cfg(bootstrap) 2025-02-18 09:32:44 -08:00
result.rs Tracking the old name of renamed unstable library attribute 2025-06-12 19:24:11 +08:00
time.rs Split duration_constructors to get non-controversial bits out faster. 2025-05-09 22:52:39 -04:00
tuple.rs library/compiler: add PointeeSized bounds 2025-06-16 23:04:33 +00:00
ub_checks.rs Add some track_caller info to precondition panics 2025-05-21 09:10:06 -04:00
unit.rs core: Make Debug impl of raw pointers print metadata if present 2025-02-15 17:27:55 +01:00
unsafe_binder.rs Add unwrap_unsafe_binder and wrap_unsafe_binder macro operators 2024-12-12 16:29:40 +00:00