rust/crates/rust-analyzer/src
bors[bot] 89e1f97515
Merge #4207 #4253
4207: Add unwrap block assist #4156 r=matklad a=bnjjj

close issue #4156 

4253: Remove `workspaceLoaded` setting r=matklad a=eminence

The `workspaceLoaded` notification setting was originally designed to
control the display of a popup message that said:

    "workspace loaded, {} rust packages"

This popup was removed and replaced by a much sleeker message in the
VSCode status bar that provides a real-time status while loading:

    rust-analyzer: {}/{} packages

This was done as part of #3587

The change in this PR simply renames this setting from `workspaceLoaded` to
`progress` to better describe what it actually controls.  At the moment,
the only type of progress message that is controlled by this setting is
the initial load messages, but in theory other messages could also be
controlled by this setting.


Reviewer notes:

* If we didn't like the idea of causing minor breaking to user's config, we could keep the setting name as `workspaceLoaded`
* I think we can now close both #2719 and #3176 since the notification dialog in question no longer exists (actually I think you can close those issues even if you reject this PR 😄 )

Co-authored-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Co-authored-by: Andrew Chin <achin@eminence32.net>
2020-05-02 12:44:55 +00:00
..
bin Bubble up error 2020-04-24 01:38:58 +08:00
cli Convert code to text-size 2020-04-25 11:59:18 +02:00
main_loop Merge #4256 2020-05-02 09:45:37 +00:00
caps.rs Update crates 2020-05-01 18:26:42 -04:00
cargo_target_spec.rs Add cargo test to the list of Run commands 2020-04-26 10:40:34 +02:00
cli.rs add diagnostics subcommand to rust-analyzer CLI 2020-04-13 18:40:41 -07:00
config.rs Remove workspaceLoaded setting 2020-05-01 21:04:41 -04:00
conv.rs Merge #4161 2020-04-28 20:12:44 +00:00
diagnostics.rs Rename folder 2020-02-18 12:37:45 +01:00
lib.rs Check for eprintln on CI 2020-04-06 17:00:18 +02:00
main_loop.rs Remove workspaceLoaded setting 2020-05-01 21:04:41 -04:00
markdown.rs Rename folder 2020-02-18 12:37:45 +01:00
req.rs lsp-types 0.74 2020-04-26 16:05:22 -04:00
semantic_tokens.rs Make it impossible to forget to add a semantic token type / modifier 2020-04-28 17:14:05 +02:00
vfs_glob.rs Simpify workspace handling 2020-04-02 21:07:05 +03:00
world.rs Cleanup proc_macro config 2020-04-23 18:55:26 +02:00