0f5338cd90
The `restriction` group contains many lints which are not about necessarily “bad” things, but style choices — perhaps even style choices which contradict conventional Rust style — or are otherwise very situational. This results in silly wording like “Why is this bad? It isn't, but ...”, which I’ve seen confuse a newcomer at least once. To improve this situation, this commit replaces the “Why is this bad?” section heading with “Why restrict this?”, for most, but not all, restriction lints. I left alone the ones whose placement in the restriction group is more incidental. In order to make this make sense, I had to remove the “It isn't, but” texts from the contents of the sections. Sometimes further changes were needed, or there were obvious fixes to make, and I went ahead and made those changes without attempting to split them into another commit, even though many of them are not strictly necessary for the “Why restrict this?” project.
52 lines
1.5 KiB
Rust
52 lines
1.5 KiB
Rust
use clippy_utils::diagnostics::span_lint_and_help;
|
|
|
|
use clippy_utils::macros::span_is_local;
|
|
use rustc_hir::{Expr, ExprKind, MatchSource};
|
|
use rustc_lint::{LateContext, LateLintPass};
|
|
use rustc_session::declare_lint_pass;
|
|
|
|
declare_clippy_lint! {
|
|
/// ### What it does
|
|
/// Checks for expressions that use the question mark operator and rejects them.
|
|
///
|
|
/// ### Why restrict this?
|
|
/// Sometimes code wants to avoid the question mark operator because for instance a local
|
|
/// block requires a macro to re-throw errors to attach additional information to the
|
|
/// error.
|
|
///
|
|
/// ### Example
|
|
/// ```ignore
|
|
/// let result = expr?;
|
|
/// ```
|
|
///
|
|
/// Could be written:
|
|
///
|
|
/// ```ignore
|
|
/// utility_macro!(expr);
|
|
/// ```
|
|
#[clippy::version = "1.69.0"]
|
|
pub QUESTION_MARK_USED,
|
|
restriction,
|
|
"complains if the question mark operator is used"
|
|
}
|
|
|
|
declare_lint_pass!(QuestionMarkUsed => [QUESTION_MARK_USED]);
|
|
|
|
impl<'tcx> LateLintPass<'tcx> for QuestionMarkUsed {
|
|
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
|
|
if let ExprKind::Match(_, _, MatchSource::TryDesugar(_)) = expr.kind {
|
|
if !span_is_local(expr.span) {
|
|
return;
|
|
}
|
|
|
|
span_lint_and_help(
|
|
cx,
|
|
QUESTION_MARK_USED,
|
|
expr.span,
|
|
"question mark operator was used",
|
|
None,
|
|
"consider using a custom macro or match expression",
|
|
);
|
|
}
|
|
}
|
|
}
|