e1ec2d5cc9
Most notably, this commit changes the `pub use crate::*;` in that file to `use crate::*;`. This requires a lot of `use` items in other crates to be adjusted, because everything defined within `rustc_span::*` was also available via `rustc_span::source_map::*`, which is bizarre. The commit also removes `SourceMap::span_to_relative_line_string`, which is unused.
28 lines
912 B
Rust
28 lines
912 B
Rust
use clippy_utils::diagnostics::span_lint_and_sugg;
|
|
use clippy_utils::{is_expr_untyped_identity_function, is_trait_method};
|
|
use rustc_errors::Applicability;
|
|
use rustc_hir as hir;
|
|
use rustc_lint::LateContext;
|
|
use rustc_span::{sym, Span};
|
|
|
|
use super::FLAT_MAP_IDENTITY;
|
|
|
|
/// lint use of `flat_map` for `Iterators` where `flatten` would be sufficient
|
|
pub(super) fn check<'tcx>(
|
|
cx: &LateContext<'tcx>,
|
|
expr: &'tcx hir::Expr<'_>,
|
|
flat_map_arg: &'tcx hir::Expr<'_>,
|
|
flat_map_span: Span,
|
|
) {
|
|
if is_trait_method(cx, expr, sym::Iterator) && is_expr_untyped_identity_function(cx, flat_map_arg) {
|
|
span_lint_and_sugg(
|
|
cx,
|
|
FLAT_MAP_IDENTITY,
|
|
flat_map_span.with_hi(expr.span.hi()),
|
|
"use of `flat_map` with an identity function",
|
|
"try",
|
|
"flatten()".to_string(),
|
|
Applicability::MachineApplicable,
|
|
);
|
|
}
|
|
}
|