rust/tests
Philipp Krones 888067c623
Rollup merge of #5848 - Ryan1729:add-derive_ord_xor_partial_ord-lint, r=matthiaskrgr
Add derive_ord_xor_partial_ord lint

Fix #1621

Some remarks:
This PR follows the example of the analogous derive_hash_xor_partial_eq lint where possible.
I initially tried using the `match_path` function to identify `Ord` implementation like the derive_hash_xor_partial_eq lint currently does, for `Hash` implementations but that didn't work.

Specifically, the structs at the top level were getting paths that matched `&["$crate", "cmp", "Ord"]` instead of `&["std", "cmp", "Ord"]`. While trying to figure out what to do instead I saw the comment at the top of [clippy_lints/src/utils/paths.rs](f5d429cd76/clippy_lints/src/utils/paths.rs (L5)) that mentioned [this issue](https://github.com/rust-lang/rust-clippy/issues/5393) and suggested to use diagnostic items instead of hardcoded paths whenever possible. I looked for a way to identify `Ord` implementations with diagnostic items, but (possibly because this was the first time I had heard of diagnostic items,) I was unable to find one.

Eventually I tried using `get_trait_def_id` and comparing `DefId` values directly and that seems to work as expected. Maybe there's a better approach however?

changelog: new lint: derive_ord_xor_partial_ord
2020-08-04 12:06:40 +02:00
..
auxiliary Remove all copyright license headers 2019-01-08 21:46:39 +01:00
cargo Use current_dir instead of cargo_metadata 2020-02-10 16:42:50 +01:00
ui Rollup merge of #5848 - Ryan1729:add-derive_ord_xor_partial_ord-lint, r=matthiaskrgr 2020-08-04 12:06:40 +02:00
ui-cargo Merge commit '2ca58e7dda' into clippyup 2020-07-14 14:59:59 +02:00
ui-toml Merge commit '2ca58e7dda' into clippyup 2020-07-14 14:59:59 +02:00
compile-test.rs Fix ui-cargo tests in CI 2020-08-03 18:18:11 +02:00
dogfood.rs Fix error E0460 when compiled on Rustc repo 2020-02-09 19:02:27 +07:00
fmt.rs Apply review comments 2020-02-12 09:34:28 +01:00
integration.rs Explain panic on E0463 in integration tests 2020-04-13 22:12:57 +02:00
missing-test-files.rs cargo fmt 2019-06-21 16:47:34 +02:00
versioncheck.rs test(versioncheck): Use .no_deps() 2019-01-25 21:53:44 +01:00