Add `TrustedRandomAccess` specialization for `Vec::extend()` This should do roughly the same as the `TrustedLen` specialization but result in less IR by using `__iterator_get_unchecked` instead of `Iterator::for_each` Conflicting specializations are manually prioritized by grouping them under yet another helper trait.
119 lines
3.7 KiB
Rust
119 lines
3.7 KiB
Rust
use crate::alloc::Allocator;
|
|
use core::iter::{TrustedLen, TrustedRandomAccess};
|
|
use core::ptr::{self};
|
|
use core::slice::{self};
|
|
|
|
use super::{IntoIter, SetLenOnDrop, Vec};
|
|
|
|
// Specialization trait used for Vec::extend
|
|
pub(super) trait SpecExtend<T, I> {
|
|
fn spec_extend(&mut self, iter: I);
|
|
}
|
|
|
|
impl<T, I, A: Allocator> SpecExtend<T, I> for Vec<T, A>
|
|
where
|
|
I: Iterator<Item = T>,
|
|
{
|
|
default fn spec_extend(&mut self, iter: I) {
|
|
SpecExtendInner::spec_extend(self, iter);
|
|
}
|
|
}
|
|
|
|
impl<T, A: Allocator> SpecExtend<T, IntoIter<T>> for Vec<T, A> {
|
|
fn spec_extend(&mut self, mut iterator: IntoIter<T>) {
|
|
unsafe {
|
|
self.append_elements(iterator.as_slice() as _);
|
|
}
|
|
iterator.ptr = iterator.end;
|
|
}
|
|
}
|
|
|
|
impl<'a, T: 'a, I, A: Allocator + 'a> SpecExtend<&'a T, I> for Vec<T, A>
|
|
where
|
|
I: Iterator<Item = &'a T>,
|
|
T: Clone,
|
|
{
|
|
default fn spec_extend(&mut self, iterator: I) {
|
|
SpecExtend::spec_extend(self, iterator.cloned())
|
|
}
|
|
}
|
|
|
|
impl<'a, T: 'a, A: Allocator + 'a> SpecExtend<&'a T, slice::Iter<'a, T>> for Vec<T, A>
|
|
where
|
|
T: Copy,
|
|
{
|
|
fn spec_extend(&mut self, iterator: slice::Iter<'a, T>) {
|
|
let slice = iterator.as_slice();
|
|
unsafe { self.append_elements(slice) };
|
|
}
|
|
}
|
|
|
|
// Helper trait to disambiguate overlapping specializations
|
|
trait SpecExtendInner<T, I> {
|
|
fn spec_extend(&mut self, iter: I);
|
|
}
|
|
|
|
impl<T, I, A: Allocator> SpecExtendInner<T, I> for Vec<T, A>
|
|
where
|
|
I: Iterator<Item = T>,
|
|
{
|
|
default fn spec_extend(&mut self, iter: I) {
|
|
self.extend_desugared(iter)
|
|
}
|
|
}
|
|
|
|
impl<T, I, A: Allocator> SpecExtendInner<T, I> for Vec<T, A>
|
|
where
|
|
I: TrustedLen<Item = T>,
|
|
{
|
|
default fn spec_extend(&mut self, iterator: I) {
|
|
// This is the case for a TrustedLen iterator.
|
|
let (low, high) = iterator.size_hint();
|
|
if let Some(additional) = high {
|
|
debug_assert_eq!(
|
|
low,
|
|
additional,
|
|
"TrustedLen iterator's size hint is not exact: {:?}",
|
|
(low, high)
|
|
);
|
|
self.reserve(additional);
|
|
unsafe {
|
|
let mut ptr = self.as_mut_ptr().add(self.len());
|
|
let mut local_len = SetLenOnDrop::new(&mut self.len);
|
|
iterator.for_each(move |element| {
|
|
ptr::write(ptr, element);
|
|
ptr = ptr.offset(1);
|
|
// NB can't overflow since we would have had to alloc the address space
|
|
local_len.increment_len(1);
|
|
});
|
|
}
|
|
} else {
|
|
// Per TrustedLen contract a `None` upper bound means that the iterator length
|
|
// truly exceeds usize::MAX, which would eventually lead to a capacity overflow anyway.
|
|
// Since the other branch already panics eagerly (via `reserve()`) we do the same here.
|
|
// This avoids additional codegen for a fallback code path which would eventually
|
|
// panic anyway.
|
|
panic!("capacity overflow");
|
|
}
|
|
}
|
|
}
|
|
|
|
impl<T, I, A: Allocator> SpecExtendInner<T, I> for Vec<T, A>
|
|
where
|
|
I: TrustedLen<Item = T> + TrustedRandomAccess,
|
|
{
|
|
default fn spec_extend(&mut self, mut iterator: I) {
|
|
let size = iterator.size();
|
|
self.reserve(size);
|
|
|
|
// SAFETY: reserve ensured that there is sufficient capacity for the additional items.
|
|
// The loop upholds the TRA requirements by accessing each element only once.
|
|
unsafe {
|
|
let sink = self.as_mut_ptr().add(self.len());
|
|
for i in 0..size {
|
|
ptr::write(sink.add(i), iterator.__iterator_get_unchecked(i));
|
|
self.set_len(self.len() + 1);
|
|
}
|
|
}
|
|
}
|
|
}
|