user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
rust/compiler/rustc_middle
History
Matthias Krüger 2128efd87f
Rollup merge of #115313 - gurry:issue-114918-cycle-detected, r=compiler-errors 
Make `get_return_block()` return `Some` only for HIR nodes in body

Fixes #114918

The issue occurred while compiling the following input:

```rust
fn uwu() -> [(); { () }] {
    loop {}
}
```

It was caused by the code below trying to suggest a missing return type which resulted in a const eval cycle: 1bd043098e/compiler/rustc_hir_typeck/src/fn_ctxt/suggestions.rs (L68-L75)

The root cause was `get_return_block()` returning an `Fn` node for a node in the return type (i.e. the second `()` in the return type `[(); { () }]` of the input) although it is supposed to do so only for nodes that lie in the body of the function and return `None` otherwise (at least as per my understanding).

The PR fixes the issue by fixing this behaviour of `get_return_block()`.
2023-08-30 07:18:11 +02:00
..
src Rollup merge of #115313 - gurry:issue-114918-cycle-detected, r=compiler-errors 2023-08-30 07:18:11 +02:00
Cargo.toml Replace in-tree rustc_apfloat with the new version of the crate 2023-07-26 10:20:15 -04:00
messages.ftl Don't attempt to compute layout of type referencing error 2023-07-27 18:24:08 +00:00
README.md mv compiler to compiler/ 2020-08-30 18:45:07 +03:00

README.md

For more information about how rustc works, see the rustc dev guide.