bors 79d246112d Auto merge of #122048 - erikdesjardins:inbounds, r=oli-obk ... Use GEP inbounds for ZST and DST field offsets ZST field offsets have been non-`inbounds` since I made [this old layout change](https://github.com/rust-lang/rust/pull/73453/files#diff-160634de1c336f2cf325ff95b312777326f1ab29fec9b9b21d5ee9aae215ecf5). Before that, they would have been `inbounds` due to using `struct_gep`. Using `inbounds` for ZSTs likely doesn't matter for performance, but I'd like to remove the special case. DST field offsets have been non-`inbounds` since the alignment-aware DST field offset computation was first [implemented](a2557d472e (diff-04fd352da30ca186fe0bb71cc81a503d1eb8a02ca17a3769e1b95981cd20964aR1188)) in 1.6 (back then `GEPi()` would be used for `inbounds`), but I don't think there was any reason for it. Split out from #121577 / #121665. r? `@oli-obk` cc `@RalfJung` -- is there some weird situation where field offsets can't be `inbounds`? Note that it's fine for `inbounds` offsets to be one-past-the-end, so it's okay even if there's a ZST as the last field in the layout: > The base pointer has an in bounds address of an allocated object, which means that it points into an allocated object, or to its end. [(link)](https://llvm.org/docs/LangRef.html#getelementptr-instruction) For https://github.com/rust-lang/unsafe-code-guidelines/issues/93, zero-offset GEP is (now) always `inbounds`: > Note that getelementptr with all-zero indices is always considered to be inbounds, even if the base pointer does not point to an allocated object. [(link)](https://llvm.org/docs/LangRef.html#getelementptr-instruction)		2024-03-08 02:01:51 +00:00
..
back	Add arm64ec-pc-windows-msvc target	2024-03-06 17:49:37 -08:00
debuginfo	Add CoroutineClosure to TyKind, AggregateKind, UpvarArgs	2024-02-06 02:22:58 +00:00
mir	Auto merge of #122048 - erikdesjardins:inbounds, r=oli-obk	2024-03-08 02:01:51 +00:00
traits	Auto merge of #121665 - erikdesjardins:ptradd, r=nikic	2024-03-03 22:21:53 +00:00
assert_module_sources.rs	Rename all ParseSess variables/fields/lifetimes as psess.	2024-03-05 08:11:45 +11:00
base.rs	Add arm64ec-pc-windows-msvc target	2024-03-06 17:49:37 -08:00
codegen_attrs.rs	Fix misleading message when using a named constant as a struct alignment/pack	2024-03-02 23:15:39 +08:00
common.rs	move ConstValue into mir	2023-09-19 11:11:02 +02:00
errors.rs	Rename DiagnosticArg{,Map,Name,Value} as DiagArg{,Map,Name,Value}.	2024-02-28 08:55:37 +11:00
lib.rs	clean up potential_query_instability with FxIndexMap and UnordMap	2024-02-14 18:36:37 +08:00
meth.rs	cg_ssa: remove pointee types and pointercast/bitcast-of-ptr	2023-07-29 13:18:20 -04:00
mono_item.rs	Fix clippy::needless_borrow in the compiler	2023-11-21 20:13:40 +01:00
size_of_val.rs	fix computing the dynamic alignment of packed structs with dyn trait tails	2023-12-13 20:21:57 +01:00
target_features.rs	Bump indexmap	2024-02-13 21:03:34 +00:00