rust/compiler
Stuart Cook 44ffe1023c
Rollup merge of #144764 - scottmcm:tweak-impossible-discriminant-assume, r=WaffleLapkin
[codegen] assume the tag, not the relative discriminant

Address the issue mentioned in <https://github.com/llvm/llvm-project/issues/134024#issuecomment-3131782555> by changing discriminant calculation to `assume` on the originally-loaded `tag`, rather than on `cast(tag)-OFFSET`.

The previous way does make the *purpose* of the assume clearer, IMHO, since you see `assume(x != 4); if p { x } else { 4 }`, but doing it this way instead means that the `add`s optimize away in LLVM21, which is more important.  And this new way is still easily thought of as being like metadata on the load saying specifically which value is impossible.

Demo of the LLVM20 vs LLVM21 difference: <https://llvm.godbolt.org/z/n54x5Mq1T>

r? ``@nikic``
2025-08-08 12:52:50 +10:00
..
rustc rename stable_mir to rustc_public, and rustc_smir to rustc_public_bridge 2025-07-14 09:25:54 +00:00
rustc_abi Reuse sign_extend helper 2025-07-29 14:17:48 +00:00
rustc_arena Introduce Arena::try_alloc_from_iter. 2025-04-19 01:13:18 +00:00
rustc_ast Deduplicate IntTy/UintTy/FloatTy. 2025-07-31 19:56:11 +10:00
rustc_ast_ir Tidy up Cargo.toml files. 2025-07-31 19:58:04 +10:00
rustc_ast_lowering Port #[coroutine] to the new attribute system 2025-08-04 18:37:40 +02:00
rustc_ast_passes Rollup merge of #137831 - estebank:auto-trait-err, r=compiler-errors 2025-08-07 20:49:36 +10:00
rustc_ast_pretty use let chains in ast, borrowck, codegen, const_eval 2025-07-28 06:08:48 +05:00
rustc_attr_parsing Rollup merge of #143808 - JonathanBrouwer:should_panic_parser, r=jdonszelmann 2025-08-07 20:49:40 +10:00
rustc_baked_icu_data Add unreachable_pub to RUSTC_LINT_FLAGS for compiler/ crates. 2025-03-11 13:14:21 +11:00
rustc_borrowck Rollup merge of #144917 - compiler-errors:tail-call-linked-lifetimes, r=lcnr 2025-08-06 21:29:29 +02:00
rustc_builtin_macros Port #[should_panic] to the new attribute parsing infrastructure 2025-08-06 21:37:51 +02:00
rustc_codegen_cranelift Update codegen_{cranelift,gcc} and opt-dist to use build.compiletest-allow-stage0 2025-07-30 19:55:07 +08:00
rustc_codegen_gcc Revert "Preserve the .debug_gdb_scripts section" 2025-08-06 18:01:07 +00:00
rustc_codegen_llvm Auto merge of #145043 - Zalathar:rollup-3dbvdrm, r=Zalathar 2025-08-07 14:01:43 +00:00
rustc_codegen_ssa Rollup merge of #144764 - scottmcm:tweak-impossible-discriminant-assume, r=WaffleLapkin 2025-08-08 12:52:50 +10:00
rustc_const_eval Rollup merge of #145033 - nnethercote:fix-144994, r=fmease 2025-08-07 20:49:48 +10:00
rustc_data_structures Allow pretty printing paths with -Zself-profile-events=args 2025-07-25 22:24:21 +02:00
rustc_driver Remove recursion_limit increases. 2025-04-02 16:25:27 +11:00
rustc_driver_impl Tidy up Cargo.toml files. 2025-07-31 19:58:04 +10:00
rustc_error_codes Update E0562 to account for the new impl trait positions 2025-08-02 11:29:04 +02:00
rustc_error_messages Remove unused feature gates 2025-06-28 23:36:46 +00:00
rustc_errors Rollup merge of #144691 - xizheyin:suggest-confuse, r=estebank 2025-08-01 00:38:20 -04:00
rustc_expand Auto merge of #129183 - estebank:cfg-visitor, r=davidtwco 2025-08-02 05:09:31 +00:00
rustc_feature Auto merge of #145043 - Zalathar:rollup-3dbvdrm, r=Zalathar 2025-08-07 14:01:43 +00:00
rustc_fluent_macro Remove all unused feature gates from the compiler 2025-06-08 14:50:42 +00:00
rustc_fs_util Retry if creating temp fails with access denied 2025-04-25 11:28:36 +00:00
rustc_graphviz Remove #![warn(unreachable_pub)] from all compiler/ crates. 2025-03-11 13:14:21 +11:00
rustc_hashes Revert "Use workspace lints for crates in compiler/ #138084" 2025-03-10 18:12:47 +08:00
rustc_hir Rollup merge of #143808 - JonathanBrouwer:should_panic_parser, r=jdonszelmann 2025-08-07 20:49:40 +10:00
rustc_hir_analysis Fortify generic param default checks 2025-08-06 01:26:26 +02:00
rustc_hir_pretty remove rustc_attr_data_structures 2025-07-31 14:19:27 +02:00
rustc_hir_typeck Rollup merge of #144694 - compiler-errors:with-self-ty, r=SparrowLii 2025-08-04 14:58:09 +10:00
rustc_incremental Auto merge of #139758 - Zoxc:thread-local-graph, r=oli-obk 2025-05-07 12:39:54 +00:00
rustc_index Tidy up Cargo.toml files. 2025-07-31 19:58:04 +10:00
rustc_index_macros Tidy up Cargo.toml files. 2025-07-31 19:58:04 +10:00
rustc_infer Auto merge of #144677 - nnethercote:bound-const-handling, r=lcnr 2025-08-03 05:26:43 +00:00
rustc_interface coverage: Remove -Zcoverage-options=no-mir-spans 2025-08-04 13:48:40 +10:00
rustc_lexer test(lexer): Add frontmatter unit test 2025-07-10 10:25:29 -05:00
rustc_lint Rollup merge of #144601 - kornelski:cargo-fix-mismatched_lifetime_syntaxes, r=petrochenkov 2025-08-07 20:49:45 +10:00
rustc_lint_defs Rollup merge of #144369 - joshtriplett:mbe-expr-semi-deny-by-default, r=petrochenkov 2025-08-07 20:49:43 +10:00
rustc_llvm Rollup merge of #144712 - nnethercote:dedup-num-types, r=fmease 2025-07-31 17:19:39 +02:00
rustc_log Add documentation for init_logger_with_additional_layer 2025-06-12 12:11:15 +02:00
rustc_macros remove rustc_attr_data_structures 2025-07-31 14:19:27 +02:00
rustc_metadata remove rustc_attr_data_structures 2025-07-31 14:19:27 +02:00
rustc_middle Rollup merge of #144998 - dianqk:visit-no-use-proj, r=cjgillot 2025-08-06 21:29:34 +02:00
rustc_mir_build Rollup merge of #143764 - dianne:primary-binding-drop-order, r=Nadrieril,traviscross 2025-08-07 20:49:39 +10:00
rustc_mir_dataflow Rollup merge of #144478 - joshtriplett:doc-code-formatting-prep, r=Amanieu 2025-08-02 11:24:24 +02:00
rustc_mir_transform Rollup merge of #144996 - dianqk:simplifycfg-collapse_goto_chain-changed, r=cjgillot 2025-08-06 21:29:33 +02:00
rustc_monomorphize remove rustc_attr_data_structures 2025-07-31 14:19:27 +02:00
rustc_next_trait_solver we only merge candidates for trait and normalizes-to goals 2025-08-05 14:57:37 +02:00
rustc_parse Rollup merge of #144956 - fmease:gate-const-trait-syntax, r=BoxyUwU 2025-08-06 21:29:30 +02:00
rustc_parse_format update to literal-escaper-0.0.5 2025-07-08 10:16:44 +00:00
rustc_passes Rollup merge of #143808 - JonathanBrouwer:should_panic_parser, r=jdonszelmann 2025-08-07 20:49:40 +10:00
rustc_pattern_analysis Tidy up Cargo.toml files. 2025-07-31 19:58:04 +10:00
rustc_privacy Auto merge of #144554 - cjgillot:no-hir-eff-vis, r=petrochenkov 2025-08-02 09:23:36 +00:00
rustc_proc_macro Tidy up Cargo.toml files. 2025-07-31 19:58:04 +10:00
rustc_public Tidy up Cargo.toml files. 2025-07-31 19:58:04 +10:00
rustc_public_bridge Remove useless lifetime parameter. 2025-07-23 23:54:37 +00:00
rustc_query_impl Remove unused allow attrs 2025-07-07 12:58:16 +00:00
rustc_query_system remove rustc_attr_data_structures 2025-07-31 14:19:27 +02:00
rustc_resolve Introduce ModernIdent type to unify macro 2.0 hygiene handling 2025-08-06 21:19:09 +08:00
rustc_sanitizers Tidy up Cargo.toml files. 2025-07-31 19:58:04 +10:00
rustc_serialize use div_ceil instead of manual logic 2025-07-05 10:55:42 +02:00
rustc_session coverage: Simplify access to debug/testing -Zcoverage-options flags 2025-08-04 13:48:41 +10:00
rustc_span Rollup merge of #144439 - xizheyin:symbol-rs, r=petrochenkov 2025-08-07 20:49:44 +10:00
rustc_symbol_mangling Reimplement print_region in type_name.rs. 2025-08-07 12:46:33 +10:00
rustc_target Rollup merge of #138689 - jedbrown:jed/nvptx-target-feature, r=ZuseZ4 2025-08-07 20:49:36 +10:00
rustc_thread_pool Drop rust-version from rustc_thread_pool 2025-08-04 15:03:49 -07:00
rustc_trait_selection Rollup merge of #144776 - nnethercote:Printer-cleanups, r=cjgillot 2025-08-05 03:51:34 +02:00
rustc_traits Auto merge of #144446 - nnethercote:opt-region-constraints, r=lcnr 2025-08-01 04:06:21 +00:00
rustc_transmute Tidy up Cargo.toml files. 2025-07-31 19:58:04 +10:00
rustc_ty_utils Extract borrowck coroutine drop-liveness hack 2025-07-31 17:38:28 +00:00
rustc_type_ir Rollup merge of #144694 - compiler-errors:with-self-ty, r=SparrowLii 2025-08-04 14:58:09 +10:00
rustc_type_ir_macros Split TypeFolder and FallibleTypeFolder 2025-04-15 18:30:35 +00:00