rust/src/libstd
bors 94ede93467 Auto merge of #44042 - LukasKalbertodt:ascii-methods-on-instrinsics, r=alexcrichton
Copy all `AsciiExt` methods to the primitive types directly in order to deprecate it later

**EDIT:** [this PR is ready now](https://github.com/rust-lang/rust/pull/44042#issuecomment-333883548). I edited this post to reflect the current status of discussion, which is (apart from code review) pretty much settled.

---

This is my current progress in order to prepare stabilization of #39658. As discussed there (and in #39659), the idea is to deprecated `AsciiExt` and copy all methods to the type directly. Apparently there isn't really a reason to have those methods in an extension trait¹.

~~This is **work in progress**: copy&pasting code while slightly modifying the documentation isn't the most exciting thing to do. Therefore I wanted to already open this WIP PR after doing basically 1/4 of the job (copying methods to `&[u8]`, `char` and `&str` is still missing) to get some feedback before I continue. Some questions possibly worth discussing:~~

1. ~~Does everyone agree that deprecating `AsciiExt` is a good idea? Does everyone agree with the goal of this PR?~~ => apparently yes
2. ~~Are my changes OK so far? Did I do something wrong?~~
3. ~~The issue of the unstable-attribute is currently set to 0. I would wait until you say "Ok" to the whole thing, then create a tracking issue and then insert the correct issue id. Is that ok?~~
4. ~~I tweaked `eq_ignore_ascii_case()`: it now takes the argument `other: u8` instead of `other: &u8`. The latter was enforced by the trait. Since we're not bound to a trait anymore, we can drop the reference, ok?~~ => I reverted this, because the interface has to match the `AsciiExt` interface exactly.

¹ ~~Could it be that we can't write `impl [u8] {}`? This might be the reason for `AsciiExt`. If that is the case: is there a good reason we can't write such an impl block? What can we do instead?~~ => we couldn't at the time this PR was opened, but Simon made it possible.

/cc @SimonSapin @zackw
2017-11-05 11:42:59 +00:00
..
collections [test] Add some #[inline] to HashMap 2017-10-20 11:49:36 -07:00
ffi Fix most rendering warnings from switching to CommonMark 2017-10-20 15:29:35 -04:00
io Rollup merge of #45664 - mbrubeck:docs, r=estebank 2017-11-01 13:32:20 +08:00
net Improve docs for UdpSocket::set_nonblocking. 2017-10-26 10:05:54 -04:00
os Fix doc build on other architectures than linux 2017-10-24 21:58:53 +02:00
prelude Move unused-extern-crate to late pass 2017-08-27 19:02:24 +09:00
rand Introduce tidy lint to check for inconsistent tracking issues 2017-06-16 20:40:40 +02:00
sync Auto merge of #45267 - oconnor663:rwlock_send, r=alexcrichton 2017-11-01 04:32:15 +00:00
sys Auto merge of #44042 - LukasKalbertodt:ascii-methods-on-instrinsics, r=alexcrichton 2017-11-05 11:42:59 +00:00
sys_common Rollup merge of #44775 - MaloJaffre:debug-struct, r=sfackler 2017-10-10 22:43:57 +08:00
thread Auto merge of #45285 - alexcrichton:update-bootstrap, r=Mark-Simulacrum 2017-10-27 18:00:32 +00:00
time Auto merge of #44436 - MicroJoe:master, r=alexcrichton 2017-09-23 22:21:32 +00:00
ascii.rs Remove unused AsciiExt imports and fix tests related to ascii methods 2017-11-03 21:27:40 +01:00
build.rs rustbuild: Support specifying archiver and linker explicitly 2017-10-15 22:10:07 +03:00
Cargo.toml add description to libstd 2017-10-31 15:10:10 -05:00
env.rs Move global vars changing tests into run-pass 2017-06-24 18:23:39 +03:00
error.rs Merge remote-tracking branch 'upstream/master' 2017-09-30 10:08:33 -04:00
f32.rs Revert "Add clamp functions" 2017-09-08 16:07:21 -06:00
f64.rs Revert "Add clamp functions" 2017-09-08 16:07:21 -06:00
fs.rs Made fs::copy return the length of the main stream 2017-09-27 19:43:05 -07:00
heap.rs rustc: Handle some libstd symbole exports better 2017-11-04 20:01:11 -07:00
lib.rs Mark several ascii methods as unstable again 2017-11-03 21:28:04 +01:00
macros.rs fix stringify docs in std 2017-10-22 13:17:23 -04:00
memchr.rs Fix inconsistent doc headings 2017-08-24 18:42:53 +02:00
num.rs Auto merge of #40706 - irfanhudda:doc-next-power-of-two, r=alexcrichton 2017-06-08 01:07:08 +00:00
panic.rs auto trait future compatibility lint 2017-11-03 16:13:21 -02:00
panicking.rs Update bootstrap compiler 2017-08-31 06:58:58 -07:00
path.rs Copy AsciiExt methods to char directly 2017-11-03 21:27:40 +01:00
primitive_docs.rs Update array documentation for Clone trait changes 2017-10-17 08:29:29 +02:00
process.rs Auto merge of #45295 - Technius:docs/process, r=steveklabnik 2017-10-29 06:24:20 +00:00
rt.rs Update bootstrap compiler 2017-08-31 06:58:58 -07:00