rust/library/core
Guillaume Gomez 9a0ac7cb5f
Rollup merge of #82676 - dtolnay:powers, r=Mark-Simulacrum
Change twice used large const table to static

This table is used twice in core::num::dec2flt::algorithm::power_of_ten. According to the semantics of const, a separate huge definition of the table is inlined at both places.

5233edcf1c/library/core/src/num/dec2flt/algorithm.rs (L16-L22)

Theoretically this gets cleaned up by optimization passes, but in practice I am experiencing a miscompile from LTO on this code. Making the table a static, which would only be defined a single time and not require attention from LTO, eliminates the miscompile and seems semantically more appropriate anyway. A separate bug report on the LTO bug is forthcoming.

Original addition of `const` is from #27307.
2021-03-02 00:50:11 +01:00
..
benches Unify way to flip 6th bit. (Same assembly generated) 2021-02-08 12:21:36 +00:00
src Rollup merge of #82676 - dtolnay:powers, r=Mark-Simulacrum 2021-03-02 00:50:11 +01:00
tests Rollup merge of #81167 - usbalbin:const_write, r=oli-obk 2021-02-25 14:33:51 +01:00
Cargo.toml mv std libs to library/ 2020-07-27 19:51:13 -05:00