This partially implements the feature staging described in the [release channel RFC][rc]. It does not yet fully conform to the RFC as written, but does accomplish its goals sufficiently for the 1.0 alpha release. It has three primary user-visible effects: * On the nightly channel, use of unstable APIs generates a warning. * On the beta channel, use of unstable APIs generates a warning. * On the beta channel, use of feature gates generates a warning. Code that does not trigger these warnings is considered 'stable', modulo pre-1.0 bugs. Disabling the warnings for unstable APIs continues to be done in the existing (i.e. old) style, via `#[allow(...)]`, not that specified in the RFC. I deem this marginally acceptable since any code that must do this is not using the stable dialect of Rust. Use of feature gates is itself gated with the new 'unstable_features' lint, on nightly set to 'allow', and on beta 'warn'. The attribute scheme used here corresponds to an older version of the RFC, with the `#[staged_api]` crate attribute toggling the staging behavior of the stability attributes, but the user impact is only in-tree so I'm not concerned about having to make design changes later (and I may ultimately prefer the scheme here after all, with the `#[staged_api]` crate attribute). Since the Rust codebase itself makes use of unstable features the compiler and build system to a midly elaborate dance to allow it to bootstrap while disobeying these lints (which would otherwise be errors because Rust builds with `-D warnings`). This patch includes one significant hack that causes a regression. Because the `format_args!` macro emits calls to unstable APIs it would trigger the lint. I added a hack to the lint to make it not trigger, but this in turn causes arguments to `println!` not to be checked for feature gates. I don't presently understand macro expansion well enough to fix. This is bug #20661. Closes #16678 [rc]: https://github.com/rust-lang/rfcs/blob/master/text/0507-release-channels.md
187 lines
6.3 KiB
Rust
187 lines
6.3 KiB
Rust
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
|
|
// file at the top-level directory of this distribution and at
|
|
// http://rust-lang.org/COPYRIGHT.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
// option. This file may not be copied, modified, or distributed
|
|
// except according to those terms.
|
|
|
|
use ast;
|
|
use attr;
|
|
use codemap::DUMMY_SP;
|
|
use codemap;
|
|
use fold::Folder;
|
|
use fold;
|
|
use parse::token::InternedString;
|
|
use parse::token::special_idents;
|
|
use parse::token;
|
|
use ptr::P;
|
|
use util::small_vector::SmallVector;
|
|
|
|
use std::mem;
|
|
|
|
pub fn maybe_inject_crates_ref(krate: ast::Crate, alt_std_name: Option<String>)
|
|
-> ast::Crate {
|
|
if use_std(&krate) {
|
|
inject_crates_ref(krate, alt_std_name)
|
|
} else {
|
|
krate
|
|
}
|
|
}
|
|
|
|
pub fn maybe_inject_prelude(krate: ast::Crate) -> ast::Crate {
|
|
if use_std(&krate) {
|
|
inject_prelude(krate)
|
|
} else {
|
|
krate
|
|
}
|
|
}
|
|
|
|
fn use_std(krate: &ast::Crate) -> bool {
|
|
!attr::contains_name(krate.attrs.index(&FullRange), "no_std")
|
|
}
|
|
|
|
fn no_prelude(attrs: &[ast::Attribute]) -> bool {
|
|
attr::contains_name(attrs, "no_implicit_prelude")
|
|
}
|
|
|
|
struct StandardLibraryInjector<'a> {
|
|
alt_std_name: Option<String>
|
|
}
|
|
|
|
impl<'a> fold::Folder for StandardLibraryInjector<'a> {
|
|
fn fold_crate(&mut self, mut krate: ast::Crate) -> ast::Crate {
|
|
|
|
// The name to use in `extern crate "name" as std;`
|
|
let actual_crate_name = match self.alt_std_name {
|
|
Some(ref s) => token::intern_and_get_ident(s.index(&FullRange)),
|
|
None => token::intern_and_get_ident("std"),
|
|
};
|
|
|
|
let mut vis = vec!(ast::ViewItem {
|
|
node: ast::ViewItemExternCrate(token::str_to_ident("std"),
|
|
Some((actual_crate_name, ast::CookedStr)),
|
|
ast::DUMMY_NODE_ID),
|
|
attrs: vec!(
|
|
attr::mk_attr_outer(attr::mk_attr_id(), attr::mk_word_item(
|
|
InternedString::new("macro_use")))),
|
|
vis: ast::Inherited,
|
|
span: DUMMY_SP
|
|
});
|
|
|
|
// `extern crate` must be precede `use` items
|
|
mem::swap(&mut vis, &mut krate.module.view_items);
|
|
krate.module.view_items.extend(vis.into_iter());
|
|
|
|
// don't add #![no_std] here, that will block the prelude injection later.
|
|
// Add it during the prelude injection instead.
|
|
|
|
krate
|
|
}
|
|
}
|
|
|
|
fn inject_crates_ref(krate: ast::Crate, alt_std_name: Option<String>) -> ast::Crate {
|
|
let mut fold = StandardLibraryInjector {
|
|
alt_std_name: alt_std_name
|
|
};
|
|
fold.fold_crate(krate)
|
|
}
|
|
|
|
struct PreludeInjector<'a>;
|
|
|
|
impl<'a> fold::Folder for PreludeInjector<'a> {
|
|
fn fold_crate(&mut self, mut krate: ast::Crate) -> ast::Crate {
|
|
// Add #![no_std] here, so we don't re-inject when compiling pretty-printed source.
|
|
// This must happen here and not in StandardLibraryInjector because this
|
|
// fold happens second.
|
|
|
|
let no_std_attr = attr::mk_attr_inner(attr::mk_attr_id(),
|
|
attr::mk_word_item(InternedString::new("no_std")));
|
|
// std_inject runs after feature checking so manually mark this attr
|
|
attr::mark_used(&no_std_attr);
|
|
krate.attrs.push(no_std_attr);
|
|
|
|
// only add `use std::prelude::*;` if there wasn't a
|
|
// `#![no_implicit_prelude]` at the crate level.
|
|
// fold_mod() will insert glob path.
|
|
if !no_prelude(krate.attrs.index(&FullRange)) {
|
|
krate.module = self.fold_mod(krate.module);
|
|
}
|
|
krate
|
|
}
|
|
|
|
fn fold_item(&mut self, item: P<ast::Item>) -> SmallVector<P<ast::Item>> {
|
|
if !no_prelude(item.attrs.index(&FullRange)) {
|
|
// only recur if there wasn't `#![no_implicit_prelude]`
|
|
// on this item, i.e. this means that the prelude is not
|
|
// implicitly imported though the whole subtree
|
|
fold::noop_fold_item(item, self)
|
|
} else {
|
|
SmallVector::one(item)
|
|
}
|
|
}
|
|
|
|
fn fold_mod(&mut self, ast::Mod {inner, view_items, items}: ast::Mod) -> ast::Mod {
|
|
let prelude_path = ast::Path {
|
|
span: DUMMY_SP,
|
|
global: false,
|
|
segments: vec![
|
|
ast::PathSegment {
|
|
identifier: token::str_to_ident("std"),
|
|
parameters: ast::PathParameters::none(),
|
|
},
|
|
ast::PathSegment {
|
|
identifier: token::str_to_ident("prelude"),
|
|
parameters: ast::PathParameters::none(),
|
|
},
|
|
ast::PathSegment {
|
|
identifier: token::str_to_ident("v1"),
|
|
parameters: ast::PathParameters::none(),
|
|
},
|
|
],
|
|
};
|
|
|
|
let (crates, uses): (Vec<_>, _) = view_items.iter().cloned().partition(|x| {
|
|
match x.node {
|
|
ast::ViewItemExternCrate(..) => true,
|
|
_ => false,
|
|
}
|
|
});
|
|
|
|
// add prelude after any `extern crate` but before any `use`
|
|
let mut view_items = crates;
|
|
let vp = P(codemap::dummy_spanned(ast::ViewPathGlob(prelude_path, ast::DUMMY_NODE_ID)));
|
|
view_items.push(ast::ViewItem {
|
|
node: ast::ViewItemUse(vp),
|
|
attrs: vec![ast::Attribute {
|
|
span: DUMMY_SP,
|
|
node: ast::Attribute_ {
|
|
id: attr::mk_attr_id(),
|
|
style: ast::AttrOuter,
|
|
value: P(ast::MetaItem {
|
|
span: DUMMY_SP,
|
|
node: ast::MetaWord(token::get_name(
|
|
special_idents::prelude_import.name)),
|
|
}),
|
|
is_sugared_doc: false,
|
|
},
|
|
}],
|
|
vis: ast::Inherited,
|
|
span: DUMMY_SP,
|
|
});
|
|
view_items.extend(uses.into_iter());
|
|
|
|
fold::noop_fold_mod(ast::Mod {
|
|
inner: inner,
|
|
view_items: view_items,
|
|
items: items
|
|
}, self)
|
|
}
|
|
}
|
|
|
|
fn inject_prelude(krate: ast::Crate) -> ast::Crate {
|
|
let mut fold = PreludeInjector;
|
|
fold.fold_crate(krate)
|
|
}
|