rust/src/test/ui/suggestions
bors 5371ddf8c6 Auto merge of #68080 - varkor:declared-here, r=petrochenkov
Address inconsistency in using "is" with "declared here"

"is" was generally used for NLL diagnostics, but not other diagnostics. Using "is" makes the diagnostics sound more natural and readable, so it seems sensible to commit to them throughout.

r? @Centril
2020-01-31 15:13:51 +00:00
..
auxiliary tests: Add minimal reproduction of #61963. 2019-07-20 19:17:26 +01:00
dont-suggest-ref Tweak move error due to non-Copy 2019-11-25 13:30:52 -08:00
as-ref.rs Suggest .as_ref() when appropriate for Option and Result 2018-12-28 11:16:23 -08:00
as-ref.stderr Point at type in let assignment on type errors 2019-11-21 19:24:31 -08:00
assoc-const-as-field.rs Provide suggestion when using field access instead of path 2019-03-24 19:21:54 -07:00
assoc-const-as-field.stderr Deduplicate code for path suggestion 2019-03-24 19:43:02 -07:00
assoc-type-in-method-return.rs Suggest assoc type on type not found in trait method definition 2019-07-13 21:17:38 -07:00
assoc-type-in-method-return.stderr Suggest assoc type on type not found in trait method definition 2019-07-13 21:17:38 -07:00
async-fn-ctor-passed-as-arg-where-it-should-have-been-called.rs Suggest calling async closure when needed 2019-11-16 16:24:00 -08:00
async-fn-ctor-passed-as-arg-where-it-should-have-been-called.stderr Suggest calling async closure when needed 2019-11-16 16:24:00 -08:00
attribute-typos.rs Ignore platforms that can't point to std 2020-01-10 11:40:30 -08:00
attribute-typos.stderr Ignore platforms that can't point to std 2020-01-10 11:40:30 -08:00
borrow-for-loop-head.rs When moving out of a for loop head, suggest borrowing it 2019-03-24 11:46:13 -07:00
borrow-for-loop-head.stderr Suggest borrowing for loop head on move error 2019-05-24 18:23:43 -07:00
const-no-type.rs Add parser recovery for const $ident = $expr;. 2019-09-23 17:50:07 +02:00
const-no-type.stderr Add parser recovery for const $ident = $expr;. 2019-09-23 17:50:07 +02:00
const-pat-non-exaustive-let-new-var.rs Improve diagnostic for let A = 0; 2019-09-28 03:07:31 +02:00
const-pat-non-exaustive-let-new-var.stderr Improve diagnostic for let A = 0; 2019-09-28 03:07:31 +02:00
constrain-trait.fixed Unify output of "variant not found" errors 2020-01-08 08:05:31 -08:00
constrain-trait.rs Unify output of "variant not found" errors 2020-01-08 08:05:31 -08:00
constrain-trait.stderr Unify output of "variant not found" errors 2020-01-08 08:05:31 -08:00
dont-suggest-deref-inside-macro-issue-58298.rs Account for fully overlapping multiline annotations 2019-03-27 19:35:30 -07:00
dont-suggest-deref-inside-macro-issue-58298.stderr Surround types with backticks in type errors 2019-11-18 11:03:04 -08:00
dont-suggest-try_into-in-macros.rs Do not suggest try_into for base types inside of macro expansions 2019-08-15 11:46:52 -07:00
dont-suggest-try_into-in-macros.stderr Surround types with backticks in type errors 2019-11-18 11:03:04 -08:00
fn-ctor-passed-as-arg-where-it-should-have-been-called.rs Suggest calling async closure when needed 2019-11-16 16:24:00 -08:00
fn-ctor-passed-as-arg-where-it-should-have-been-called.stderr Suggest calling async closure when needed 2019-11-16 16:24:00 -08:00
fn-or-tuple-struct-with-underscore-args.rs Recover parser from foo(_, _) 2019-08-09 07:18:05 -07:00
fn-or-tuple-struct-with-underscore-args.stderr Recover parser from foo(_, _) 2019-08-09 07:18:05 -07:00
fn-or-tuple-struct-without-args.rs Suggest calling closure with resolved return type when appropriate 2019-08-23 11:59:04 -07:00
fn-or-tuple-struct-without-args.stderr review comments 2020-01-08 09:29:47 -08:00
for-i-in-vec.fixed Suggest borrowing Vec<NonCopy> in for loop 2020-01-21 11:11:00 -08:00
for-i-in-vec.rs Suggest borrowing Vec<NonCopy> in for loop 2020-01-21 11:11:00 -08:00
for-i-in-vec.stderr use diagnostic_item and modify wording 2020-01-23 11:51:56 -08:00
format-borrow.rs Suggest removal of & when borrowing macro and appropriate 2019-03-02 11:25:00 -08:00
format-borrow.stderr Point at type in let assignment on type errors 2019-11-21 19:24:31 -08:00
imm-ref-trait-object-literal.rs Note when a mutable trait object is needed 2019-10-09 10:17:29 -07:00
imm-ref-trait-object-literal.stderr Note when a mutable trait object is needed 2019-10-09 10:17:29 -07:00
imm-ref-trait-object.rs Note when a mutable trait object is needed 2019-10-09 10:17:29 -07:00
imm-ref-trait-object.stderr Tweak wording 2019-10-09 10:17:29 -07:00
impl-trait-return-trailing-semicolon.rs On return type impl Trait for block with no expr point at last semi 2019-03-04 13:17:54 -08:00
impl-trait-return-trailing-semicolon.stderr Update tests 2019-03-11 23:10:26 +03:00
impl-trait-with-missing-trait-bounds-in-arg.fixed Correctly suggest adding bounds to impl Trait argument 2019-08-22 10:15:57 -07:00
impl-trait-with-missing-trait-bounds-in-arg.rs Correctly suggest adding bounds to impl Trait argument 2019-08-22 10:15:57 -07:00
impl-trait-with-missing-trait-bounds-in-arg.stderr Unify output of "variant not found" errors 2020-01-08 08:05:31 -08:00
into-str.rs Add suggestion to use &*var when &str: From<String> is expected 2019-03-22 20:38:14 -07:00
into-str.stderr Tweak wording 2019-10-09 10:17:29 -07:00
issue-21673.rs Suggest trait bound on type parameter when it is unconstrained 2019-07-18 11:50:50 -07:00
issue-21673.stderr Unify output of "variant not found" errors 2020-01-08 08:05:31 -08:00
issue-51055-missing-semicolon-between-call-and-tuple.rs in which the E0618 "expected function" diagnostic gets a makeover 2018-11-10 22:12:33 -08:00
issue-51055-missing-semicolon-between-call-and-tuple.stderr Update tests 2019-03-11 23:10:26 +03:00
issue-52820.rs Account for short-hand init structs when suggesting conversion 2019-05-26 11:39:48 -07:00
issue-52820.stderr Surround types with backticks in type errors 2019-11-18 11:03:04 -08:00
issue-57672.rs Apply review suggestions 2019-11-06 00:00:00 +00:00
issue-59819.fixed Only make suggestion when type is Copy. 2019-04-22 19:26:24 +01:00
issue-59819.rs Only make suggestion when type is Copy. 2019-04-22 19:26:24 +01:00
issue-59819.stderr Point at type in let assignment on type errors 2019-11-21 19:24:31 -08:00
issue-61226.rs review comment: remove unecessary error in test 2019-08-13 09:01:56 -07:00
issue-61226.stderr Point at definition when misusing ADT 2019-09-22 11:27:55 -07:00
issue-61963.rs lowering: Omit bare trait lint on macro call sites 2019-07-26 17:31:39 +01:00
issue-61963.stderr Normalise notes with the/is 2020-01-24 16:24:50 +00:00
issue-62843.rs Add note suggesting to borrow a String argument to find 2019-07-25 10:11:03 -07:00
issue-62843.stderr Account for rustc_on_unimplemented 2019-11-16 13:23:19 -08:00
issue-64252-self-type.rs syntax: improve parameter without type suggestions 2019-10-02 09:51:27 +01:00
issue-64252-self-type.stderr Remove "here" from "expected one of X here" 2019-11-06 17:26:20 -08:00
issue-66968-suggest-sorted-words.rs add ui test 2020-01-04 10:58:04 -08:00
issue-66968-suggest-sorted-words.stderr add ui test 2020-01-04 10:58:04 -08:00
let-binding-init-expr-as-ty.rs Update tests for GATs 2019-12-21 12:35:28 +00:00
let-binding-init-expr-as-ty.stderr Update tests for GATs 2019-12-21 12:35:28 +00:00
match-ergonomics.rs Add if let test 2019-04-29 20:58:29 -07:00
match-ergonomics.stderr Surround types with backticks in type errors 2019-11-18 11:03:04 -08:00
match-needing-semi.fixed review comments 2019-09-28 09:56:28 -07:00
match-needing-semi.rs review comments 2019-09-28 09:56:28 -07:00
match-needing-semi.stderr Surround types with backticks in type errors 2019-11-18 11:03:04 -08:00
mismatched-types-numeric-from.rs Do not suggest .try_into() on i32::from(x) 2019-08-22 13:37:35 -07:00
mismatched-types-numeric-from.stderr Point at type in let assignment on type errors 2019-11-21 19:24:31 -08:00
missing-assoc-type-bound-restriction.rs Fix rebase 2019-10-22 13:24:30 -07:00
missing-assoc-type-bound-restriction.stderr Fix rebase 2019-10-22 13:24:30 -07:00
missing-trait-item.fixed Suggest missing item from trait in impl 2019-11-06 10:00:59 -08:00
missing-trait-item.rs Suggest missing item from trait in impl 2019-11-06 10:00:59 -08:00
missing-trait-item.stderr Suggest missing item from trait in impl 2019-11-06 10:00:59 -08:00
mut-borrow-needed-by-trait.rs Unify output of "variant not found" errors 2020-01-08 08:05:31 -08:00
mut-borrow-needed-by-trait.stderr Unify output of "variant not found" errors 2020-01-08 08:05:31 -08:00
mut-ref-reassignment.rs Add regression test for negative case 2019-05-23 10:32:01 -07:00
mut-ref-reassignment.stderr Specific labels when referring to "expected" and "found" types 2019-11-18 11:02:22 -08:00
no-extern-crate-in-type.rs filter suggestions from extern prelude 2019-03-18 11:13:15 -04:00
no-extern-crate-in-type.stderr Suggest defining type parameter when appropriate 2020-01-26 10:57:18 -08:00
opaque-type-error.rs Add backticks to various diagnostics 2020-01-05 00:17:46 +00:00
opaque-type-error.stderr review comments 2020-01-08 09:29:47 -08:00
option-content-move.fixed Update tests for changes to cannot move errors 2019-06-03 14:55:29 +01:00
option-content-move.rs Update tests for changes to cannot move errors 2019-06-03 14:55:29 +01:00
option-content-move.stderr Update tests for changes to cannot move errors 2019-06-03 14:55:29 +01:00
option-content-move2.rs Don't suggest wrong snippet in closure 2019-12-12 11:13:13 +09:00
option-content-move2.stderr Don't suggest wrong snippet in closure 2019-12-12 11:13:13 +09:00
path-by-value.rs Custom E0277 diagnostic for Path 2018-10-10 17:30:10 -07:00
path-by-value.stderr Fix broken links to second edition TRPL. 2019-01-01 12:53:07 -05:00
path-display.rs Suggest using .display() when trying to print a Path 2018-12-12 16:54:27 -08:00
path-display.stderr Wording changes 2018-12-13 09:55:16 -08:00
raw-name-use-suggestion.rs Accurately portray raw identifiers in error messages 2019-12-03 19:01:42 -08:00
raw-name-use-suggestion.stderr Accurately portray raw identifiers in error messages 2019-12-03 19:01:42 -08:00
recover-from-semicolon-trailing-item.rs Recover from item trailing semicolon 2019-01-13 17:29:32 -08:00
recover-from-semicolon-trailing-item.stderr Point at type in let assignment on type errors 2019-11-21 19:24:31 -08:00
recover-invalid-float.fixed Suggest try_into when possible 2019-04-29 14:38:26 -07:00
recover-invalid-float.rs Suggest try_into when possible 2019-04-29 14:38:26 -07:00
recover-invalid-float.stderr Suggest try_into when possible 2019-04-29 14:38:26 -07:00
remove-as_str.rs Unify output of "variant not found" errors 2020-01-08 08:05:31 -08:00
remove-as_str.stderr Unify output of "variant not found" errors 2020-01-08 08:05:31 -08:00
restrict-type-argument.rs Use structured suggestion for restricting bounds 2019-10-15 13:55:43 -07:00
restrict-type-argument.stderr Use structured suggestion for restricting bounds 2019-10-15 13:55:43 -07:00
return-without-lifetime.rs Suggest adding lifetime to struct field 2019-03-12 18:18:29 -07:00
return-without-lifetime.stderr Suggest adding lifetime to struct field 2019-03-12 18:18:29 -07:00
suggest-assoc-fn-call-with-turbofish-through-deref.rs Unify output of "variant not found" errors 2020-01-08 08:05:31 -08:00
suggest-assoc-fn-call-with-turbofish-through-deref.stderr Unify output of "variant not found" errors 2020-01-08 08:05:31 -08:00
suggest-assoc-fn-call-with-turbofish.rs Unify output of "variant not found" errors 2020-01-08 08:05:31 -08:00
suggest-assoc-fn-call-with-turbofish.stderr Unify output of "variant not found" errors 2020-01-08 08:05:31 -08:00
suggest-box.fixed Suggest Box::new when appropriate 2019-08-12 20:24:30 -07:00
suggest-box.rs Suggest Box::new when appropriate 2019-08-12 20:24:30 -07:00
suggest-box.stderr Point at type in let assignment on type errors 2019-11-21 19:24:31 -08:00
suggest-closure-return-type-1.rs Suggest giving return type to closures on E0282 2019-08-13 16:41:43 -07:00
suggest-closure-return-type-1.stderr Increase spacing for suggestions in diagnostics 2019-10-24 12:26:01 -07:00
suggest-closure-return-type-2.rs Suggest giving return type to closures on E0282 2019-08-13 16:41:43 -07:00
suggest-closure-return-type-2.stderr Increase spacing for suggestions in diagnostics 2019-10-24 12:26:01 -07:00
suggest-closure-return-type-3.rs Suggest giving return type to closures on E0282 2019-08-13 16:41:43 -07:00
suggest-closure-return-type-3.stderr Increase spacing for suggestions in diagnostics 2019-10-24 12:26:01 -07:00
suggest-impl-trait-lifetime.fixed Account for impl Trait when suggesting lifetime 2018-12-12 14:10:36 -08:00
suggest-impl-trait-lifetime.nll.stderr Change compare mode to use -Zborrowck=mir 2019-05-12 18:46:43 +01:00
suggest-impl-trait-lifetime.rs Account for impl Trait when suggesting lifetime 2018-12-12 14:10:36 -08:00
suggest-impl-trait-lifetime.stderr Account for impl Trait when suggesting lifetime 2018-12-12 14:10:36 -08:00
suggest-labels.rs Remove licenses 2018-12-25 21:08:33 -07:00
suggest-labels.stderr Increase spacing for suggestions in diagnostics 2019-10-24 12:26:01 -07:00
suggest-methods.rs Remove licenses 2018-12-25 21:08:33 -07:00
suggest-methods.stderr Unify output of "variant not found" errors 2020-01-08 08:05:31 -08:00
suggest-move-lifetimes.rs Update ui tests 2018-12-04 10:06:05 +01:00
suggest-move-lifetimes.stderr Only mention const generics if enabled. 2019-03-31 00:14:21 +01:00
suggest-move-types.rs Update tests 2019-02-07 15:02:17 +01:00
suggest-move-types.stderr Update tests 2019-03-11 23:10:26 +03:00
suggest-on-bare-closure-call.rs When encountetring ||{}(), suggest the likely intended (||{})() 2019-03-08 19:08:28 -08:00
suggest-on-bare-closure-call.stderr Increase spacing for suggestions in diagnostics 2019-10-24 12:26:01 -07:00
suggest-private-fields.rs Remove licenses 2018-12-25 21:08:33 -07:00
suggest-private-fields.stderr use structured suggestions for nonexistent fields 2018-12-31 12:52:30 -05:00
suggest-ref-mut.rs Remove feature(nll) when compare mode is sufficient 2019-05-12 18:46:43 +01:00
suggest-ref-mut.stderr Update ui tests 2019-11-18 19:00:10 +01:00
suggest-remove-refs-1.rs Remove licenses 2018-12-25 21:08:33 -07:00
suggest-remove-refs-1.stderr Only suggest change mut if vars are resolved 2019-10-09 11:42:29 -07:00
suggest-remove-refs-2.rs Remove licenses 2018-12-25 21:08:33 -07:00
suggest-remove-refs-2.stderr Remove licenses 2018-12-25 21:08:33 -07:00
suggest-remove-refs-3.rs Remove licenses 2018-12-25 21:08:33 -07:00
suggest-remove-refs-3.stderr Remove licenses 2018-12-25 21:08:33 -07:00
suggest-std-when-using-type.rs Suggest appropriate path when calling associated item on bare types 2019-04-18 19:18:26 -07:00
suggest-std-when-using-type.stderr Increase spacing for suggestions in diagnostics 2019-10-24 12:26:01 -07:00
suggest-variants.rs Unify output of "variant not found" errors 2020-01-08 08:05:31 -08:00
suggest-variants.stderr Unify output of "variant not found" errors 2020-01-08 08:05:31 -08:00
type-ascription-instead-of-let.rs Hide "type ascription is experimental error" unless it's the only one 2019-03-22 19:50:18 -07:00
type-ascription-instead-of-let.stderr Hide "type ascription is experimental error" unless it's the only one 2019-03-22 19:50:18 -07:00
type-ascription-instead-of-method.rs Expand suggestions for type ascription parse errors 2019-03-22 19:50:18 -07:00
type-ascription-instead-of-method.stderr Handle more cases of typos misinterpreted as type ascription 2019-07-19 10:56:37 -07:00
type-ascription-instead-of-path-2.rs Detect :: -> : typo when involving turbofish 2019-11-04 16:19:55 -08:00
type-ascription-instead-of-path-2.stderr Account for typo in turbofish and suggest :: 2019-11-05 10:29:54 -08:00
type-ascription-instead-of-path.rs diagnostics: Describe crate root modules in DefKind::Mod as "crate" 2019-08-10 23:17:20 +03:00
type-ascription-instead-of-path.stderr diagnostics: Describe crate root modules in DefKind::Mod as "crate" 2019-08-10 23:17:20 +03:00
type-ascription-instead-of-variant.rs Expand suggestions for type ascription parse errors 2019-03-22 19:50:18 -07:00
type-ascription-instead-of-variant.stderr Handle more cases of typos misinterpreted as type ascription 2019-07-19 10:56:37 -07:00
type-mismatch-struct-field-shorthand-2.rs Suggest correct cast for struct fields with shorthand syntax 2019-01-19 20:18:56 -08:00
type-mismatch-struct-field-shorthand-2.stderr Surround types with backticks in type errors 2019-11-18 11:03:04 -08:00
type-mismatch-struct-field-shorthand.fixed Suggest correct cast for struct fields with shorthand syntax 2019-01-19 20:18:56 -08:00
type-mismatch-struct-field-shorthand.rs Suggest correct cast for struct fields with shorthand syntax 2019-01-19 20:18:56 -08:00
type-mismatch-struct-field-shorthand.stderr Surround types with backticks in type errors 2019-11-18 11:03:04 -08:00
unused-closure-argument.rs Suggest appropriate code for unused field when desrtucturing patttern 2019-03-02 15:16:53 -08:00
unused-closure-argument.stderr Normalise notes with the/is 2020-01-24 16:24:50 +00:00
use-type-argument-instead-of-assoc-type.rs Update ui test suite to use dyn 2019-05-29 00:57:31 -04:00
use-type-argument-instead-of-assoc-type.stderr Account for multiple trait bounds with missing associated types 2019-12-24 22:23:02 -08:00
vec-macro-in-pattern.fixed review comments: use structured suggestion 2019-08-09 09:40:26 -07:00
vec-macro-in-pattern.rs review comments: use structured suggestion 2019-08-09 09:40:26 -07:00
vec-macro-in-pattern.stderr parser::pat: remove .fatal calls 2019-12-31 04:33:34 +01:00