rust/library/core/src
bors 9629b90b3f Auto merge of #127722 - BoxyUwU:new_adt_const_params_limitations, r=compiler-errors
Forbid borrows and unsized types from being used as the type of a const generic under `adt_const_params`

Fixes #112219
Fixes #112124
Fixes #112125

### Motivation

Currently the `adt_const_params` feature allows writing `Foo<const N: [u8]>` this is entirely useless as it is not possible to write an expression which evaluates to a type that is not `Sized`. In order to actually use unsized types in const generics they are typically written as `const N: &[u8]` which *is* possible to provide a value of.

Unfortunately allowing the types of const parameters to contain references is non trivial (#120961) as it introduces a number of difficult questions about how equality of references in the type system should behave. References in the types of const generics is largely only useful for using unsized types in const generics.

This PR introduces a new feature gate `unsized_const_parameters` and moves support for `const N: [u8]` and `const N: &...` from `adt_const_params` into it. The goal here hopefully is to experiment with allowing `const N: [u8]` to work without references and then eventually completely forbid references in const generics.

Splitting this out into a new feature gate means that stabilization of `adt_const_params` does not have to resolve #120961 which is the only remaining "big" blocker for the feature. Remaining issues after this are a few ICEs and naming bikeshed for `ConstParamTy`.

### Implementation

The implementation is slightly subtle here as we would like to ensure that a stabilization of `adt_const_params` is forwards compatible with any outcome of `unsized_const_parameters`. This is inherently tricky as we do not support unstable trait implementations and we determine whether a type is valid as the type of a const parameter via a trait bound.

There are a few constraints here:
- We would like to *allow for the possibility* of adding a `Sized` supertrait to `ConstParamTy` in the event that we wind up opting to not support unsized types and instead requiring people to write the 'sized version', e.g. `const N: [u8; M]` instead of `const N: [u8]`.
- Crates should be able to enable `unsized_const_parameters` and write trait implementations of `ConstParamTy` for `!Sized` types without downstream crates that only enable `adt_const_params` being able to observe this (required for std to be able to `impl<T> ConstParamTy for [T]`

Ultimately the way this is accomplished is via having two traits (sad), `ConstParamTy` and `UnsizedConstParamTy`. Depending on whether `unsized_const_parameters` is enabled or not we change which trait is used to check whether a type is allowed to be a const parameter.

Long term (when stabilizing `UnsizedConstParamTy`) it should be possible to completely merge these traits (and derive macros), only having a single `trait ConstParamTy` and `macro ConstParamTy`.

Under `adt_const_params` it is now illegal to directly refer to `ConstParamTy` it is only used as an internal impl detail by `derive(ConstParamTy)` and checking const parameters are well formed. This is necessary in order to ensure forwards compatibility with all possible future directions for `feature(unsized_const_parameters)`.

Generally the intuition here should be that `ConstParamTy` is the stable trait that everything uses, and `UnsizedConstParamTy` is that plus unstable implementations (well, I suppose `ConstParamTy` isn't stable yet :P).
2024-07-21 05:36:21 +00:00
..
alloc alloc::Layout: explicitly document size invariant on the type level 2024-03-25 20:18:46 +01:00
array Replace MaybeUninit::uninit_array() with array repeat expression. 2024-06-24 10:23:50 -07:00
ascii implement Default for AsciiChar 2024-02-13 12:04:44 +01:00
async_iter Hide async_gen_internals from standard library documentation 2024-04-05 18:54:38 -07:00
cell Rename lazy_cell_consume to lazy_cell_into_inner 2024-07-11 03:16:45 -04:00
char Avoid comments that describe multiple use items. 2024-07-17 08:02:46 +10:00
cmp Use generic NonZero everywhere in core. 2024-02-22 15:17:33 +01:00
convert Re-add From<f16> for f64 2024-05-04 22:56:35 +01:00
ffi Rollup merge of #127444 - Sky9x:cstr-bytes-iter, r=dtolnay 2024-07-16 20:10:11 -05:00
fmt Avoid ref when using format! for perf 2024-07-19 12:23:49 -04:00
future Add tracking issue to async_drop API 2024-06-17 17:20:13 +03:00
hash Optimize SipHash by reordering compress instructions 2024-07-01 22:36:40 +00:00
intrinsics Auto merge of #126171 - RalfJung:simd_bitmask_multibyte, r=workingjubilee 2024-07-05 01:58:22 +00:00
io Remove bound checks from BorrowedBuf and BorrowedCursor methods 2024-04-15 10:29:43 +02:00
iter doc: Suggest str::repeat over iter::repeat().take().collect() 2024-07-14 00:51:08 +00:00
macros Rollup merge of #126096 - c410-f3r:tests-tests-tests, r=jhpratt 2024-06-06 14:46:25 -07:00
mem Split part of adt_const_params into unsized_const_params 2024-07-17 11:01:29 +01:00
net Update ip_addr.rs 2024-06-30 14:54:05 -04:00
num improve safety comment 2024-07-19 19:16:33 +08:00
ops Remove feature(effects) from the standard library 2024-06-21 09:23:24 +00:00
panic Stabilize PanicInfo::message() and PanicMessage 2024-06-20 14:06:33 +03:00
prelude Avoid comments that describe multiple use items. 2024-07-17 08:02:46 +10:00
ptr ptr::metadata: update comment on vtable_ptr work-around 2024-07-17 13:56:25 +02:00
range add new_range_api for RFC 3550 2024-07-05 16:33:58 -06:00
slice Updated slice documentation 2024-07-12 18:09:44 -06:00
str add new_range_api for RFC 3550 2024-07-05 16:33:58 -06:00
sync Stabilize atomic_bool_fetch_not 2024-07-01 14:14:22 +02:00
task Remove feature(effects) from the standard library 2024-06-21 09:23:24 +00:00
unicode Avoid comments that describe multiple use items. 2024-07-17 08:02:46 +10:00
any.rs Print TypeId as hex for debugging 2024-06-30 13:36:44 -04:00
arch.rs Rust is a proper name: rust → Rust 2024-03-07 07:49:22 +01:00
ascii.rs Improve escape methods. 2024-05-09 17:04:30 +02:00
asserting.rs [RFC 2011] Library code 2022-05-22 07:18:32 -03:00
bool.rs core is now compilable 2023-04-16 07:20:26 +00:00
borrow.rs Suggest borrowing on fn argument that is impl AsRef 2024-05-09 23:25:31 +00:00
cell.rs replace version placeholder 2024-06-11 16:52:02 +02:00
clone.rs chore: remove duplicate words 2024-07-02 11:25:31 +08:00
cmp.rs Remove feature(effects) from the standard library 2024-06-21 09:23:24 +00:00
default.rs Improve dead code analysis 2024-07-04 22:05:00 +08:00
error.md Mention core's PanicInfo in error.md. 2024-06-11 15:47:00 +02:00
error.rs impl FusedIterator and a size hint for the error sources iter 2024-07-04 23:55:52 -04:00
escape.rs Remove feature(effects) from the standard library 2024-06-21 09:23:24 +00:00
hint.rs chore: remove repeat words 2024-07-04 14:56:08 +08:00
internal_macros.rs Revert "Rollup merge of #125362 - joboet:tait_hack, r=Nilstrieb" 2024-06-12 08:47:49 +00:00
intrinsics.rs Document safety of a few intrinsics 2024-07-04 14:04:11 -07:00
lib.miri.rs add 'x.py miri', and make it work for 'library/{core,alloc,std}' 2024-04-03 20:27:20 +02:00
lib.rs Split part of adt_const_params into unsized_const_params 2024-07-17 11:01:29 +01:00
marker.rs Split part of adt_const_params into unsized_const_params 2024-07-17 11:01:29 +01:00
option.rs Use Option's discriminant as its size hint 2024-07-15 00:34:03 -07:00
panic.rs Stabilize PanicInfo::message() and PanicMessage 2024-06-20 14:06:33 +03:00
panicking.rs Rename std::panic::PanicInfo to PanicHookInfo. 2024-06-11 15:47:00 +02:00
pat.rs Add pattern types to parser 2024-04-08 11:57:17 +00:00
pin.rs Fix typo in docs for std::pin 2024-06-07 12:18:43 -07:00
primitive.rs
primitive_docs.rs Rollup merge of #125043 - RalfJung:ref-type-safety-invariant, r=scottmcm 2024-05-22 23:41:11 +02:00
range.rs add new_range_api for RFC 3550 2024-07-05 16:33:58 -06:00
result.rs Rollup merge of #124870 - Lokathor:update-result-docs, r=dtolnay 2024-05-27 13:10:33 +02:00
time.rs Stabilize duration_abs_diff 2024-06-29 21:03:12 +02:00
tuple.rs Split part of adt_const_params into unsized_const_params 2024-07-17 11:01:29 +01:00
ub_checks.rs export assert_unsafe_precondition macro for std-internal use 2024-04-22 19:02:37 +02:00
unit.rs Import the 2021 prelude in the core crate 2024-03-25 13:12:06 -07:00