build `libcxx-version` only when it doesn't exist In https://github.com/rust-lang/rust/issues/126423, it seems like c++ parsing takes quite amount of time on bootstrap startups. This PR makes libcxx-version to be compiled only when it doesn't exist. A simple demonstration on the overhead of buiding `libcxx-version`: ```sh $ rm -rf build/host/libcxx-version $ x build Building bootstrap Finished `dev` profile [unoptimized] target(s) in 0.07s ----- LIBCXX VERSION CHECK TOOK: 509ms Building tool rustdoc (stage1 -> stage2, x86_64-unknown-linux-gnu) Finished `release` profile [optimized] target(s) in 0.25s Build completed successfully in 0:00:02 $ x build Building bootstrap Finished `dev` profile [unoptimized] target(s) in 0.07s ----- LIBCXX VERSION CHECK TOOK: 2ms Creating a sysroot for stage2 compiler (use `rustup toolchain link 'name' build/host/stage2`) Building tool rustdoc (stage1 -> stage2, x86_64-unknown-linux-gnu) Finished `release` profile [optimized] target(s) in 0.14s Build completed successfully in 0:00:01 ```
378 lines
14 KiB
Rust
378 lines
14 KiB
Rust
//! Sanity checking performed by rustbuild before actually executing anything.
|
|
//!
|
|
//! This module contains the implementation of ensuring that the build
|
|
//! environment looks reasonable before progressing. This will verify that
|
|
//! various programs like git and python exist, along with ensuring that all C
|
|
//! compilers for cross-compiling are found.
|
|
//!
|
|
//! In theory if we get past this phase it's a bug if a build fails, but in
|
|
//! practice that's likely not true!
|
|
|
|
use std::collections::HashMap;
|
|
use std::env;
|
|
use std::ffi::{OsStr, OsString};
|
|
use std::fs;
|
|
use std::path::PathBuf;
|
|
use std::process::Command;
|
|
|
|
#[cfg(not(feature = "bootstrap-self-test"))]
|
|
use crate::builder::Builder;
|
|
#[cfg(not(feature = "bootstrap-self-test"))]
|
|
use crate::core::build_steps::tool;
|
|
#[cfg(not(feature = "bootstrap-self-test"))]
|
|
use std::collections::HashSet;
|
|
|
|
use crate::builder::Kind;
|
|
use crate::core::config::Target;
|
|
use crate::utils::helpers::output;
|
|
use crate::Build;
|
|
|
|
pub struct Finder {
|
|
cache: HashMap<OsString, Option<PathBuf>>,
|
|
path: OsString,
|
|
}
|
|
|
|
// During sanity checks, we search for target names to determine if they exist in the compiler's built-in
|
|
// target list (`rustc --print target-list`). While a target name may be present in the stage2 compiler,
|
|
// it might not yet be included in stage0. In such cases, we handle the targets missing from stage0 in this list.
|
|
//
|
|
// Targets can be removed from this list once they are present in the stage0 compiler (usually by updating the beta compiler of the bootstrap).
|
|
#[cfg(not(feature = "bootstrap-self-test"))]
|
|
const STAGE0_MISSING_TARGETS: &[&str] = &[
|
|
// just a dummy comment so the list doesn't get onelined
|
|
];
|
|
|
|
/// Minimum version threshold for libstdc++ required when using prebuilt LLVM
|
|
/// from CI (with`llvm.download-ci-llvm` option).
|
|
#[cfg(not(feature = "bootstrap-self-test"))]
|
|
const LIBSTDCXX_MIN_VERSION_THRESHOLD: usize = 8;
|
|
|
|
impl Finder {
|
|
pub fn new() -> Self {
|
|
Self { cache: HashMap::new(), path: env::var_os("PATH").unwrap_or_default() }
|
|
}
|
|
|
|
pub fn maybe_have<S: Into<OsString>>(&mut self, cmd: S) -> Option<PathBuf> {
|
|
let cmd: OsString = cmd.into();
|
|
let path = &self.path;
|
|
self.cache
|
|
.entry(cmd.clone())
|
|
.or_insert_with(|| {
|
|
for path in env::split_paths(path) {
|
|
let target = path.join(&cmd);
|
|
let mut cmd_exe = cmd.clone();
|
|
cmd_exe.push(".exe");
|
|
|
|
if target.is_file() // some/path/git
|
|
|| path.join(&cmd_exe).exists() // some/path/git.exe
|
|
|| target.join(&cmd_exe).exists()
|
|
// some/path/git/git.exe
|
|
{
|
|
return Some(target);
|
|
}
|
|
}
|
|
None
|
|
})
|
|
.clone()
|
|
}
|
|
|
|
pub fn must_have<S: AsRef<OsStr>>(&mut self, cmd: S) -> PathBuf {
|
|
self.maybe_have(&cmd).unwrap_or_else(|| {
|
|
panic!("\n\ncouldn't find required command: {:?}\n\n", cmd.as_ref());
|
|
})
|
|
}
|
|
}
|
|
|
|
pub fn check(build: &mut Build) {
|
|
let mut skip_target_sanity =
|
|
env::var_os("BOOTSTRAP_SKIP_TARGET_SANITY").is_some_and(|s| s == "1" || s == "true");
|
|
|
|
skip_target_sanity |= build.config.cmd.kind() == Kind::Check;
|
|
|
|
// Skip target sanity checks when we are doing anything with mir-opt tests or Miri
|
|
let skipped_paths = [OsStr::new("mir-opt"), OsStr::new("miri")];
|
|
skip_target_sanity |= build.config.paths.iter().any(|path| {
|
|
path.components().any(|component| skipped_paths.contains(&component.as_os_str()))
|
|
});
|
|
|
|
let path = env::var_os("PATH").unwrap_or_default();
|
|
// On Windows, quotes are invalid characters for filename paths, and if
|
|
// one is present as part of the PATH then that can lead to the system
|
|
// being unable to identify the files properly. See
|
|
// https://github.com/rust-lang/rust/issues/34959 for more details.
|
|
if cfg!(windows) && path.to_string_lossy().contains('\"') {
|
|
panic!("PATH contains invalid character '\"'");
|
|
}
|
|
|
|
let mut cmd_finder = Finder::new();
|
|
// If we've got a git directory we're gonna need git to update
|
|
// submodules and learn about various other aspects.
|
|
if build.rust_info().is_managed_git_subrepository() {
|
|
cmd_finder.must_have("git");
|
|
}
|
|
|
|
// Ensure that a compatible version of libstdc++ is available on the system when using `llvm.download-ci-llvm`.
|
|
#[cfg(not(feature = "bootstrap-self-test"))]
|
|
if !build.config.dry_run() && !build.build.is_msvc() && build.config.llvm_from_ci {
|
|
let builder = Builder::new(build);
|
|
let libcxx_version = builder.ensure(tool::LibcxxVersionTool { target: build.build });
|
|
|
|
match libcxx_version {
|
|
tool::LibcxxVersion::Gnu(version) => {
|
|
if LIBSTDCXX_MIN_VERSION_THRESHOLD > version {
|
|
eprintln!(
|
|
"\nYour system's libstdc++ version is too old for the `llvm.download-ci-llvm` option."
|
|
);
|
|
eprintln!("Current version detected: '{}'", version);
|
|
eprintln!("Minimum required version: '{}'", LIBSTDCXX_MIN_VERSION_THRESHOLD);
|
|
eprintln!(
|
|
"Consider upgrading libstdc++ or disabling the `llvm.download-ci-llvm` option."
|
|
);
|
|
eprintln!(
|
|
"If you choose to upgrade libstdc++, run `x clean` or delete `build/host/libcxx-version` manually after the upgrade."
|
|
);
|
|
}
|
|
}
|
|
tool::LibcxxVersion::Llvm(_) => {
|
|
// FIXME: Handle libc++ version check.
|
|
}
|
|
}
|
|
}
|
|
|
|
// We need cmake, but only if we're actually building LLVM or sanitizers.
|
|
let building_llvm = !build.config.llvm_from_ci
|
|
&& build
|
|
.hosts
|
|
.iter()
|
|
.map(|host| {
|
|
build.config.llvm_enabled(*host)
|
|
&& build
|
|
.config
|
|
.target_config
|
|
.get(host)
|
|
.map(|config| config.llvm_config.is_none())
|
|
.unwrap_or(true)
|
|
})
|
|
.any(|build_llvm_ourselves| build_llvm_ourselves);
|
|
|
|
let need_cmake = building_llvm || build.config.any_sanitizers_to_build();
|
|
if need_cmake && cmd_finder.maybe_have("cmake").is_none() {
|
|
eprintln!(
|
|
"
|
|
Couldn't find required command: cmake
|
|
|
|
You should install cmake, or set `download-ci-llvm = true` in the
|
|
`[llvm]` section of `config.toml` to download LLVM rather
|
|
than building it.
|
|
"
|
|
);
|
|
crate::exit!(1);
|
|
}
|
|
|
|
build.config.python = build
|
|
.config
|
|
.python
|
|
.take()
|
|
.map(|p| cmd_finder.must_have(p))
|
|
.or_else(|| env::var_os("BOOTSTRAP_PYTHON").map(PathBuf::from)) // set by bootstrap.py
|
|
.or_else(|| cmd_finder.maybe_have("python"))
|
|
.or_else(|| cmd_finder.maybe_have("python3"))
|
|
.or_else(|| cmd_finder.maybe_have("python2"));
|
|
|
|
build.config.nodejs = build
|
|
.config
|
|
.nodejs
|
|
.take()
|
|
.map(|p| cmd_finder.must_have(p))
|
|
.or_else(|| cmd_finder.maybe_have("node"))
|
|
.or_else(|| cmd_finder.maybe_have("nodejs"));
|
|
|
|
build.config.npm = build
|
|
.config
|
|
.npm
|
|
.take()
|
|
.map(|p| cmd_finder.must_have(p))
|
|
.or_else(|| cmd_finder.maybe_have("npm"));
|
|
|
|
build.config.gdb = build
|
|
.config
|
|
.gdb
|
|
.take()
|
|
.map(|p| cmd_finder.must_have(p))
|
|
.or_else(|| cmd_finder.maybe_have("gdb"));
|
|
|
|
build.config.reuse = build
|
|
.config
|
|
.reuse
|
|
.take()
|
|
.map(|p| cmd_finder.must_have(p))
|
|
.or_else(|| cmd_finder.maybe_have("reuse"));
|
|
|
|
#[cfg(not(feature = "bootstrap-self-test"))]
|
|
let stage0_supported_target_list: HashSet<String> =
|
|
output(Command::new(&build.config.initial_rustc).args(["--print", "target-list"]))
|
|
.lines()
|
|
.map(|s| s.to_string())
|
|
.collect();
|
|
|
|
// We're gonna build some custom C code here and there, host triples
|
|
// also build some C++ shims for LLVM so we need a C++ compiler.
|
|
for target in &build.targets {
|
|
// On emscripten we don't actually need the C compiler to just
|
|
// build the target artifacts, only for testing. For the sake
|
|
// of easier bot configuration, just skip detection.
|
|
if target.contains("emscripten") {
|
|
continue;
|
|
}
|
|
|
|
// We don't use a C compiler on wasm32
|
|
if target.contains("wasm32") {
|
|
continue;
|
|
}
|
|
|
|
// skip check for cross-targets
|
|
if skip_target_sanity && target != &build.build {
|
|
continue;
|
|
}
|
|
|
|
// Ignore fake targets that are only used for unit tests in bootstrap.
|
|
#[cfg(not(feature = "bootstrap-self-test"))]
|
|
{
|
|
let mut has_target = false;
|
|
let target_str = target.to_string();
|
|
|
|
let missing_targets_hashset: HashSet<_> =
|
|
STAGE0_MISSING_TARGETS.iter().map(|t| t.to_string()).collect();
|
|
let duplicated_targets: Vec<_> =
|
|
stage0_supported_target_list.intersection(&missing_targets_hashset).collect();
|
|
|
|
if !duplicated_targets.is_empty() {
|
|
println!(
|
|
"Following targets supported from the stage0 compiler, please remove them from STAGE0_MISSING_TARGETS list."
|
|
);
|
|
for duplicated_target in duplicated_targets {
|
|
println!(" {duplicated_target}");
|
|
}
|
|
std::process::exit(1);
|
|
}
|
|
|
|
// Check if it's a built-in target.
|
|
has_target |= stage0_supported_target_list.contains(&target_str);
|
|
has_target |= STAGE0_MISSING_TARGETS.contains(&target_str.as_str());
|
|
|
|
if !has_target {
|
|
// This might also be a custom target, so check the target file that could have been specified by the user.
|
|
if let Some(custom_target_path) = env::var_os("RUST_TARGET_PATH") {
|
|
let mut target_filename = OsString::from(&target_str);
|
|
// Target filename ends with `.json`.
|
|
target_filename.push(".json");
|
|
|
|
// Recursively traverse through nested directories.
|
|
let walker = walkdir::WalkDir::new(custom_target_path).into_iter();
|
|
for entry in walker.filter_map(|e| e.ok()) {
|
|
has_target |= entry.file_name() == target_filename;
|
|
}
|
|
}
|
|
}
|
|
|
|
if !has_target {
|
|
panic!(
|
|
"No such target exists in the target list,
|
|
specify a correct location of the JSON specification file for custom targets!"
|
|
);
|
|
}
|
|
}
|
|
|
|
if !build.config.dry_run() {
|
|
cmd_finder.must_have(build.cc(*target));
|
|
if let Some(ar) = build.ar(*target) {
|
|
cmd_finder.must_have(ar);
|
|
}
|
|
}
|
|
}
|
|
|
|
for host in &build.hosts {
|
|
if !build.config.dry_run() {
|
|
cmd_finder.must_have(build.cxx(*host).unwrap());
|
|
}
|
|
|
|
if build.config.llvm_enabled(*host) {
|
|
// Externally configured LLVM requires FileCheck to exist
|
|
let filecheck = build.llvm_filecheck(build.build);
|
|
if !filecheck.starts_with(&build.out)
|
|
&& !filecheck.exists()
|
|
&& build.config.codegen_tests
|
|
{
|
|
panic!("FileCheck executable {filecheck:?} does not exist");
|
|
}
|
|
}
|
|
}
|
|
|
|
for target in &build.targets {
|
|
build
|
|
.config
|
|
.target_config
|
|
.entry(*target)
|
|
.or_insert_with(|| Target::from_triple(&target.triple));
|
|
|
|
if (target.contains("-none-") || target.contains("nvptx"))
|
|
&& build.no_std(*target) == Some(false)
|
|
{
|
|
panic!("All the *-none-* and nvptx* targets are no-std targets")
|
|
}
|
|
|
|
// skip check for cross-targets
|
|
if skip_target_sanity && target != &build.build {
|
|
continue;
|
|
}
|
|
|
|
// Make sure musl-root is valid.
|
|
if target.contains("musl") && !target.contains("unikraft") {
|
|
// If this is a native target (host is also musl) and no musl-root is given,
|
|
// fall back to the system toolchain in /usr before giving up
|
|
if build.musl_root(*target).is_none() && build.config.build == *target {
|
|
let target = build.config.target_config.entry(*target).or_default();
|
|
target.musl_root = Some("/usr".into());
|
|
}
|
|
match build.musl_libdir(*target) {
|
|
Some(libdir) => {
|
|
if fs::metadata(libdir.join("libc.a")).is_err() {
|
|
panic!("couldn't find libc.a in musl libdir: {}", libdir.display());
|
|
}
|
|
}
|
|
None => panic!(
|
|
"when targeting MUSL either the rust.musl-root \
|
|
option or the target.$TARGET.musl-root option must \
|
|
be specified in config.toml"
|
|
),
|
|
}
|
|
}
|
|
|
|
if need_cmake && target.is_msvc() {
|
|
// There are three builds of cmake on windows: MSVC, MinGW, and
|
|
// Cygwin. The Cygwin build does not have generators for Visual
|
|
// Studio, so detect that here and error.
|
|
let out = output(Command::new("cmake").arg("--help"));
|
|
if !out.contains("Visual Studio") {
|
|
panic!(
|
|
"
|
|
cmake does not support Visual Studio generators.
|
|
|
|
This is likely due to it being an msys/cygwin build of cmake,
|
|
rather than the required windows version, built using MinGW
|
|
or Visual Studio.
|
|
|
|
If you are building under msys2 try installing the mingw-w64-x86_64-cmake
|
|
package instead of cmake:
|
|
|
|
$ pacman -R cmake && pacman -S mingw-w64-x86_64-cmake
|
|
"
|
|
);
|
|
}
|
|
}
|
|
}
|
|
|
|
if let Some(ref s) = build.config.ccache {
|
|
cmd_finder.must_have(s);
|
|
}
|
|
}
|