rust/tests/ui/bool_comparison.fixed

#![allow(non_local_definitions, clippy::needless_ifs)]
#![warn(clippy::bool_comparison)]
#![allow(clippy::non_canonical_partial_ord_impl)]

fn main() {
    let x = true;
    let _ = if x { "yes" } else { "no" };
    //~^ bool_comparison
    let _ = if !x { "yes" } else { "no" };
    //~^ bool_comparison
    let _ = if x { "yes" } else { "no" };
    //~^ bool_comparison
    let _ = if !x { "yes" } else { "no" };
    //~^ bool_comparison
    let _ = if !x { "yes" } else { "no" };
    //~^ bool_comparison
    let _ = if x { "yes" } else { "no" };
    //~^ bool_comparison
    let _ = if !x { "yes" } else { "no" };
    //~^ bool_comparison
    let _ = if x { "yes" } else { "no" };
    //~^ bool_comparison
    let _ = if !x { "yes" } else { "no" };
    //~^ bool_comparison
    let _ = if x { "yes" } else { "no" };
    //~^ bool_comparison
    let _ = if x { "yes" } else { "no" };
    //~^ bool_comparison
    let _ = if !x { "yes" } else { "no" };
    //~^ bool_comparison

    let y = true;
    let _ = if !x & y { "yes" } else { "no" };
    //~^ bool_comparison
    let _ = if x & !y { "yes" } else { "no" };
    //~^ bool_comparison
}

fn issue3703() {
    struct Foo;
    impl PartialEq<bool> for Foo {
        fn eq(&self, _: &bool) -> bool {
            true
        }
    }
    impl PartialEq<Foo> for bool {
        fn eq(&self, _: &Foo) -> bool {
            true
        }
    }
    impl PartialOrd<bool> for Foo {
        fn partial_cmp(&self, _: &bool) -> Option<std::cmp::Ordering> {
            None
        }
    }
    impl PartialOrd<Foo> for bool {
        fn partial_cmp(&self, _: &Foo) -> Option<std::cmp::Ordering> {
            None
        }
    }

    if Foo == true {}
    if true == Foo {}
    if Foo != true {}
    if true != Foo {}
    if Foo == false {}
    if false == Foo {}
    if Foo != false {}
    if false != Foo {}
    if Foo < false {}
    if false < Foo {}
}

macro_rules! m {
    ($func:ident) => {
        $func()
    };
}

fn func() -> bool {
    true
}

fn issue3973() {
    // ok, don't lint on `cfg` invocation
    if false == cfg!(feature = "debugging") {}
    if cfg!(feature = "debugging") == false {}
    if true == cfg!(feature = "debugging") {}
    if cfg!(feature = "debugging") == true {}

    // lint, could be simplified
    if !m!(func) {}
    //~^ bool_comparison
    if !m!(func) {}
    //~^ bool_comparison
    if m!(func) {}
    //~^ bool_comparison
    if m!(func) {}
    //~^ bool_comparison

    // no lint with a variable
    let is_debug = false;
    if is_debug == cfg!(feature = "debugging") {}
    if cfg!(feature = "debugging") == is_debug {}
    if is_debug == m!(func) {}
    if m!(func) == is_debug {}
    let is_debug = true;
    if is_debug == cfg!(feature = "debugging") {}
    if cfg!(feature = "debugging") == is_debug {}
    if is_debug == m!(func) {}
    if m!(func) == is_debug {}
}

#[allow(clippy::unnecessary_cast)]
fn issue9907() {
    let _ = (1 >= 2) as usize;
    //~^ bool_comparison
    let _ = (!m!(func)) as usize;
    //~^ bool_comparison
    // This is not part of the issue, but an unexpected found when fixing the issue,
    // the provided span was inside of macro rather than the macro callsite.
    let _ = ((1 < 2) & !m!(func)) as usize;
    //~^ bool_comparison
}

#[allow(clippy::nonminimal_bool)]
fn issue15367() {
    let a = true;
    let b = false;

    // these cases are handled by `nonminimal_bool`, so don't double-lint
    if a == !b {};
    if !a == b {};
    if b == !a {};
    if !b == a {};
}

fn issue15497() {
    fn func() -> bool {
        true
    }

    fn foo(x: bool) -> bool {
        x & !m!(func)
        //~^ bool_comparison
    }

    fn bar(x: bool) -> bool {
        !x & m!(func)
        //~^ bool_comparison
    }
}