user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
rust/src/test/ui/hygiene
History
Manish Goregaokar 9593e61f64
Rollup merge of #88838 - FabianWolff:issue-88472, r=estebank 
Do not suggest importing inaccessible items

Fixes #88472. For this example:
```rust
mod a {
    struct Foo;
}

mod b {
    type Bar = Foo;
}
```
rustc currently emits:
```
error[E0412]: cannot find type `Foo` in this scope
 --> test.rs:6:16
  |
6 |     type Bar = Foo;
  |                ^^^ not found in this scope
  |
help: consider importing this struct
  |
6 |     use a::Foo;
  |
```
this is incorrect, as applying this suggestion leads to
```
error[E0603]: struct `Foo` is private
 --> test.rs:6:12
  |
6 |     use a::Foo;
  |            ^^^ private struct
  |
note: the struct `Foo` is defined here
 --> test.rs:2:5
  |
2 |     struct Foo;
  |     ^^^^^^^^^^^
```
With my changes, I get:
```
error[E0412]: cannot find type `Foo` in this scope
 --> test.rs:6:16
  |
6 |     type Bar = Foo;
  |                ^^^ not found in this scope
  |
  = note: this struct exists but is inaccessible:
          a::Foo
```
As for the wildcard mentioned in #88472, I would argue that the warning is actually correct, since the import _is_ unused. I think the real issue is the wrong suggestion, which I have fixed here.
2021-09-30 23:41:05 -07:00
..
auxiliary Make SEMICOLON_IN_EXPRESSIONS_FROM_MACROS warn by default 2021-07-27 14:17:37 -05:00
arguments.rs Remove licenses 2018-12-25 21:08:33 -07:00
arguments.stderr Update tests 2019-03-11 23:10:26 +03:00
assoc_item_ctxt.rs Remove licenses 2018-12-25 21:08:33 -07:00
assoc_item_ctxt.stderr Suggest similarly named assoc items in trait impls 2021-09-29 00:22:32 +09:00
assoc_ty_bindings.rs use dyn Trait more in tests 2020-02-10 17:42:09 +01:00
cross-crate-codegen-attrs.rs Stop emulating cross-crate hygiene with gensyms 2019-08-17 08:59:36 +01:00
cross_crate_hygiene.rs Hygiene serialization implementation 2020-07-26 18:37:02 -04:00
dollar-crate-modern.rs Make error and warning annotations mandatory in UI tests 2019-11-10 21:01:02 +01:00
duplicate_lifetimes.rs Disallow duplicate lifetime parameters with legacy hygiene 2019-07-28 13:33:51 +01:00
duplicate_lifetimes.stderr Show macro name in 'this error originates in macro' message 2021-05-12 19:03:06 -04:00
eager-from-opaque-2.rs Add a regression test for issue #63460 2019-08-21 12:53:11 +03:00
eager-from-opaque.rs expand: Do not do questionable span adjustment before eagerly expanding an expression 2019-08-21 11:53:39 +03:00
expansion-info-reset.rs Change all run-pass hygiene tests to ui tests 2019-07-16 21:20:39 +01:00
expansion-info-reset.stderr Modify structured suggestion output 2021-08-11 09:46:24 +00:00
extern-prelude-from-opaque-fail.rs Clarify message about unresolved use 2020-09-01 18:38:14 +01:00
extern-prelude-from-opaque-fail.stderr Show macro name in 'this error originates in macro' message 2021-05-12 19:03:06 -04:00
fields-definition.rs Remove licenses 2018-12-25 21:08:33 -07:00
fields-definition.stderr Show macro name in 'this error originates in macro' message 2021-05-12 19:03:06 -04:00
fields-move.rs Remove licenses 2018-12-25 21:08:33 -07:00
fields-move.stderr Show macro name in 'this error originates in macro' message 2021-05-12 19:03:06 -04:00
fields-numeric-borrowck.rs Remove licenses 2018-12-25 21:08:33 -07:00
fields-numeric-borrowck.stderr Use larger span for adjustments on method calls 2021-09-25 10:00:41 -05:00
fields.rs pretty: trim paths of unique symbols 2020-09-02 22:26:37 +03:00
fields.stderr Show macro name in 'this error originates in macro' message 2021-05-12 19:03:06 -04:00
for-loop.rs Remove licenses 2018-12-25 21:08:33 -07:00
for-loop.stderr Update tests 2019-03-11 23:10:26 +03:00
format-args.rs Remove gensym from format_args 2019-08-05 23:50:47 +01:00
generate-mod.rs #[rustc_transparent_macro] -> #[rustc_macro_transparency = ...] 2019-07-06 16:59:08 +03:00
generate-mod.stderr Show macro name in 'this error originates in macro' message 2021-05-12 19:03:06 -04:00
generic_params.rs feature(const_generics) -> feature(const_param_types) 2021-08-30 11:00:21 +02:00
globs.rs Remove licenses 2018-12-25 21:08:33 -07:00
globs.stderr Do not suggest importing inaccessible items 2021-09-26 18:43:58 +02:00
hir-res-hygiene.rs hir: introduce QPath::LangItem 2020-08-16 15:42:25 +01:00
hygiene-dodging-1.rs Change all run-pass hygiene tests to ui tests 2019-07-16 21:20:39 +01:00
hygiene.rs Change all run-pass hygiene tests to ui tests 2019-07-16 21:20:39 +01:00
hygienic-label-1.rs Make SEMICOLON_IN_EXPRESSIONS_FROM_MACROS warn by default 2021-07-27 14:17:37 -05:00
hygienic-label-1.stderr Make SEMICOLON_IN_EXPRESSIONS_FROM_MACROS warn by default 2021-07-27 14:17:37 -05:00
hygienic-label-2.rs Remove licenses 2018-12-25 21:08:33 -07:00
hygienic-label-2.stderr tweak unresolved label suggestion 2019-04-04 10:04:48 -04:00
hygienic-label-3.rs Make SEMICOLON_IN_EXPRESSIONS_FROM_MACROS warn by default 2021-07-27 14:17:37 -05:00
hygienic-label-3.stderr Make SEMICOLON_IN_EXPRESSIONS_FROM_MACROS warn by default 2021-07-27 14:17:37 -05:00
hygienic-label-4.rs Remove licenses 2018-12-25 21:08:33 -07:00
hygienic-label-4.stderr tweak unresolved label suggestion 2019-04-04 10:04:48 -04:00
hygienic-labels-in-let.rs Cleaned up unused labels 2019-11-15 16:31:30 -08:00
hygienic-labels-in-let.stderr Show macro name in 'this error originates in macro' message 2021-05-12 19:03:06 -04:00
hygienic-labels.rs Cleaned up unused labels 2019-11-15 16:31:30 -08:00
hygienic-labels.stderr Show macro name in 'this error originates in macro' message 2021-05-12 19:03:06 -04:00
impl_items.rs Remove licenses 2018-12-25 21:08:33 -07:00
impl_items.stderr Show macro name in 'this error originates in macro' message 2021-05-12 19:03:06 -04:00
intercrate.rs pretty: trim paths of unique symbols 2020-09-02 22:26:37 +03:00
intercrate.stderr Show macro name in 'this error originates in macro' message 2021-05-12 19:03:06 -04:00
issue-40847.rs Move some tests to more reasonable directories 2021-02-16 21:22:21 -03:00
issue-44128.rs Change all run-pass hygiene tests to ui tests 2019-07-16 21:20:39 +01:00
issue-47311.rs Change all run-pass hygiene tests to ui tests 2019-07-16 21:20:39 +01:00
issue-47312.rs Change all run-pass hygiene tests to ui tests 2019-07-16 21:20:39 +01:00
issue-61574-const-parameters.rs feature(const_generics) -> feature(const_param_types) 2021-08-30 11:00:21 +02:00
issue-77523-def-site-async-await.rs Record expansion_that_defined into crate metadata 2020-10-05 16:01:19 -04:00
items.rs Change all run-pass hygiene tests to ui tests 2019-07-16 21:20:39 +01:00
legacy_interaction.rs Change all run-pass hygiene tests to ui tests 2019-07-16 21:20:39 +01:00
lexical.rs Change all run-pass hygiene tests to ui tests 2019-07-16 21:20:39 +01:00
local_inner_macros.rs Change all run-pass hygiene tests to ui tests 2019-07-16 21:20:39 +01:00
macro-metavars-legacy.rs Make macro metavars respect (non-)hygiene 2020-03-16 17:13:48 +00:00
macro-metavars-transparent.rs Make macro metavars respect (non-)hygiene 2020-03-16 17:13:48 +00:00
missing-self-diag.rs Emit a better diagnostic when function actually has a 'self' parameter 2020-05-17 19:04:13 -04:00
missing-self-diag.stderr Show macro name in 'this error originates in macro' message 2021-05-12 19:03:06 -04:00
nested-dollar-crate.rs Add test for use of $crate in nested foreign macro_rules! 2020-07-26 18:37:02 -04:00
nested_macro_privacy.rs pretty: trim paths of unique symbols 2020-09-02 22:26:37 +03:00
nested_macro_privacy.stderr pretty: trim paths of unique symbols 2020-09-02 22:26:37 +03:00
no_implicit_prelude-2018.rs resolve: Remove ! from "cannot find" diagnostics for macros 2019-09-15 13:22:07 +03:00
no_implicit_prelude-2018.stderr Re-run tests with --bless 2020-09-30 12:00:59 +06:00
no_implicit_prelude-2021.rs Add test for assert!() hygiene in edition 2021. 2021-01-09 20:54:41 +01:00
no_implicit_prelude.rs Qualify panic! as core::panic! in non-built-in core macros 2020-11-23 11:28:25 -08:00
no_implicit_prelude.stderr Bless tests. 2021-09-02 19:08:59 +02:00
panic-location.rs Hygiene serialization implementation 2020-07-26 18:37:02 -04:00
panic-location.run.stderr refactor: vec_deque ignore-tidy-filelength 2020-11-13 17:56:39 +00:00
pattern-macro.rs Remove licenses 2018-12-25 21:08:33 -07:00
pattern-macro.stderr Update tests 2019-03-11 23:10:26 +03:00
prelude-import-hygiene.rs Make use of hygiene in AST passes 2019-09-05 15:07:16 +01:00
privacy-early.rs resolve: Move late resolution into a separate visitor 2019-08-10 13:15:15 +03:00
privacy-early.stderr Show macro name in 'this error originates in macro' message 2021-05-12 19:03:06 -04:00
privacy.rs Remove licenses 2018-12-25 21:08:33 -07:00
privacy.stderr Normalize wording of privacy access labels 2020-03-22 15:36:54 -07:00
rustc-macro-transparency.rs resolve: Attempt to resolve unresolved paths in macro namespace 2019-07-18 13:42:45 +03:00
rustc-macro-transparency.stderr Modify structured suggestion output 2021-08-11 09:46:24 +00:00
specialization.rs Change all run-pass hygiene tests to ui tests 2019-07-16 21:20:39 +01:00
stdlib-prelude-from-opaque-early.rs resolve: Fix access to extern and stdlib prelude from opaque macros 2019-07-11 00:12:08 +03:00
stdlib-prelude-from-opaque-late.rs resolve: Fix access to extern and stdlib prelude from opaque macros 2019-07-11 00:12:08 +03:00
trait_items-2.rs Change all run-pass hygiene tests to ui tests 2019-07-16 21:20:39 +01:00
trait_items.rs Unify output of "variant not found" errors 2020-01-08 08:05:31 -08:00
trait_items.stderr Bless tests. 2021-09-02 19:08:59 +02:00
traits-in-scope.rs resolve: Simplify collection of traits in scope 2021-01-11 23:49:47 +03:00
transparent-basic.rs Change all run-pass hygiene tests to ui tests 2019-07-16 21:20:39 +01:00
unpretty-debug.rs Make pretty-expanded-hygiene a ui test 2019-07-16 21:23:29 +01:00
unpretty-debug.stdout Use LocalExpnId where possible. 2021-07-17 19:41:02 +02:00
wrap_unhygienic_example.rs Change all run-pass hygiene tests to ui tests 2019-07-16 21:20:39 +01:00
xcrate.rs Change all run-pass hygiene tests to ui tests 2019-07-16 21:20:39 +01:00