rust/compiler/rustc_hir_analysis/src
bors d9a2cc4dae Auto merge of #128506 - compiler-errors:by-move-body, r=cjgillot
Stop storing a special inner body for the coroutine by-move body for async closures

...and instead, just synthesize an item which is treated mostly normally by the MIR pipeline.

This PR does a few things:
* We synthesize a new `DefId` for the by-move body of a closure, which has its `mir_built` fed with the output of the `ByMoveBody` MIR transformation, and some other relevant queries.
* This has the `DefKind::ByMoveBody`, which we use to distinguish it from "real" bodies (that come from HIR) which need to be borrowck'd. Introduce `TyCtxt::is_synthetic_mir` to skip over `mir_borrowck` which is called by `mir_promoted`; borrowck isn't really possible to make work ATM since it heavily relies being called on a body generated from HIR, and is redundant by the construction of the by-move-body.
* Remove the special `PassManager` hacks for handling the inner `by_move_body` stored within the coroutine's mir body. Instead, this body is fed like a regular MIR body, so it's goes through all of the `tcx.*_mir` stages normally (build -> promoted -> ...etc... -> optimized) .
* Remove the `InstanceKind::ByMoveBody` shim, since now we have a "regular" def id, we can just use `InstanceKind::Item`. This also allows us to remove the corresponding hacks from codegen, such as in `fn_sig_for_fn_abi` .

Notable remarks:
* ~~I know it's kind of weird to be using `DefKind::Closure` here, since it's not a distinct closure but just a new MIR body. I don't believe it really matters, but I could also use a different `DefKind`... maybe one that we could use for synthetic MIR bodies in general?~~ edit: We're doing this now.
2024-08-27 23:30:24 +00:00
..
check Auto merge of #128506 - compiler-errors:by-move-body, r=cjgillot 2024-08-27 23:30:24 +00:00
coherence Add warn(unreachable_pub) to rustc_hir_analysis. 2024-08-27 13:14:50 +10:00
collect Add warn(unreachable_pub) to rustc_hir_analysis. 2024-08-27 13:14:50 +10:00
errors Add warn(unreachable_pub) to rustc_hir_analysis. 2024-08-27 13:14:50 +10:00
hir_ty_lowering Add warn(unreachable_pub) to rustc_hir_analysis. 2024-08-27 13:14:50 +10:00
impl_wf_check Reformat use declarations. 2024-07-29 08:26:52 +10:00
outlives Add warn(unreachable_pub) to rustc_hir_analysis. 2024-08-27 13:14:50 +10:00
variance Add warn(unreachable_pub) to rustc_hir_analysis. 2024-08-27 13:14:50 +10:00
autoderef.rs Reformat use declarations. 2024-07-29 08:26:52 +10:00
bounds.rs Add warn(unreachable_pub) to rustc_hir_analysis. 2024-08-27 13:14:50 +10:00
check_unused.rs Add warn(unreachable_pub) to rustc_hir_analysis. 2024-08-27 13:14:50 +10:00
collect.rs Rework how we emit errors for unresolved object lifetimes 2024-08-24 14:55:31 -04:00
constrained_generic_params.rs Add warn(unreachable_pub) to rustc_hir_analysis. 2024-08-27 13:14:50 +10:00
delegation.rs Use assert_matches around the compiler 2024-08-11 12:25:39 -04:00
errors.rs Add warn(unreachable_pub) to rustc_hir_analysis. 2024-08-27 13:14:50 +10:00
hir_wf_check.rs Add warn(unreachable_pub) to rustc_hir_analysis. 2024-08-27 13:14:50 +10:00
impl_wf_check.rs Add warn(unreachable_pub) to rustc_hir_analysis. 2024-08-27 13:14:50 +10:00
lib.rs Auto merge of #128506 - compiler-errors:by-move-body, r=cjgillot 2024-08-27 23:30:24 +00:00