rust/src/test
bors df89fd2063 Auto merge of #91752 - yaahc:track-caller-result, r=cuviper
Readd track_caller to Result::from_residual

This is a followup on https://github.com/rust-lang/rust/issues/87401 in and an attempt to move the issue towards resolution.

As part of the overhaul of the Try trait we removed the ability for errors to grab location information during propagation via `?` with the builtin `std::result::Result`. The previously linked issue has a fair bit of discussion into the reasons for and against the usage of `#[track_caller]` on the `FromResidual` impl on `Result` that I will do my best to summarize.

---
### For

- https://github.com/rust-lang/rust/issues/87401#issuecomment-915053533: Difficulties with using non `std::result::Result` like types
- https://github.com/rust-lang/rust/issues/87401#issuecomment-978355102: Inconsistency with functionality provided for recoverable (Result) and non-recoverable errors (panic), where panic provides a location and Result does not, pushing some users towards using panic

### Against

- https://github.com/rust-lang/rust/issues/84277#issuecomment-885322833: concern that this will bloat callers that never use this data

---

Personally, I want to quantify the performance / bloat impact of re-adding this attribute, and fully evaluate the pros and cons before deciding if I need to switch `eyre` to have a custom `Result` type, which would also mean I need `try_trait_v2` to be stabilized, cc `@scottmcm.` If the performance impact is minor enough in the general case I think I would prefer that the default `Result` type has the ability to track location information for consistency with `panic` error reporting, and leave it to applications that need particularly high performance to handle the micro optimizations of introducing their own efficient custom Result type or matching manually.

Alternatively, I wonder if the performance penalty on code that doesn't use the location information on `FromResidual` could be mitigated via new optimizations.
2021-12-15 06:34:00 +00:00
..
assembly Address review feedback 2021-12-12 11:26:59 +00:00
auxiliary
codegen Auto merge of #91728 - Amanieu:stable_asm, r=joshtriplett 2021-12-14 21:15:22 +00:00
codegen-units Collect panic/panic_bounds_check during monomorphization 2021-10-30 18:21:44 +01:00
debuginfo tests: Ignore test/debuginfo/rc_arc.rs on windows-gnu 2021-11-28 23:09:33 +08:00
incremental Auto merge of #91728 - Amanieu:stable_asm, r=joshtriplett 2021-12-14 21:15:22 +00:00
mir-opt bless new output on some mir-opt tests 2021-12-10 12:19:47 -08:00
pretty Stabilize asm! and global_asm! 2021-12-12 11:20:03 +00:00
run-make Stabilize asm! and global_asm! 2021-12-12 11:20:03 +00:00
run-make-fulldeps Rollup merge of #91868 - tmiasko:llvm-time-trace-out, r=oli-obk 2021-12-15 01:28:06 +01:00
run-pass-valgrind
rustdoc Auto merge of #91728 - Amanieu:stable_asm, r=joshtriplett 2021-12-14 21:15:22 +00:00
rustdoc-gui Rollup merge of #91534 - jsha:heading-color, r=GuillaumeGomez 2021-12-08 23:18:05 +01:00
rustdoc-js Fix warnings in rustdoc JS tests 2021-11-28 11:49:12 -08:00
rustdoc-js-std Fix linkcheck issues 2021-09-12 02:30:24 +00:00
rustdoc-json Create rustdoc_internals feature gate 2021-11-24 21:57:18 +01:00
rustdoc-ui Rollup merge of #91717 - inashivb:issue-91713, r=jyn514 2021-12-11 16:02:49 +01:00
ui Auto merge of #91945 - matthiaskrgr:rollup-jszf9zp, r=matthiaskrgr 2021-12-15 03:28:55 +00:00
ui-fulldeps Take a LocalDefId in expect_*item. 2021-11-28 21:09:45 +01:00
COMPILER_TESTS.md