user0/rust
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
rust/clippy_lints/src/methods
History
bors ef95be517c Auto merge of #11609 - y21:get_first_non_primitives, r=giraffate 
[`get_first`]: lint on non-primitive slices

Fixes #11594

I left the issue open for a couple days before making the PR to see if anyone has something to say, but it looks like there aren't any objections to removing this check that prevented linting on non-primitive slices, so here's the PR now.
There's a couple of instances in clippy itself where we now emit the lint. The actual relevant change is in the first commit and fixing the `.get(0)` instances in clippy itself is in the 2nd commit.

changelog: [`get_first`]: lint on non-primitive slices
2023-10-15 23:53:22 +00:00
..
bind_instead_of_map.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
bytecount.rs Add sym::iter_mut + sym::as_mut_ptr 2023-07-25 23:33:08 +00:00
bytes_count_to_len.rs refactor(rustc_middle): Substs -> GenericArg 2023-07-14 13:27:35 +01:00
bytes_nth.rs Merge commit '149392b0ba' into clippyup 2023-02-25 19:28:50 -05:00
case_sensitive_file_extension_comparisons.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
chars_cmp.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
chars_cmp_with_unwrap.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
chars_last_cmp.rs Merge commit 'f4850f7292' into clippyup 2022-11-21 20:51:52 +01:00
chars_last_cmp_with_unwrap.rs Merge commit 'f4850f7292' into clippyup 2022-11-21 20:51:52 +01:00
chars_next_cmp.rs Merge commit 'f4850f7292' into clippyup 2022-11-21 20:51:52 +01:00
chars_next_cmp_with_unwrap.rs Merge commit 'f4850f7292' into clippyup 2022-11-21 20:51:52 +01:00
clear_with_drain.rs Merge commit '83e42a2337' into clippyup 2023-04-11 15:31:08 +02:00
clone_on_copy.rs Move scrutinee HirId into MatchSource::TryDesugar 2023-08-14 21:43:56 +00:00
clone_on_ref_ptr.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
cloned_instead_of_copied.rs Merge commit 'd822110d3b' into clippyup 2022-12-01 18:29:38 +01:00
collapsible_str_replace.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
drain_collect.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
err_expect.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
expect_fun_call.rs Merge commit '7671c283a5' into clippyup 2023-09-25 11:28:58 +02:00
extend_with_drain.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
filetype_is_file.rs Merge commit 'ac0e10aa68' into clippyup 2022-10-06 09:44:38 +02:00
filter_map.rs Merge commit '5436dba826' into clippyup 2023-07-31 23:53:53 +02:00
filter_map_bool_then.rs Merge commit '7671c283a5' into clippyup 2023-09-25 11:28:58 +02:00
filter_map_identity.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
filter_map_next.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
filter_next.rs Improve spans for indexing expressions 2023-08-04 13:17:39 +02:00
flat_map_identity.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
flat_map_option.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
format_collect.rs Merge commit '5436dba826' into clippyup 2023-07-31 23:53:53 +02:00
from_iter_instead_of_collect.rs Merge commit 'ac0e10aa68' into clippyup 2022-10-06 09:44:38 +02:00
get_first.rs [get_first]: lint on non-primitive types 2023-10-04 18:07:54 +02:00
get_last_with_len.rs Merge commit 'ac0e10aa68' into clippyup 2022-10-06 09:44:38 +02:00
get_unwrap.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
implicit_clone.rs Merge commit '080b587854' into clippyup 2023-08-24 21:32:12 +02:00
inefficient_to_string.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
inspect_for_each.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
into_iter_on_ref.rs Merge commit '4f142aa105' into clippyup 2022-10-23 15:18:45 +02:00
is_digit_ascii_radix.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
iter_cloned_collect.rs Merge commit 'ac0e10aa68' into clippyup 2022-10-06 09:44:38 +02:00
iter_count.rs Merge commit 'ac0e10aa68' into clippyup 2022-10-06 09:44:38 +02:00
iter_kv_map.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
iter_next_slice.rs Improve spans for indexing expressions 2023-08-04 13:17:39 +02:00
iter_nth.rs Merge commit '37f4c1725d' into clippyup 2023-07-02 14:59:02 +02:00
iter_nth_zero.rs Merge commit '37f4c1725d' into clippyup 2023-07-02 14:59:02 +02:00
iter_on_single_or_empty_collections.rs Merge commit 'f4850f7292' into clippyup 2022-11-21 20:51:52 +01:00
iter_out_of_bounds.rs Merge commit '98363cbf6a' into clippyup 2023-09-12 18:44:06 +02:00
iter_overeager_cloned.rs Merge commit '98363cbf6a' into clippyup 2023-09-12 18:44:06 +02:00
iter_skip_next.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
iter_skip_zero.rs Merge commit '5436dba826' into clippyup 2023-07-31 23:53:53 +02:00
iter_with_drain.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
iterator_step_by_zero.rs Merge commit '435a8ad86c' into clippyup 2023-05-20 15:39:26 +02:00
manual_next_back.rs Merge commit '435a8ad86c' into clippyup 2023-05-20 15:39:26 +02:00
manual_ok_or.rs refactor(rustc_middle): Substs -> GenericArg 2023-07-14 13:27:35 +01:00
manual_saturating_arithmetic.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
manual_str_repeat.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
manual_try_fold.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
map_clone.rs refactor(rustc_middle): Substs -> GenericArg 2023-07-14 13:27:35 +01:00
map_collect_result_unit.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
map_err_ignore.rs refactor(rustc_middle): Substs -> GenericArg 2023-07-14 13:27:35 +01:00
map_flatten.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
map_identity.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
map_unwrap_or.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
mod.rs Update version attribute for 1.73 lints 2023-10-04 01:08:45 +02:00
mut_mutex_lock.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
needless_collect.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
needless_option_as_deref.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
needless_option_take.rs Merge commit '7c21f91b15' into clippyup 2022-05-05 15:12:52 +01:00
no_effect_replace.rs Rm diagnostic item, use lang item 2022-11-18 06:16:20 +00:00
obfuscated_if_else.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
ok_expect.rs refactor(rustc_middle): Substs -> GenericArg 2023-07-14 13:27:35 +01:00
open_options.rs refactor(rustc_middle): Substs -> GenericArg 2023-07-14 13:27:35 +01:00
option_as_ref_deref.rs Merge commit 'd822110d3b' into clippyup 2022-12-01 18:29:38 +01:00
option_map_or_none.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
option_map_unwrap_or.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
or_fun_call.rs Merge commit '080b587854' into clippyup 2023-08-24 21:32:12 +02:00
or_then_unwrap.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
path_buf_push_overwrite.rs refactor(rustc_middle): Substs -> GenericArg 2023-07-14 13:27:35 +01:00
path_ends_with_ext.rs Merge commit '7671c283a5' into clippyup 2023-09-25 11:28:58 +02:00
range_zip_with_len.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
read_line_without_trim.rs Merge commit '5436dba826' into clippyup 2023-07-31 23:53:53 +02:00
readonly_write_lock.rs Merge commit '5436dba826' into clippyup 2023-07-31 23:53:53 +02:00
redundant_as_str.rs Merge commit '7671c283a5' into clippyup 2023-09-25 11:28:58 +02:00
repeat_once.rs Merge commit '435a8ad86c' into clippyup 2023-05-20 15:39:26 +02:00
search_is_some.rs dogfood 2023-10-04 18:08:30 +02:00
seek_from_current.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
seek_to_start_instead_of_rewind.rs Merge commit '371120bdbf' into clippyup 2023-05-05 17:45:49 +02:00
single_char_add_str.rs separate the receiver from arguments in HIR under /clippy 2022-09-05 22:25:57 +09:00
single_char_insert_string.rs Merge commit 'ac0e10aa68' into clippyup 2022-10-06 09:44:38 +02:00
single_char_pattern.rs Use is_str instead of string kind comparison 2023-02-13 19:06:22 +00:00
single_char_push_string.rs Merge commit 'ac0e10aa68' into clippyup 2022-10-06 09:44:38 +02:00
skip_while_next.rs Merge commit 'b40ea209e7' into clippyup 2021-04-08 17:50:13 +02:00
stable_sort_primitive.rs refactor(rustc_middle): Substs -> GenericArg 2023-07-14 13:27:35 +01:00
str_splitn.rs Move scrutinee HirId into MatchSource::TryDesugar 2023-08-14 21:43:56 +00:00
string_extend_chars.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
string_lit_chars_any.rs Merge commit '5436dba826' into clippyup 2023-07-31 23:53:53 +02:00
suspicious_command_arg_space.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
suspicious_map.rs Remove HirId -> LocalDefId map from HIR. 2023-01-28 09:55:26 +00:00
suspicious_splitn.rs refactor(rustc_middle): Substs -> GenericArg 2023-07-14 13:27:35 +01:00
suspicious_to_owned.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
type_id_on_box.rs Merge commit '5436dba826' into clippyup 2023-07-31 23:53:53 +02:00
uninit_assumed_init.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
unit_hash.rs Merge commit 'f51aade56f' into clippyup 2022-08-31 09:24:45 -04:00
unnecessary_filter_map.rs Merge commit '5436dba826' into clippyup 2023-07-31 23:53:53 +02:00
unnecessary_fold.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
unnecessary_iter_cloned.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
unnecessary_join.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
unnecessary_lazy_eval.rs Merge commit '4f3ab69ea0' into clippyup 2022-12-29 14:28:34 +01:00
unnecessary_literal_unwrap.rs Merge remote-tracking branch 'upstream/master' into rustup 2023-10-06 17:31:44 +02:00
unnecessary_sort_by.rs Merge remote-tracking branch 'upstream/master' into rustup 2023-07-28 23:44:28 +02:00
unnecessary_to_owned.rs subst -> instantiate 2023-09-26 09:37:55 +02:00
unwrap_expect_used.rs Merge commit '1e8fdf4928' into clippyup 2023-08-11 14:05:13 +02:00
useless_asref.rs Merge commit 'd9c24d1b1e' into clippyup 2023-07-17 10:22:32 +02:00
utils.rs refactor(rustc_middle): Substs -> GenericArg 2023-07-14 13:27:35 +01:00
vec_resize_to_zero.rs refactor(rustc_middle): Substs -> GenericArg 2023-07-14 13:27:35 +01:00
verbose_file_reads.rs Merge commit 'f51aade56f' into clippyup 2022-08-31 09:24:45 -04:00
wrong_self_convention.rs Merge commit 'ac0e10aa68' into clippyup 2022-10-06 09:44:38 +02:00
zst_offset.rs Overhaul TyS and Ty. 2022-02-15 16:03:24 +11:00