rust/tests
bors f70c73f5c4 Auto merge of #8692 - kyoto7250:fixing_unnecessary_to_owned, r=giraffate
fix unnecessary_to_owned about msrv

This PR fixes ``[`unnecessary_owned`]``.

## What

```rust
# sample code
fn _msrv_1_35() {
    #![clippy::msrv = "1.35"]
    let _ = &["x"][..].to_vec().into_iter();
}

fn _msrv_1_36() {
    #![clippy::msrv = "1.36"]
    let _ = &["x"][..].to_vec().into_iter();
}
```

If we will check this code using clippy, ``[`unnecessary_owned`]`` will modify the code as follows.

```rust
error: unnecessary use of `to_vec`
  --> $DIR/unnecessary_to_owned.rs:219:14
   |
LL |     let _ = &["x"][..].to_vec().into_iter();
   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `["x"][..].iter().copied()`

error: unnecessary use of `to_vec`
  --> $DIR/unnecessary_to_owned.rs:224:14
   |
LL |     let _ = &["x"][..].to_vec().into_iter();
   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `["x"][..].iter().copied()`
```

This is incorrect. Because `Iterator::copied` was estabilished in 1.36.

## Why

This bug was caused by not separating "copied" and "clone" by reference to msrv.

89ee6aa6e3/clippy_lints/src/methods/unnecessary_to_owned.rs (L195)

So, I added a conditional branch and described the corresponding test.

Thank you in advance.

changelog: fix wrong suggestions about msrv in [`unnecessary_to_owned`]

r! `@giraffate`
2022-04-13 00:57:08 +00:00
..
test_utils Merge commit '97a5daa659' into clippyup 2022-01-13 13:18:19 +01:00
ui Auto merge of #8692 - kyoto7250:fixing_unnecessary_to_owned, r=giraffate 2022-04-13 00:57:08 +00:00
ui-cargo Handle relative paths in module_files lints 2022-03-30 18:44:04 +01:00
ui-internal Merge remote-tracking branch 'upstream/master' into rustup 2022-04-07 15:44:37 +01:00
ui-toml adding condition for map_clone message 2022-04-12 04:03:48 +09:00
workspace_test Merge commit '97a5daa659' into clippyup 2022-01-13 13:18:19 +01:00
check-fmt.rs Run fmt test before compile-test/dogfood 2022-04-02 12:34:06 +01:00
clippy.toml Merge commit '3ae8faff4d' into clippyup 2021-06-03 08:41:37 +02:00
compile-test.rs Merge commit 'dc5423ad44' into clippyup 2022-03-14 12:02:53 +01:00
dogfood.rs Merge commit '97a5daa659' into clippyup 2022-01-13 13:18:19 +01:00
integration.rs Merge commit 'cb7915b00c' into clippyup 2021-09-28 18:03:12 +01:00
lint_message_convention.rs resolve the conflict in compiler/rustc_session/src/parse.rs 2022-03-16 20:12:30 +08:00
missing-test-files.rs Merge commit 'e181011378' into clippyup 2021-11-04 12:52:36 +00:00
versioncheck.rs Remove cargo_metadata dependency from clippy 2022-04-01 23:18:47 -04:00
workspace.rs resolve the conflict in compiler/rustc_session/src/parse.rs 2022-03-16 20:12:30 +08:00